commit 08d0dcb4b038acb73a3fb44e258a36c688f60b7c
author Paul Berry <paulberry@google.com> Fri May 25 19:22:03 2018 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> Fri May 25 19:22:03 2018 +0000
tree e7caef504d5366a1c5351251c6d2b8eb19cf7eff
parent 462e350a6aa6cda0db625a4d45652dba957c860f

Observatory strong mode fixes: specify some list literal types.

In some cases we need to specify a type because the inferred type
would be too specific.  For example, in the code:

    final content = [new SampleBufferControlElement(...)];
    ...
    content.addAll([new BRElement(), ...]);

Strong mode would infer a type of `List<SampleBufferControlElement>`
for `content`, making it impossible to add other kinds of HTML
elements to the list later.  So we have to specify explicitly that the
list element type is meant to be `HTMLElement`.

In other cases we need to specify a type because the inferred type is
too general.  For example, in the code:

    Future<List<String>> complete(...) {
      var result = [];
      ...add values of type String to `result`...
      return new Future.value(result);
    }

Strong mode would infer a type of `List<dynamic>` for `result`, making
it impossible to enclose in a `Future<List<String>>`.  So we have to
specify explicitly that the list element type is meant to be `String`.

Change-Id: I1b1c884529de2775898dfff800d250cd10629811
Reviewed-on: https://dart-review.googlesource.com/56700
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>