| commit | 0895727c592e036589cc7b39ee70ff27850f42dd | [log] [tgz] |
|---|---|---|
| author | Sam Rawlins <srawlins@google.com> | Mon Apr 22 16:53:42 2024 +0000 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Apr 22 16:53:42 2024 +0000 |
| tree | 19fd5da084ab7845af31504f39b8c155f92e200b | |
| parent | 7a13b558069d354b62d75fc8ea1b156a0785af39 [diff] |
analyzer: allow trailing whitespace in ignore comments Fixes https://github.com/dart-lang/sdk/issues/54247 The main piece of this CL is a rewrite of the `ignoredElements` extension on CommentToken. This was a private extension getter, but is made public now for two reasons: first is to reference it in tests, and second is to make it available for a new lint rule in an upcoming CL. The new implementation drops all use of RegExp in order to more precisely track when we may be at the end of a list of diagnostic names and/or types. So the functional change here is that a diagnostic name or type followed by whitespace instead of a comma marks the end of the list. Any characters following that whitespace are not parsed, as they are considered freeform comment text. While the new implementation parses a comment code-unit-by-code-unit, it is still a rather concise impl. * Rename DiagnosticName and DiagnosticType to IgnoredDiagnosticName and IgnoredDiagnosticType; these names make more sense to me, specifically when they are used outside of the ignore_info.dart file. * I introduce a new test file, ignore_info_test, to capture these various parsing particulars, that aren't specifically concerned with matching an ignore comment with a diagnostic. A few test cases from ErrorSuppressionTest are moved over here. * A number of String (well, int, technically) helper functions are moved to analyzer, along with their tests. Fixes https://github.com/dart-lang/sdk/issues/54247 Change-Id: Ife08d448a4e03b8a55b183d88a3ea8d07812fbdc Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/363820 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.