[vm/win] Ensure no message boxes for crashes on windows debug builds.
Follow-up to https://dart.googlesource.com/sdk/+/543dbdd708de6da4a461e15147940e08231bba9d
TEST=manually on windows
BUG=https://github.com/dart-lang/sdk/issues/54275
Change-Id: Iec70cb37ab6b6133ce7599fead3ffabc5ba92312
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/340388
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
diff --git a/runtime/bin/platform_win.cc b/runtime/bin/platform_win.cc
index b083506..51d9f0b 100644
--- a/runtime/bin/platform_win.cc
+++ b/runtime/bin/platform_win.cc
@@ -35,9 +35,12 @@
// hitting an assertion failure.
// See: https://msdn.microsoft.com/en-us/library/a9yf33zb.aspx
_set_invalid_parameter_handler(InvalidParameterHandler);
- // Disable the message box for assertions in the CRT in Debug builds.
+ // Disable the message box for assertions, errors and warnings in the CRT
+ // in Debug builds.
// See: https://msdn.microsoft.com/en-us/library/1y71x448.aspx
_CrtSetReportMode(_CRT_ASSERT, 0);
+ _CrtSetReportMode(_CRT_ERROR, 0);
+ _CrtSetReportMode(_CRT_WARN, 0);
// Disable dialog boxes for "critical" errors or when OpenFile cannot find
// the requested file. However only disable error boxes for general
diff --git a/runtime/tests/vm/vm.status b/runtime/tests/vm/vm.status
index ecc619c..37cc9c7 100644
--- a/runtime/tests/vm/vm.status
+++ b/runtime/tests/vm/vm.status
@@ -292,9 +292,6 @@
[ $compiler == dartkp && ($sanitizer == tsan || $simulator) ]
dart/regress_45898_test: Pass, Slow
-[ $mode == debug && $runtime == dart_precompiled && $system == windows ]
-in_memory_elf_test: Skip # dartbug.com/54275 - the test causes purple aot bots
-
[ $mode == debug && $system == windows ]
dart/spawn_shutdown_test: Skip # Flaky crashes unable to start thread; likely low memory on the bot.
