commit 07da83d321bd9e4afc582fdaffd97161f686a09d
author Martin Kustermann <kustermann@google.com> Wed Aug 14 10:00:49 2024 +0000
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Aug 14 10:00:49 2024 +0000
tree ad323c030c1fd3abc16de9f4f9c88ddc96f70e69
parent b888da751ed8f2174d2ef5bd50eacabb24979745

[dart2wasm] Simplify source map flag code in `dart compile wasm`

After [0] lands we can remove a workaround in `dart compile wasm` that
checks for `--extra-compiler-option=--no-source-maps`.

[0] https://github.com/flutter/flutter/pull/153417

Change-Id: I19f4da96e198d73e2309652aa2aa08d5e2c72d48
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380461
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Ömer Ağacan <omersa@google.com>

pkg/dartdev/lib/src/commands/compile.dart

diff --git a/pkg/dartdev/lib/src/commands/compile.dart b/pkg/dartdev/lib/src/commands/compile.dart
index 6e6ff17..61f9145 100644
--- a/pkg/dartdev/lib/src/commands/compile.dart
+++ b/pkg/dartdev/lib/src/commands/compile.dart
@@ -809,13 +809,7 @@
     handleOverride(optimizationFlags, 'minify',
         args.wasParsed('minify') ? args.flag('minify') : null);
 
-    bool generateSourceMap = args.flag('source-maps');
-    // TODO(kustermann): Remive this temporary change when flutter no longer
-    // uses --extra-compiler-option=--no-source-maps
-    if (extraCompilerOptions.any((o) => o == '--no-source-maps')) {
-      generateSourceMap = false;
-    }
-
+    final generateSourceMap = args.flag('source-maps');
     final enabledExperiments = args.enabledExperiments;
     final dart2wasmCommand = [
       sdk.dartAotRuntime,