commit 074d6e1309faa1db0b923d5208f1092f09eb2eca
author Tess Strickland <sstrickl@google.com> Thu Sep 24 13:57:52 2020 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> Thu Sep 24 13:57:52 2020 +0000
tree d99955515e9404dedf21a6213a561d98549b75e8
parent 4e2556215add763daa0efaf349d5442e9c73be3b

Revert "[vm] Allow BaseWriteStream::WriteFixed to be used at unaligned positions."

This reverts commit 4e2556215add763daa0efaf349d5442e9c73be3b.

Reason for revert: Adding PRINTF_ATTRIBUTE broke more than expected on Mac bots.

Original change's description:
> [vm] Allow BaseWriteStream::WriteFixed to be used at unaligned positions.
>
> For snapshot writing, we generally only have aligned writes so the old
> methods worked well, but in some formats (like DWARF) we're not
> guaranteed to have aligned writes and so had to use WriteBytes.
> Instead, have WriteFixed call WriteBytes and replace any other uses of
> WriteBytes(&value, sizeof(value)) with WriteFixed(value) instead.
>
> Also makes the following additional changes:
>
> * Expose WriteByte(value), instead of forcing use of
>   WriteFixed<uint8_t> or Raw<1,T>::Write to get the same behavior.
>
> * Rename Print/VPrint to Printf/VPrintf, so methods taking format
>   strings are named consistently with others in the codebase.
>
> * Add format string checking to Printf when supported.
>
> * Add AddString() for non-formatted string writing.
>
> Change-Id: I5a2e91380bc41b0502e1a576acec786dfe66abbf
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164161
> Commit-Queue: Tess Strickland <sstrickl@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>

TBR=kustermann@google.com,rmacnak@google.com,sstrickl@google.com

Change-Id: Ie90ac4477f4c581692b37429536ce8dd66788540
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164323
Reviewed-by: Tess Strickland <sstrickl@google.com>
Commit-Queue: Tess Strickland <sstrickl@google.com>