tree bffe8c41cb53755d0f922498878b500a05b49253
parent 818b2a007af581f147a11d302b25c9a30a334ee0
author Paul Berry <paulberry@google.com> 1756298401 -0700
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> 1756298401 -0700

[analyzer] Convert a few errors to literate diagnostic reporting.

This change modifies the following four errors to use the analyzer's
new literate diagnostic reporting API:

- `CompileTimeErrorCode.abstractFieldConstructorInitializer`
- `CompileTimeErrorCode.abstractSuperMemberReference`
- `CompileTimeErrorCode.baseClassImplementedOutsideOfLibrary`
- `CompileTimeErrorCode.baseMixinImplementedOutsideOfLibrary`

Also, the parameter names used by these messages are changed from the
old placeholder names (`p0`, `p1`, etc.) to names that appropriately
discribe their functions.

This should be enough to validate the overall approach. After this, I
will move over to the CFE side, to give its `withArguments` methods
the ability to accept named parameters rather than positional ones.

Change-Id: I6a6a6964fca29633c18dc7945cdd7def0bbabdf3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/447060
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>