)]}'
{
  "commit": "060e4e7e2ee9200b2fa0d45e5b84e2bca4e8d1db",
  "tree": "bdc80950aa656c56d1b7b23b5fd50fa95fdb3516",
  "parents": [
    "b6e430641101c7a771e04b607f09884ccef444d4"
  ],
  "author": {
    "name": "Danny Tuppeny",
    "email": "danny@tuppeny.com",
    "time": "Thu Jul 23 07:47:38 2026 -0700"
  },
  "committer": {
    "name": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Thu Jul 23 07:47:38 2026 -0700"
  },
  "message": "[analysis_server] Switch LSP tests to use workspaceAnalysisComplete() instead of progress/status notifications\n\nProgress/status notifications for analysis are not a reliably indicator of analysis being complete. They might not be sent if there is no work, or may have multiple bursts in case of plugins. The new `dart/workspace/analysis/complete` request was added as a reliably signal that all pending work is complete.\n\nThis change updates all tests that used the progress/status notifications to know analysis had completed (except tests that were specifically testing the notifications), removing concepts like \"initialAnalysis\" which could be unsound with plugins (or debouncing of status notifications).\n\nI also replaced some `await pumpEventQueue();` which followed calls to the server with `await workspaceAnalysisComplete();` because it should also be more reliable. However `pumpEventQueue` remains when it\u0027s after synchronous modifications to the resource provider, since otherwise the server might not have started processing the watch event before we called it.\n\nChange-Id: I342890c82e18848b9bffc00876141216fbbcd5c7\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/526482\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nReviewed-by: Samuel Rawlins \u003csrawlins@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "0005e5fa4f7fee7032eb511ed9220d57583d2013",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/benchmark/perf/memory_tests.dart",
      "new_id": "e7996952494d7e89fd751e8ec94807e7d5510842",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/benchmark/perf/memory_tests.dart"
    },
    {
      "type": "modify",
      "old_id": "5f63c1725ad535b5ad1a4a9fe20d9c797d34e5cf",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/integration_test/lsp_server/analyzer_status_test.dart",
      "new_id": "e82b51eb96080c3d2bf0dbe850bb35ba240cecf6",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/integration_test/lsp_server/analyzer_status_test.dart"
    },
    {
      "type": "modify",
      "old_id": "056a43bbe98d10a89a8659e75c4d8c208d4fbfaf",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/integration_test/server/message_scheduler_test.dart",
      "new_id": "0e09acc79a72487c8296e65a383406baba8d1263",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/integration_test/server/message_scheduler_test.dart"
    },
    {
      "type": "modify",
      "old_id": "64d059119aaa149f4af0d00f78fa1bd14c28eb2a",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/analyzer_status_test.dart",
      "new_id": "f48c3bc4ea85e0a39976d66948f490aa245f5eb8",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/analyzer_status_test.dart"
    },
    {
      "type": "modify",
      "old_id": "0bf64416e2e52ef9467108397e2c59edbdac7c22",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/cancel_request_test.dart",
      "new_id": "79c294a6bd8160d39dad59f5f2ab878ea81d5910",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/cancel_request_test.dart"
    },
    {
      "type": "modify",
      "old_id": "994f7549998194aaca2f6674b315923254f18861",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/completion_dart_test.dart",
      "new_id": "c0293ac8f47c4574e85b780787f4dfe5bdb2d99d",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/completion_dart_test.dart"
    },
    {
      "type": "modify",
      "old_id": "9024b6861a0504d7bfd4b3fc1eb694ad2236bdd3",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/diagnostic_test.dart",
      "new_id": "eabbb019a5e18b56df488fa5e740d15a2cc86910",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/diagnostic_test.dart"
    },
    {
      "type": "modify",
      "old_id": "ec8b76b8e5fd59bb308985dd31ea463004d488fb",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/document_changes_test.dart",
      "new_id": "f1a7239df623cca897fe93f42e431306dc58bc12",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/document_changes_test.dart"
    },
    {
      "type": "modify",
      "old_id": "a6040a318ff93b180edf0156856fbeba33764e08",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/hover_test.dart",
      "new_id": "828b91e5364d1df3628494f7a692ab8310cdd54d",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/hover_test.dart"
    },
    {
      "type": "modify",
      "old_id": "63b8526114219c58eefb58f6560accbe26b0a123",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/import_test.dart",
      "new_id": "427abbdf536debe5935642eecc52c2d5aed34046",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/import_test.dart"
    },
    {
      "type": "modify",
      "old_id": "b6c275e830b58e3a8ad5c14b27037796fdfd868f",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/inline_value_test.dart",
      "new_id": "cc8069dd759c89855dca3bace2df8fdd4b796aee",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/inline_value_test.dart"
    },
    {
      "type": "modify",
      "old_id": "787bb19ddf7997ea6dbcd3498577b14ea403b638",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/migrate_test.dart",
      "new_id": "45cca7321f1a7c386b7a4e96ddad55df743e43db",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/migrate_test.dart"
    },
    {
      "type": "modify",
      "old_id": "921101fdd725e1e18a7fe08427fec823a008bf64",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/outline_test.dart",
      "new_id": "95709e882f4e6d15bfce468d31196641f7e717e2",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/outline_test.dart"
    },
    {
      "type": "modify",
      "old_id": "d02e69b721bba0f439fba30b04df099048a7f7c3",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/reanalyze_test.dart",
      "new_id": "1eeea09f2c5839397fc3001204a29003c653ae95",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/reanalyze_test.dart"
    },
    {
      "type": "modify",
      "old_id": "d6df260eeead5061211fefcc6780d3c023c830d9",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/rename_test.dart",
      "new_id": "98ca7c4b2401d4abc9945133e1d92be3c4780a9f",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/rename_test.dart"
    },
    {
      "type": "modify",
      "old_id": "763a4826e3dfa220450cf7657b60d793ebfc66a2",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/server_abstract.dart",
      "new_id": "ba20214d41516f876a25f802d1b900b0d714eed4",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/server_abstract.dart"
    },
    {
      "type": "modify",
      "old_id": "e4ca00366b342f708914a07c8b52282f2300c4bd",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/server_test.dart",
      "new_id": "e941045abbc5fab6f1e97dd324cea4807cc66ab7",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/server_test.dart"
    },
    {
      "type": "modify",
      "old_id": "a1184f3da4512bcdf251b20bd591c3b154004ec8",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/signature_help_test.dart",
      "new_id": "711c1effd2dba24a920aa07ce17ac0cf6f5d078e",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/signature_help_test.dart"
    },
    {
      "type": "modify",
      "old_id": "b8c19840daa4122cb633e5c4a041b4f1e84cabbe",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/temporary_overlay_operation_test.dart",
      "new_id": "c900c471418a771793af658e04083b12375a871f",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/temporary_overlay_operation_test.dart"
    },
    {
      "type": "modify",
      "old_id": "8be941aa77196f13c0f289e790d5c6037ca4d6a3",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/workspace_analysis_complete_test.dart",
      "new_id": "0b197ff9fb119b8575ff50fa13b6f203f657cdd6",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/workspace_analysis_complete_test.dart"
    },
    {
      "type": "modify",
      "old_id": "5bbd151d153df32b82c92ff4391d9d49860d377d",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp_over_legacy/abstract_lsp_over_legacy.dart",
      "new_id": "9cf4cba197f29d51e342e0c1c9c01083021f4c4e",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp_over_legacy/abstract_lsp_over_legacy.dart"
    },
    {
      "type": "modify",
      "old_id": "23b0e7ba58ee3111483a1b834c2429f6acd90a19",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/shared/shared_edit_argument_tests.dart",
      "new_id": "b9385352261ba175ad763476b871046e7633d1d3",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/shared/shared_edit_argument_tests.dart"
    },
    {
      "type": "modify",
      "old_id": "c8939ce82db5c62770d529379bb93880ae2c12e8",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/shared/shared_editable_arguments_tests.dart",
      "new_id": "57ccdb13b3810a67db110532612cc93851add1cc",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/shared/shared_editable_arguments_tests.dart"
    },
    {
      "type": "modify",
      "old_id": "72636c5388823be147f59f6abda26893243ecc97",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/shared/shared_test_interface.dart",
      "new_id": "d19986f53a9f8a13eae82b79485551dbd10feade",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/shared/shared_test_interface.dart"
    }
  ]
}