[ddc] Delete more unsound null safety tests
These were tests of the expression compiler and worker when
the source code under test was running with unsound null
safety.
Issue: https://github.com/dart-lang/sdk/issues/55692
Change-Id: Ia34a7203fc24295dd1dde246a56ca29add4009d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366180
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
diff --git a/pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_dart_2_17_test.dart b/pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_dart_2_17_test.dart
index 2b699e3..2487afc 100644
--- a/pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_dart_2_17_test.dart
+++ b/pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_dart_2_17_test.dart
@@ -17,26 +17,6 @@
await driver.finish();
});
- group('(Unsound null safety)', () {
- group('(AMD module system)', () {
- var setup = SetupCompilerOptions(
- soundNullSafety: false,
- moduleFormat: ModuleFormat.amd,
- args: args,
- );
- runSharedTests(setup, driver);
- });
-
- group('(DDC module system)', () {
- var setup = SetupCompilerOptions(
- soundNullSafety: false,
- moduleFormat: ModuleFormat.ddc,
- args: args,
- );
- runSharedTests(setup, driver);
- });
- });
-
group('(Sound null safety)', () {
group('(AMD module system)', () {
var setup = SetupCompilerOptions(
diff --git a/pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_dart_3_0_test.dart b/pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_dart_3_0_test.dart
index 886523e..9e9fc3b 100644
--- a/pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_dart_3_0_test.dart
+++ b/pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_dart_3_0_test.dart
@@ -17,26 +17,6 @@
await driver.finish();
});
- group('(Unsound null safety)', () {
- group('(AMD module system)', () {
- var setup = SetupCompilerOptions(
- soundNullSafety: false,
- moduleFormat: ModuleFormat.amd,
- args: args,
- );
- runSharedTests(setup, driver);
- });
-
- group('(DDC module system)', () {
- var setup = SetupCompilerOptions(
- soundNullSafety: false,
- moduleFormat: ModuleFormat.ddc,
- args: args,
- );
- runSharedTests(setup, driver);
- });
- });
-
group('(Sound null safety)', () {
group('(AMD module system)', () {
var setup = SetupCompilerOptions(
diff --git a/pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_shared.dart b/pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_shared.dart
index a707f29..08ffc0e 100644
--- a/pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_shared.dart
+++ b/pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_shared.dart
@@ -284,8 +284,6 @@
''';
/// Shared tests that require a language version >=2.12.0 <2.17.0.
-// TODO(nshahan) Merge with [runAgnosticSharedTests] after we no longer need to
-// test support for evaluation in legacy (pre-null safety) code.
void runNullSafeSharedTests(
SetupCompilerOptions setup, ExpressionEvaluationTestDriver driver) {
group('JS interop', () {
diff --git a/pkg/dev_compiler/test/expression_compiler/expression_compiler_test.dart b/pkg/dev_compiler/test/expression_compiler/expression_compiler_test.dart
index 599fe84..08fa1f6 100644
--- a/pkg/dev_compiler/test/expression_compiler/expression_compiler_test.dart
+++ b/pkg/dev_compiler/test/expression_compiler/expression_compiler_test.dart
@@ -11,18 +11,6 @@
void main(List<String> args) {
for (var moduleFormat in [ModuleFormat.amd, ModuleFormat.ddc]) {
group('Module format: $moduleFormat |', () {
- group('Unsound null safety |', () {
- runTests(SetupCompilerOptions(
- soundNullSafety: false,
- moduleFormat: moduleFormat,
- args: args,
- ));
- });
- });
- }
-
- for (var moduleFormat in [ModuleFormat.amd, ModuleFormat.ddc]) {
- group('Module format: $moduleFormat |', () {
group('Sound null safety |', () {
runTests(SetupCompilerOptions(
soundNullSafety: true,
diff --git a/pkg/dev_compiler/test/expression_compiler/expression_compiler_worker_amd_test.dart b/pkg/dev_compiler/test/expression_compiler/expression_compiler_worker_amd_test.dart
index a4e26af..af5ef9f 100644
--- a/pkg/dev_compiler/test/expression_compiler/expression_compiler_worker_amd_test.dart
+++ b/pkg/dev_compiler/test/expression_compiler/expression_compiler_worker_amd_test.dart
@@ -12,16 +12,12 @@
// Set to true to enable debug output
var debug = false;
- group('amd module format -', () {
- for (var soundNullSafety in [true, false]) {
- group('${soundNullSafety ? "sound" : "unsound"} null safety -', () {
- var setup = SetupCompilerOptions(
- moduleFormat: ModuleFormat.amd,
- soundNullSafety: soundNullSafety,
- args: args,
- );
- runTests(setup, verbose: debug);
- });
- }
+ group('amd module format - sound null safety -', () {
+ var setup = SetupCompilerOptions(
+ moduleFormat: ModuleFormat.amd,
+ soundNullSafety: true,
+ args: args,
+ );
+ runTests(setup, verbose: debug);
});
}
diff --git a/pkg/dev_compiler/test/expression_compiler/expression_compiler_worker_ddc_test.dart b/pkg/dev_compiler/test/expression_compiler/expression_compiler_worker_ddc_test.dart
index 220c92e..b24b5fe 100644
--- a/pkg/dev_compiler/test/expression_compiler/expression_compiler_worker_ddc_test.dart
+++ b/pkg/dev_compiler/test/expression_compiler/expression_compiler_worker_ddc_test.dart
@@ -12,16 +12,12 @@
// Set to true to enable debug output
var debug = false;
- group('ddc module format -', () {
- for (var soundNullSafety in [true, false]) {
- group('${soundNullSafety ? "sound" : "unsound"} null safety -', () {
- var setup = SetupCompilerOptions(
- moduleFormat: ModuleFormat.ddc,
- soundNullSafety: soundNullSafety,
- args: args,
- );
- runTests(setup, verbose: debug);
- });
- }
+ group('ddc module format - sound null safety -', () {
+ var setup = SetupCompilerOptions(
+ moduleFormat: ModuleFormat.ddc,
+ soundNullSafety: true,
+ args: args,
+ );
+ runTests(setup, verbose: debug);
});
}
