[analyzer server] Legacy protocol debounces hover requests too TL;DR: By only responding (for real) to the newest hover request a benchmark that used to take ~10 seconds now takes ~0.6 seconds. Details: In https://github.com/dart-lang/sdk/issues/55281#issuecomment-2700500279 I noticed that some of the performance issues people are seeing fom the analyzer server stem from many requests being fired, each taking longer the wait before the next is issued, naturally building up a longer and loger queue before responses are made. Their it was for `edit.getFixes`, but I'm yet to actually reproduce that. I did reproduce for hover requests though, so here I'm debounsing those hover requests. I'm hooking into the system that already debounces completion requests and following the pattern used there. On my machine, running ``` out/ReleaseX64/dart-sdk/bin/dart \ pkg/analysis_server/tool/benchmark_tools/big_chain_benchmark/legacy_many_hover_requests.dart ``` I get these numbers: Before CL (taken from the parent CL that introduces the benchmark): ``` 4 files / CodeType.ImportCycle: Initial analysis: 1.249438 Completion after change: 10.143719 4 files / CodeType.ImportChain: Initial analysis: 1.367604 Completion after change: 9.936909 4 files / CodeType.ImportExportCycle: Initial analysis: 1.233644 Completion after change: 10.011695 4 files / CodeType.ImportExportChain: Initial analysis: 1.226382 Completion after change: 9.875991 4 files / CodeType.ImportCycleExportChain: Initial analysis: 1.262932 Completion after change: 9.995607 ``` With CL: ``` 4 files / CodeType.ImportCycle: Initial analysis: 1.322501 Completion after change: 0.569768 4 files / CodeType.ImportChain: Initial analysis: 1.347588 Completion after change: 0.635748 4 files / CodeType.ImportExportCycle: Initial analysis: 1.492362 Completion after change: 0.575233 4 files / CodeType.ImportExportChain: Initial analysis: 1.331619 Completion after change: 0.576199 4 files / CodeType.ImportCycleExportChain: Initial analysis: 1.342130 Completion after change: 0.608064 ``` Change-Id: Ide3dbc4dfb885af9e1c46a763338ba545c0ab7db Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413982 Reviewed-by: Phil Quitslund <pquitslund@google.com> Commit-Queue: Jens Johansen <jensj@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents in our repo at docs.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.