)]}' { "log": [ { "commit": "a70ee07cc20c1c9f2c50d102bbbeb221c78aa86a", "tree": "c7efe932e863cbc485bf1ab6d07e6f34467180c5", "parents": [ "d24b5d1f5eebffa8b20eddbdf5a9607aefeef5ab" ], "author": { "name": "Sam Rawlins", "email": "srawlins@google.com", "time": "Fri Mar 29 06:40:43 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Mar 29 06:40:43 2024 +0000" }, "message": "Add TargetKind.typeParameter\n\nFixes https://github.com/dart-lang/sdk/issues/49796\n\nChange-Id: I434c3bba20cbcf26177db4f0dc199bb696ab04de\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/360122\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nCommit-Queue: Samuel Rawlins \u003csrawlins@google.com\u003e\n" }, { "commit": "d24b5d1f5eebffa8b20eddbdf5a9607aefeef5ab", "tree": "ff2c17ca0ef9f9180f061266481614d1ddb51f81", "parents": [ "06677996645c824fc066d6602a8265f58dcae5c5" ], "author": { "name": "Alexander Markov", "email": "alexmarkov@google.com", "time": "Thu Mar 28 20:43:59 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 28 20:43:59 2024 +0000" }, "message": "[vm] Replace array GetIndexed graph intrinsics with flow graph builder implementation\n\n_Array, _GrowableList, internal and external typed data \u0027operator []\u0027\nare now implemented in the flow graph builder.\n\nUnlike graph intrinsics, flow graph created in the flow graph builder\ncan be used by the inliner. Corresponding graph intrinsics and native\nmethods are removed.\n\nAlso, this change adds missing external typed data indexing operations.\n\nTEST\u003dci\n\nChange-Id: Ic19784481feadf54c096a587413e67b4e18353dc\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359940\nReviewed-by: Ryan Macnak \u003crmacnak@google.com\u003e\nCommit-Queue: Alexander Markov \u003calexmarkov@google.com\u003e\n" }, { "commit": "06677996645c824fc066d6602a8265f58dcae5c5", "tree": "8296585400efa0ba767a65e19d28026ad0f29352", "parents": [ "b6ac281270ac751175c5298ce78dd9f2cb3bd594" ], "author": { "name": "Elliott Brooks", "email": "elliottbrooks@google.com", "time": "Thu Mar 28 20:24:28 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 28 20:24:28 2024 +0000" }, "message": "Roll DevTools 2.34.1 into the Dart SDK [for cherrypick into beta]\n\nFollow up to https://dart-review.googlesource.com/c/sdk/+/360181 but with the correct DevTools version: https://github.com/flutter/devtools/pull/7490\n\nBug: https://github.com/flutter/devtools/issues/7483\nChange-Id: Ie64f72bbc473230b182f348e1f53291a1c771b34\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/360281\nReviewed-by: Ben Konyi \u003cbkonyi@google.com\u003e\nCommit-Queue: Elliott Brooks \u003celliottbrooks@google.com\u003e\nReviewed-by: Kenzie Davisson \u003ckenzieschmoll@google.com\u003e\n" }, { "commit": "b6ac281270ac751175c5298ce78dd9f2cb3bd594", "tree": "32d401101d45b62a2fcd8c9a795da71dc529319a", "parents": [ "b6137f7ceec46be7867d49bcdd4472e699874ded" ], "author": { "name": "Kallen Tu", "email": "kallentu@google.com", "time": "Thu Mar 28 20:13:29 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 28 20:13:29 2024 +0000" }, "message": "[linter] Update missing_code_block_language_in_doc_comment to avoid linting indented code blocks.\n\nAfter trying to add the lint to flutter (https://github.com/flutter/flutter/pull/145354), I noticed that we lint on indented code blocks, which we should not be doing.\n\nThis CL uses the new code block type in https://dart-review.googlesource.com/c/sdk/+/358326 to make sure we only lint on fenced code blocks.\n\nChange-Id: Ic13596dd3c95ce4ff64deeffe02da0fdb7a298e0\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359981\nReviewed-by: Samuel Rawlins \u003csrawlins@google.com\u003e\nCommit-Queue: Kallen Tu \u003ckallentu@google.com\u003e\n" }, { "commit": "b6137f7ceec46be7867d49bcdd4472e699874ded", "tree": "7a167dcfedcf450b4e22357c5a3c78c13b26f04e", "parents": [ "3b23ffe53f4b74f579c5d5deecc0194ba9bfc64d" ], "author": { "name": "Keerti Parthasarathy", "email": "keertip@google.com", "time": "Thu Mar 28 17:54:51 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 28 17:54:51 2024 +0000" }, "message": "Issue 54893: Add a test for sorting imports that span 2 lines.\n\nChange-Id: I9ed0a1b754d3f201d760813dafa4c1049b7124f1\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/360280\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nCommit-Queue: Keerti Parthasarathy \u003ckeertip@google.com\u003e\n" }, { "commit": "3b23ffe53f4b74f579c5d5deecc0194ba9bfc64d", "tree": "ddf3cafd025071ce02513b424259606f3721e218", "parents": [ "b776196f0bf2351d440f157fdead13e2edf6ee69" ], "author": { "name": "Devon Carew", "email": "devoncarew@google.com", "time": "Thu Mar 28 16:58:18 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 28 16:58:18 2024 +0000" }, "message": "[deps] rev dartdoc, http\n\nRevisions updated by `dart tools/rev_sdk_deps.dart`.\n\ndartdoc (https://github.com/dart-lang/dartdoc/compare/79c1675..bf6080c):\n bf6080c8 2024-03-27 Sam Rawlins Remove unnecessary EnclosedElement mixin (dart-lang/dartdoc#3736)\n c5bb9066 2024-03-26 Sam Rawlins Bump to 8.0.8; fix changelog wrapping (dart-lang/dartdoc#3735)\n 4e096f84 2024-03-26 Sam Rawlins Format parameters better (dart-lang/dartdoc#3731)\n\nhttp (https://github.com/dart-lang/http/compare/7949d6f..280d361):\n 280d361 2024-03-27 Derek Xu [package:http_profile] Expand README.md (dart-lang/http#1162)\n 9fddb1c 2024-03-27 Brian Quinlan Fix the connectionInfo getter (dart-lang/http#1163)\n 9f47439 2024-03-27 Derek Xu [package:http_profile] Make connectionInfo a top-level field of HttpClientRequestProfile (dart-lang/http#1160)\n\nChange-Id: Ib50584ef7d7914ab262bb01eeb087e44c34e4dc7\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/360240\nAuto-Submit: Devon Carew \u003cdevoncarew@google.com\u003e\nCommit-Queue: Konstantin Shcheglov \u003cscheglov@google.com\u003e\nReviewed-by: Konstantin Shcheglov \u003cscheglov@google.com\u003e\n" }, { "commit": "b776196f0bf2351d440f157fdead13e2edf6ee69", "tree": "dd61aecaebe2418d1ffcbb818f73d17a044de44f", "parents": [ "80d16cf9e508e766e65b07f7d8ddf4b6de561719" ], "author": { "name": "Ryan Macnak", "email": "rmacnak@google.com", "time": "Thu Mar 28 16:47:49 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 28 16:47:49 2024 +0000" }, "message": "Roll Fuchsia SDK to 19.20240327.2.1.\n\nFixes -Werror,-Wextra-qualification with newer Clang.\n\nCq-Include-Trybots: luci.dart.try:vm-fuchsia-release-arm64-try,vm-fuchsia-release-x64-try\nChange-Id: I6bf5e662fd850930d7db0cf331e99e5b1a2b30be\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/360180\nReviewed-by: Alexander Aprelev \u003caam@google.com\u003e\nCommit-Queue: Ryan Macnak \u003crmacnak@google.com\u003e\n" }, { "commit": "80d16cf9e508e766e65b07f7d8ddf4b6de561719", "tree": "6e312d1d8370a63f6ab94dd5726cd59cd29e6f28", "parents": [ "7d0a2e56ebf534c0a0b22012ea4a4871b9c70dbb" ], "author": { "name": "Sam Rawlins", "email": "srawlins@google.com", "time": "Thu Mar 28 16:27:51 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 28 16:27:51 2024 +0000" }, "message": "DAS: Inline prepareNewStatementLocation into add_call_super\n\nThis was the only caller, and it always passed in `true` for `first`.\n\nInlining the function is the same number of lines as calling the function and using it\u0027s output.\n\nChange-Id: Ifee204e68f2b7d168fe6078ac7f8ec66261ff76b\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/360080\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nCommit-Queue: Samuel Rawlins \u003csrawlins@google.com\u003e\n" }, { "commit": "7d0a2e56ebf534c0a0b22012ea4a4871b9c70dbb", "tree": "ed5337fc77a9186ae088abdd8ec882447f9d2274", "parents": [ "eb50c2683ce821c6ee49586d506f8315236a165a" ], "author": { "name": "Sam Rawlins", "email": "srawlins@google.com", "time": "Thu Mar 28 16:26:33 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 28 16:26:33 2024 +0000" }, "message": "DAS: wrap new integer division in parens\n\nWe use precedence of the parent of the previous `toInt()` invocation to\ndetermine if parentheses are necessary.\n\nThe one change to the _existing_ test may be surprising. But here\u0027s how\nit is: The code pre-fix had unnecessary parentheses, and the fix\npreviously removed them. That is not the fix\u0027s job, so we should keep\nwhatever (unrelated) parentheses were in the input.\n\nFixes https://github.com/dart-lang/sdk/issues/54606\n\nChange-Id: I045860a663c3c3a55d93038551f64e658feb56d8\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/360183\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nCommit-Queue: Samuel Rawlins \u003csrawlins@google.com\u003e\n" }, { "commit": "eb50c2683ce821c6ee49586d506f8315236a165a", "tree": "c569522125e4dc4676d80c172f9155577c9c6a31", "parents": [ "9426e47d736a96ef82f858c896676cae192eea7c" ], "author": { "name": "Daco Harkes", "email": "dacoharkes@google.com", "time": "Thu Mar 28 11:24:36 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 28 11:24:36 2024 +0000" }, "message": "[vm/ffi] Throw on attaching `NativeFinalizer` to deeply immutable object\n\nThis CL\n\n* adds a `kind` to `CheckWritableInstr`,\n* starts using `CheckWritableInstr` in JIT mode, and\n* adds support for `CheckWritableInstr` ia32.\n\nTEST\u003dtests/ffi/vmspecific_native_finalizer_deeply_immutable_test.dart\n\nCloses: https://github.com/dart-lang/sdk/issues/55067\nChange-Id: I0b397daba12cfc8b885401169889f7cd7c040166\nCq-Include-Trybots: dart-internal/g3.dart-internal.try:g3-cbuild-try\nCq-Include-Trybots: dart/try:vm-aot-android-release-arm64c-try,vm-aot-android-release-arm_x64-try,vm-aot-linux-debug-x64-try,vm-aot-linux-debug-x64c-try,vm-aot-mac-release-arm64-try,vm-aot-mac-release-x64-try,vm-aot-obfuscate-linux-release-x64-try,vm-aot-optimization-level-linux-release-x64-try,vm-aot-win-debug-arm64-try,vm-aot-win-debug-x64c-try,vm-aot-win-release-x64-try,vm-appjit-linux-debug-x64-try,vm-asan-linux-release-x64-try,vm-checked-mac-release-arm64-try,vm-eager-optimization-linux-release-ia32-try,vm-eager-optimization-linux-release-x64-try,vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64c-try,vm-ffi-qemu-linux-release-arm-try,vm-ffi-qemu-linux-release-riscv64-try,vm-linux-debug-ia32-try,vm-linux-debug-x64-try,vm-linux-debug-x64c-try,vm-mac-debug-arm64-try,vm-mac-debug-x64-try,vm-msan-linux-release-x64-try,vm-reload-linux-debug-x64-try,vm-reload-rollback-linux-debug-x64-try,vm-ubsan-linux-release-x64-try,vm-win-debug-arm64-try,vm-win-debug-x64-try,vm-win-debug-x64c-try,vm-win-release-ia32-try\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359223\nAuto-Submit: Daco Harkes \u003cdacoharkes@google.com\u003e\nReviewed-by: Ryan Macnak \u003crmacnak@google.com\u003e\nCommit-Queue: Daco Harkes \u003cdacoharkes@google.com\u003e\n" }, { "commit": "9426e47d736a96ef82f858c896676cae192eea7c", "tree": "8f72621763b1882a6140807dca73ede854c3152f", "parents": [ "702be59cfc7b2a8f9afe27184e283c2cfa3739e3" ], "author": { "name": "Daco Harkes", "email": "dacoharkes@google.com", "time": "Thu Mar 28 11:24:36 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 28 11:24:36 2024 +0000" }, "message": "[vm] Add receiver argument to `WriteError` runtime entry\n\nNote this changes the error in AOT to tell what is the typed data that\nis not writable.\n\nThis CL eases the follow up CL which starts reusing the\n`CheckWritableInstr` and accompanying slow path and runtime entry for\nother messages.\n\nTEST\u003dtests/lib/typed_data/polymorphic_unmodifiable_typed_data_test.dart\n\nBug: https://github.com/dart-lang/sdk/issues/55067\nChange-Id: Icf26d119501059e2ea4e885897539ebcb1063da0\nCq-Include-Trybots: dart-internal/g3.dart-internal.try:g3-cbuild-try\nCq-Include-Trybots: dart/try:vm-aot-android-release-arm64c-try,vm-aot-android-release-arm_x64-try,vm-aot-linux-debug-simarm_x64-try,vm-aot-linux-debug-simriscv64-try,vm-aot-linux-debug-x64-try,vm-aot-linux-debug-x64c-try,vm-aot-mac-release-arm64-try,vm-aot-mac-release-x64-try,vm-aot-obfuscate-linux-release-x64-try,vm-aot-optimization-level-linux-release-x64-try,vm-aot-win-debug-arm64-try,vm-aot-win-debug-x64c-try,vm-aot-win-release-x64-try,vm-appjit-linux-debug-x64-try,vm-asan-linux-release-x64-try,vm-checked-mac-release-arm64-try,vm-eager-optimization-linux-release-ia32-try,vm-eager-optimization-linux-release-x64-try,vm-linux-debug-ia32-try,vm-linux-debug-simriscv64-try,vm-linux-debug-x64-try,vm-linux-debug-x64c-try,vm-linux-release-simarm-try,vm-mac-debug-arm64-try,vm-mac-debug-x64-try,vm-msan-linux-release-x64-try,vm-reload-linux-debug-x64-try,vm-reload-rollback-linux-debug-x64-try,vm-ubsan-linux-release-x64-try,vm-win-debug-arm64-try,vm-win-debug-x64-try,vm-win-debug-x64c-try,vm-win-release-ia32-try\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359063\nReviewed-by: Ilya Yanok \u003cyanok@google.com\u003e\n" }, { "commit": "702be59cfc7b2a8f9afe27184e283c2cfa3739e3", "tree": "d1896da56d831b55c881af965d6192ddf4dbaf05", "parents": [ "d94c9f08d5aef128abcbfde5950a85e1e695b9ae" ], "author": { "name": "Sam Rawlins", "email": "srawlins@google.com", "time": "Thu Mar 28 02:33:49 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 28 02:33:49 2024 +0000" }, "message": "Analyzer: Fix Expression.precedence doc.\n\nSee how the backticks are broken at\nhttps://pub.dev/documentation/analyzer/latest/dart_ast_ast/Expression/precedence.html\n\nChange-Id: I1a81a5340fdc90041cb4ab39bc14bd25cfe7224b\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/360182\nAuto-Submit: Samuel Rawlins \u003csrawlins@google.com\u003e\nReviewed-by: Konstantin Shcheglov \u003cscheglov@google.com\u003e\nCommit-Queue: Konstantin Shcheglov \u003cscheglov@google.com\u003e\n" }, { "commit": "d94c9f08d5aef128abcbfde5950a85e1e695b9ae", "tree": "b38756741eea74718f1adfe62df985c512874ba2", "parents": [ "3cce981e6c8effa75f906ef76a4e4d269d3d2bc7" ], "author": { "name": "Elliott Brooks", "email": "elliottbrooks@google.com", "time": "Thu Mar 28 00:29:16 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 28 00:29:16 2024 +0000" }, "message": "Roll DevTools 2.34.1 into the Dart SDK\n\nFollow up to https://dart-review.googlesource.com/c/sdk/+/360181 with one more patch: https://github.com/flutter/devtools/pull/7485\n\nBug: https://github.com/flutter/devtools/issues/7483\nChange-Id: Ia2a93c783827d7e894ac139ecba9850edc8dff20\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/360123\nReviewed-by: Kenzie Davisson \u003ckenzieschmoll@google.com\u003e\nReviewed-by: Jacob Richman \u003cjacobr@google.com\u003e\nCommit-Queue: Elliott Brooks \u003celliottbrooks@google.com\u003e\n" }, { "commit": "3cce981e6c8effa75f906ef76a4e4d269d3d2bc7", "tree": "4861c372be2b12cc3016ccbc784b3ebb77b91dd0", "parents": [ "f84d26ac91d3457932f754e8ec8ba945158b2a83" ], "author": { "name": "Jonas Termansen", "email": "sortie@google.com", "time": "Thu Mar 28 00:08:58 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 28 00:08:58 2024 +0000" }, "message": "Bump version to 3.5.\n\nChange-Id: Iaba0d7367689c60a8c899b49311dbd64d5736be1\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/345306\nReviewed-by: Kevin Chisholm \u003ckevinjchisholm@google.com\u003e\nCommit-Queue: Kevin Chisholm \u003ckevinjchisholm@google.com\u003e\n" }, { "commit": "f84d26ac91d3457932f754e8ec8ba945158b2a83", "tree": "a756545a013713283234f12055a4157fd0c0c8cc", "parents": [ "228ef6c589a79b8a941bb753bb7e87e633e1a8af" ], "author": { "name": "Kenzie Schmoll", "email": "kenzieschmoll@google.com", "time": "Wed Mar 27 23:25:49 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Mar 27 23:25:49 2024 +0000" }, "message": "Roll DevTools 2.34.1 into the Dart SDK\n\nBug: https://github.com/flutter/devtools/issues/7483\nChange-Id: Ic99de79454c0425bc31672d505b2015a6c4aafb4\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/360181\nReviewed-by: Ben Konyi \u003cbkonyi@google.com\u003e\nCommit-Queue: Kenzie Davisson \u003ckenzieschmoll@google.com\u003e\n" }, { "commit": "228ef6c589a79b8a941bb753bb7e87e633e1a8af", "tree": "d6e905450c00eb01e3f49a23c1dfe907ac79e6a6", "parents": [ "0c9f4054d885673ca8ccee282f4ae4341b596d60" ], "author": { "name": "Konstantin Shcheglov", "email": "scheglov@google.com", "time": "Wed Mar 27 23:05:39 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Mar 27 23:05:39 2024 +0000" }, "message": "Completion. Issue 55251. Suggestion variable name for DeclaredVariablePattern.\n\nBug: https://github.com/dart-lang/sdk/issues/55251\nChange-Id: I57df0c13b205ab6018f7f416bd1181d45c2991ad\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/360200\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nCommit-Queue: Konstantin Shcheglov \u003cscheglov@google.com\u003e\n" }, { "commit": "0c9f4054d885673ca8ccee282f4ae4341b596d60", "tree": "b9bc5d68e6f0740dfecdd8b421a65d02921e199e", "parents": [ "41612e437559b3b626397f0f82d4c3c275a54541" ], "author": { "name": "Danny Tuppeny", "email": "danny@tuppeny.com", "time": "Wed Mar 27 23:03:00 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Mar 27 23:03:00 2024 +0000" }, "message": "[analysis_server] Send Flutter Outline notifications for Flutter framework files\n\nThis fixes the check to determine whether a file is Flutter to handle things in Flutter itself.\n\nIt also improves the optimization for not setting overlays when they\u0027re the same as on-disk to handle files from dependencies (not only those that are explicitly analyzed) which might help avoid https://github.com/dart-lang/sdk/issues/48051#issuecomment-1686202738 more (it was the original intention, but perhaps wasn\u0027t working as well as I\u0027d believed).\n\nFixes https://github.com/Dart-Code/Dart-Code/issues/5045\n\nChange-Id: Ibd04ebeb10e9a1e749f2b44d4053f9b467554f4f\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/360042\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nReviewed-by: Konstantin Shcheglov \u003cscheglov@google.com\u003e\nCommit-Queue: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\n" }, { "commit": "41612e437559b3b626397f0f82d4c3c275a54541", "tree": "b6bc7e69ed571d6b357000517f95b0ec54421344", "parents": [ "16589e650e88e8f8b42e2de827d630b571a8491a" ], "author": { "name": "Danny Tuppeny", "email": "danny@tuppeny.com", "time": "Wed Mar 27 21:20:06 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Mar 27 21:20:06 2024 +0000" }, "message": "[analysis_server] Ensure server notifications are sent for newly-opened files whose contents are unmodified\n\nSome time ago I implemented an optimisation to skip analysis when a file is opened in the LSP server if the contents exactly matched what was last analyzed from disk (since it would just produce the same results).\n\nSome notifications (like Outline) are only sent for open files and are triggered by analysis results. Skipping analysis means that some notifications would not be sent when you first open a file (because no new analysis result was computed).\n\nThis became quite noticable with the new CodeLenses because there are other CodeLenses (built into the Dart-Code extension) that were relying on Outline notifications and would \"time out\" after 5s, and this had the effect of causing the new CodeLenses to not appear for 5s (because VS Code waits for all CodeLenses). This wasn\u0027t obvious before because of the caching VS Code does for CodeLens locations.\n\nFixes https://github.com/Dart-Code/Dart-Code/issues/5048\n\nChange-Id: I5653c01fe7b224ba693f5b95a8af8e3c3d3da06d\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/360041\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nReviewed-by: Konstantin Shcheglov \u003cscheglov@google.com\u003e\nCommit-Queue: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\n" }, { "commit": "16589e650e88e8f8b42e2de827d630b571a8491a", "tree": "a8e3482ef2954522e5f793017ebbf955a10bb290", "parents": [ "86f6a0ab629e7ed1ed3fb3743a3b4c9f8479d259" ], "author": { "name": "Polina Cherkasova", "email": "polina.c@live.com", "time": "Wed Mar 27 20:51:21 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Mar 27 20:51:21 2024 +0000" }, "message": "Update DevTools rev to 9e510709212a714eaf985141629fef04a1180356\n\nChange-Id: Ib85e8c4c39bc723f550fc303a6dec208213b54a5\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/360160\nReviewed-by: Kenzie Davisson \u003ckenzieschmoll@google.com\u003e\nReviewed-by: Ben Konyi \u003cbkonyi@google.com\u003e\nCommit-Queue: Polina Cherkasova \u003cpolinach@google.com\u003e\n" }, { "commit": "86f6a0ab629e7ed1ed3fb3743a3b4c9f8479d259", "tree": "e37540a7a89e4837035014b3ae6780552fc3d356", "parents": [ "128896936ea483374c101868d7d2b6df71261444" ], "author": { "name": "Devon Carew", "email": "devoncarew@google.com", "time": "Wed Mar 27 20:31:35 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Mar 27 20:31:35 2024 +0000" }, "message": "[api docs] update the layout of the page footer for api.dart.dev\n\nChange-Id: I198cdafc4c18206367898032e7df7971e09f3b6c\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/360060\nReviewed-by: Nate Bosch \u003cnbosch@google.com\u003e\nCommit-Queue: Devon Carew \u003cdevoncarew@google.com\u003e\n" }, { "commit": "128896936ea483374c101868d7d2b6df71261444", "tree": "8ca30a85eed0a0f6ce5ff6f8c052288b34fe0d30", "parents": [ "e78c8e873b9b51d1d03aaf50a3fd9684c6db58f3" ], "author": { "name": "Ryan Macnak", "email": "rmacnak@google.com", "time": "Wed Mar 27 19:33:19 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Mar 27 19:33:19 2024 +0000" }, "message": "[vm, compiler] Fix type deduction for AddWithWrapAround on Mac.\n\nTEST\u003dhttps://ci.chromium.org/ui/p/fuchsia/builders/luci.fuchsia.toolchain.ci/dart-x64-mac\nChange-Id: Id29e54dde9f392d353c521f07b34f36da0b000e8\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/360120\nReviewed-by: Alexander Aprelev \u003caam@google.com\u003e\nCommit-Queue: Ryan Macnak \u003crmacnak@google.com\u003e\n" }, { "commit": "e78c8e873b9b51d1d03aaf50a3fd9684c6db58f3", "tree": "1f913f6ebdb4afc7f34fdd610089b8af911cc527", "parents": [ "031a855539aadc36ccb5ce19ee9de2b15681eb4b" ], "author": { "name": "Tess Strickland", "email": "sstrickl@google.com", "time": "Wed Mar 27 19:04:32 2024 +0000" }, "committer": { "name": "Tess Strickland", "email": "sstrickl@google.com", "time": "Wed Mar 27 19:04:32 2024 +0000" }, "message": "[vm] Remove unnecessary unsafe untagged pointer loads.\n\nI missed these when reviewing 0bcb0c934.\n\nTEST\u003dci\n\nChange-Id: I0bd4985158d780872983e0eb043211bf9f22c723\nCq-Include-Trybots: dart-internal/g3.dart-internal.try:g3-cbuild-try\nCq-Include-Trybots: dart/try:vm-aot-android-release-arm64c-try,vm-aot-android-release-arm_x64-try,vm-aot-linux-debug-x64-try,vm-aot-linux-debug-x64c-try,vm-aot-mac-release-arm64-try,vm-aot-mac-release-x64-try,vm-aot-obfuscate-linux-release-x64-try,vm-aot-optimization-level-linux-release-x64-try,vm-aot-win-debug-arm64-try,vm-aot-win-debug-x64-try,vm-aot-win-debug-x64c-try,vm-appjit-linux-debug-x64-try,vm-asan-linux-release-x64-try,vm-checked-mac-release-arm64-try,vm-eager-optimization-linux-release-ia32-try,vm-eager-optimization-linux-release-x64-try,vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64c-try,vm-ffi-qemu-linux-release-arm-try,vm-ffi-qemu-linux-release-riscv64-try,vm-fuchsia-release-x64-try,vm-linux-debug-ia32-try,vm-linux-debug-x64-try,vm-linux-debug-x64c-try,vm-mac-debug-arm64-try,vm-mac-debug-x64-try,vm-msan-linux-release-x64-try,vm-reload-linux-debug-x64-try,vm-reload-rollback-linux-debug-x64-try,vm-ubsan-linux-release-x64-try,vm-win-debug-arm64-try,vm-win-debug-x64c-try,vm-win-release-ia32-try\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/360100\nAuto-Submit: Tess Strickland \u003csstrickl@google.com\u003e\nReviewed-by: Daco Harkes \u003cdacoharkes@google.com\u003e\n" }, { "commit": "031a855539aadc36ccb5ce19ee9de2b15681eb4b", "tree": "581fd3ab29a9a327aef452f3fa348f2554a3dd3f", "parents": [ "75fc67b3f3322c5b4a199b5526c8b9a6a5877d06" ], "author": { "name": "Konstantin Shcheglov", "email": "scheglov@google.com", "time": "Wed Mar 27 17:45:49 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Mar 27 17:45:49 2024 +0000" }, "message": "Augment. Parse \u0027augment\u0027 for extension declaration.\n\nChange-Id: I5670e75c9d99be894d571bf9dc4d0d67df41ef82\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359901\nCommit-Queue: Konstantin Shcheglov \u003cscheglov@google.com\u003e\nReviewed-by: Chloe Stefantsova \u003ccstefantsova@google.com\u003e\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\n" }, { "commit": "75fc67b3f3322c5b4a199b5526c8b9a6a5877d06", "tree": "2432222eab81a5b3413e68181ab03fcb94cf2ccd", "parents": [ "e9df8dceab89790ddc55c8d0ed388fcfe8fe879f" ], "author": { "name": "David Morgan", "email": "davidmorgan@google.com", "time": "Wed Mar 27 15:45:41 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Mar 27 15:45:41 2024 +0000" }, "message": "[macros] Increase timeout for test flakiness.\n\nR\u003dnshahan@google.com\n\nBug: https://github.com/dart-lang/sdk/issues/54404\nChange-Id: Iba97bd0bcf6a20d60c1f0ca9cf332bb338f25eaa\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/360000\nAuto-Submit: Morgan :) \u003cdavidmorgan@google.com\u003e\nReviewed-by: Nicholas Shahan \u003cnshahan@google.com\u003e\nCommit-Queue: Morgan :) \u003cdavidmorgan@google.com\u003e\n" }, { "commit": "e9df8dceab89790ddc55c8d0ed388fcfe8fe879f", "tree": "39a0698c53162d611db101335de3d6fc0fe3a206", "parents": [ "3bf33b667c447d16dc90a38d8ea73517d7267ce2" ], "author": { "name": "Oleh Prypin", "email": "oprypin@google.com", "time": "Wed Mar 27 13:01:49 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Mar 27 13:01:49 2024 +0000" }, "message": "Revert \"[tool] `tools/find_builders.dart` cbuild opt in\"\n\nThis reverts commit 86c41c9c7740f3123d600d26848a48e2ba5f65d8.\n\nReason for revert: This builder is now included by default\n\nOriginal change\u0027s description:\n\u003e [tool] `tools/find_builders.dart` cbuild opt in\n\u003e\n\u003e Opt in to CBuild being green.\n\u003e\n\u003e Remove denylisted bots now that issue is resolved.\n\u003e\n\u003e Change-Id: I89c23720eaed78b317067bbdb065fe0cef8ecd75\n\u003e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/356022\n\u003e Commit-Queue: Daco Harkes \u003cdacoharkes@google.com\u003e\n\u003e Reviewed-by: William Hesse \u003cwhesse@google.com\u003e\n\nChange-Id: Ife49afc47f576901d2b8bb5523d2c8ed5224a761\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359862\nAuto-Submit: Oleh Prypin \u003coprypin@google.com\u003e\nCommit-Queue: Jonas Termansen \u003csortie@google.com\u003e\nReviewed-by: Daco Harkes \u003cdacoharkes@google.com\u003e\nReviewed-by: Jonas Termansen \u003csortie@google.com\u003e\n" }, { "commit": "3bf33b667c447d16dc90a38d8ea73517d7267ce2", "tree": "e9dabd6f815db737c512ceb13f27093cbc9ab1a5", "parents": [ "dbcf24cedbe4d3a8eccaa51712f0c98b92173ad2" ], "author": { "name": "Konstantin Shcheglov", "email": "scheglov@google.com", "time": "Wed Mar 27 00:22:59 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Mar 27 00:22:59 2024 +0000" }, "message": "Augment. Issue 55295. Report AUGMENTATION_WITHOUT_DECLARATION.\n\nBug: https://github.com/dart-lang/sdk/issues/55295\nChange-Id: I50811e1ccd7a2be0e71b18eefa9ecb76ac1aef73\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359961\nCommit-Queue: Konstantin Shcheglov \u003cscheglov@google.com\u003e\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\n" }, { "commit": "dbcf24cedbe4d3a8eccaa51712f0c98b92173ad2", "tree": "c7c6a7ea66285e3b86208fe1566e90aad3750ac9", "parents": [ "0608127cbc7adb82134040b67e66ffeef97f83d2" ], "author": { "name": "Ryan Macnak", "email": "rmacnak@google.com", "time": "Tue Mar 26 22:56:03 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Mar 26 22:56:03 2024 +0000" }, "message": "Roll Clang to b1d2e8510b58893e58558ffdf3f8ba29c1e25e5a.\n\nBug: https://github.com/dart-lang/sdk/issues/55303\nChange-Id: Ida31e3487836e1797b968dd46b07bdd580f6401a\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359541\nReviewed-by: Alexander Aprelev \u003caam@google.com\u003e\nCommit-Queue: Ryan Macnak \u003crmacnak@google.com\u003e\n" }, { "commit": "0608127cbc7adb82134040b67e66ffeef97f83d2", "tree": "678fcb85aeec9f3b678cf9ada17dc8dc703179dd", "parents": [ "8da86ee19e98d395f48bd9b88c2050c8637d0106" ], "author": { "name": "Konstantin Shcheglov", "email": "scheglov@google.com", "time": "Tue Mar 26 21:39:36 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Mar 26 21:39:36 2024 +0000" }, "message": "Macros. Don\u0027t print package:_macros files.\n\nChange-Id: I8057baeb73d210308f2d51f46f21eb8f588e76e1\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359960\nCommit-Queue: Konstantin Shcheglov \u003cscheglov@google.com\u003e\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\n" }, { "commit": "8da86ee19e98d395f48bd9b88c2050c8637d0106", "tree": "89e4daea42634d9edeb5f68f23abc9d4d8635bc5", "parents": [ "631939e109a4bede2b90779c8e295dfa3d4ab26a" ], "author": { "name": "Ryan Macnak", "email": "rmacnak@google.com", "time": "Tue Mar 26 19:55:45 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Mar 26 19:55:45 2024 +0000" }, "message": "Roll zlib to 24c07df5033183efad8607cba62e746bea7180bf.\n\nNote that Chromium\u0027s copy of zlib now has a dependency on the cpu_features library.\n\nChange-Id: I0f2c306aa7eb0e1deb8fa4c45e4a04f1fee8bb83\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359600\nReviewed-by: Siva Annamalai \u003casiva@google.com\u003e\nCommit-Queue: Ryan Macnak \u003crmacnak@google.com\u003e\n" }, { "commit": "631939e109a4bede2b90779c8e295dfa3d4ab26a", "tree": "96f2713a8602537816dd6aa36000584207f246f7", "parents": [ "571ec4e2bdebdd8645a4b08135309af1d660188c" ], "author": { "name": "Jake Macdonald", "email": "jakemac@google.com", "time": "Tue Mar 26 19:51:01 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Mar 26 19:51:01 2024 +0000" }, "message": "Prep to release package:macros\n\n- update SDK dependency to ensure it supports SDK vendored packages\n- sync pubspec/changelog versions\n\nChange-Id: Ib79244bec43fc94bf12340241f6eab4001e4b21c\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359920\nCommit-Queue: Bob Nystrom \u003crnystrom@google.com\u003e\nReviewed-by: Bob Nystrom \u003crnystrom@google.com\u003e\nCommit-Queue: Jake Macdonald \u003cjakemac@google.com\u003e\nAuto-Submit: Jake Macdonald \u003cjakemac@google.com\u003e\n" }, { "commit": "571ec4e2bdebdd8645a4b08135309af1d660188c", "tree": "78f53e4f0668e2219a7541607e76a1e5e922f3f8", "parents": [ "36c0788137d55c6c77f4b9a8be12e557bc764b1c" ], "author": { "name": "Devon Carew", "email": "devoncarew@google.com", "time": "Tue Mar 26 19:47:42 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Mar 26 19:47:42 2024 +0000" }, "message": "[deps] rev crypto, csslib, dartdoc, http, markdown, web\n\nRevisions updated by `dart tools/rev_sdk_deps.dart`.\n\ncrypto (https://github.com/dart-lang/crypto/compare/f059196..69d13c9):\n 69d13c9 2024-03-21 Kevin Moore Switch sha512 to use fastpath with wasm (dart-lang/crypto#165)\n\ncsslib (https://github.com/dart-lang/csslib/compare/b58e487..4216525):\n 4216525 2024-03-21 Devon Carew prep for publishing 1.0.1 (dart-lang/csslib#197)\n\ndartdoc (https://github.com/dart-lang/dartdoc/compare/7be9e24..79c1675):\n 79c16759 2024-03-25 Parker Lougheed Migrate client code to package:web (dart-lang/dartdoc#3610)\n 0b1c7fa4 2024-03-25 dependabot[bot] Bump actions/cache from 4.0.1 to 4.0.2 (dart-lang/dartdoc#3734)\n 9fe35ec5 2024-03-20 Sam Rawlins mustachio: Separate out the context stack LUB type calculation (dart-lang/dartdoc#3730)\n\nhttp (https://github.com/dart-lang/http/compare/5dfea72..7949d6f):\n 7949d6f 2024-03-25 Brian Quinlan cupertino_http: upgrade ffigen version (dart-lang/http#1159)\n 051482a 2024-03-22 Brian Quinlan Ready cupertino_http for release with WebSocket support (dart-lang/http#1158)\n 988b4d4 2024-03-20 Brian Quinlan Prepare package:cronet_http 1.2 for release (dart-lang/http#1157)\n 69f4eff 2024-03-20 Hossein Yousefi [cronet_http] Upgrade jni to 0.7.3 (dart-lang/http#1156)\n d8b1a9e 2024-03-19 Brian Quinlan Release `package:web_socket` 0.1.0 (dart-lang/http#1155)\n cfbc191 2024-03-19 Brian Quinlan Add a WebSocket implementation to package:cupertino_http (dart-lang/http#1153)\n\nmarkdown (https://github.com/dart-lang/markdown/compare/9c6b1af..8d07abc):\n 8d07abc 2024-03-19 MJ Studio Link uri encoding, URL-escaping should be left alone inside the destination (dart-lang/markdown#598)\n\nweb (https://github.com/dart-lang/web/compare/4af904f..c522718):\n c522718 2024-03-20 Kevin Moore Update MDN documentation (dart-lang/web#213)\n f80dcab 2024-03-15 Srujan Gaddam Update pubspec description to be consistent with README (dart-lang/web#210)\n 27936c4 2024-03-15 Devon Carew Generate api docs for getters (dart-lang/web#207)\n 2f13cd5 2024-03-12 Devon Carew fix unresolved dartdoc links (dart-lang/web#200)\n 686827a 2024-03-12 Srujan Gaddam Remove reference to static interop and point to dart.dev page for JS interop (dart-lang/web#206)\n 9b7e29d 2024-03-12 Devon Carew Add a \u0027sourced from mdn docs\u0027 line to the MDN sourced dartdoc (dart-lang/web#198)\n 51e594b 2024-03-05 Srujan Gaddam Fix dictionary constructors to accept supertype members and create an empty object when there are no fields (dart-lang/web#197)\n\nChange-Id: Ic90c6f5a7e7d701746276031a8028cdfe76bc27a\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359880\nReviewed-by: Konstantin Shcheglov \u003cscheglov@google.com\u003e\nCommit-Queue: Devon Carew \u003cdevoncarew@google.com\u003e\n" }, { "commit": "36c0788137d55c6c77f4b9a8be12e557bc764b1c", "tree": "5e7506f25c005914a6d4ba5123c55d1e023cbdc1", "parents": [ "0bcb0c934ddabd8851090d553c70ec9403b6c108" ], "author": { "name": "Konstantin Shcheglov", "email": "scheglov@google.com", "time": "Tue Mar 26 18:40:00 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Mar 26 18:40:00 2024 +0000" }, "message": "add package:_macros (SDK vendored) and package:macros (pub published)\n\nadd sdk_packages.yaml file (describes SDK vendored package locations)\n\ndelete old macro code in _fe_analyzer_shared, move tests/benchmarks\n\nadds a top level `pkg` directory to the Dart SDK, which is where vendored packages live\n\nBUG: https://github.com/dart-lang/sdk/issues/54976\nChange-Id: Ib3503a27fb5644fa8a39ab5a3e5b568df330cfd6\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359040\nAuto-Submit: Jake Macdonald \u003cjakemac@google.com\u003e\nReviewed-by: Konstantin Shcheglov \u003cscheglov@google.com\u003e\nReviewed-by: Jonas Termansen \u003csortie@google.com\u003e\nReviewed-by: Johnni Winther \u003cjohnniwinther@google.com\u003e\nReviewed-by: Bob Nystrom \u003crnystrom@google.com\u003e\nCommit-Queue: Jake Macdonald \u003cjakemac@google.com\u003e\nReviewed-by: Devon Carew \u003cdevoncarew@google.com\u003e\n" }, { "commit": "0bcb0c934ddabd8851090d553c70ec9403b6c108", "tree": "4c4fc55eef348e333c11845dbee010fa9e64e9d4", "parents": [ "8df8de82b38fae8e9ae1c310fef4f8b735649fd4" ], "author": { "name": "Daco Harkes", "email": "dacoharkes@google.com", "time": "Tue Mar 26 17:14:13 2024 +0000" }, "committer": { "name": "Daco Harkes", "email": "dacoharkes@google.com", "time": "Tue Mar 26 17:14:13 2024 +0000" }, "message": "[vm/ffi] Add `_Compound` `_offsetInBytes` field\n\nThis CL changes compounds (structs, unions, and arrays) to be backed\nby a TypedDataBase and an int offset.\n\nBefore this CL, the compounds where only backed by a TypedDataBase.\nThis leads to the following issues:\n\n1. Access to nested structs required code for allocating new typed data\n views or pointers, which the optimizer then had to prevent from\n being allocated after inlining.\n2. Runtime branching on whether the TypedDataBase was a Pointer or\n TypedData increased code size and prevented inlining.\n https://github.com/dart-lang/sdk/issues/54892\n This could not be properly optimized if in AOT both typed\n data and pointer were flowing into the same compound.\n3. Constructing TypedData views required calculating the length of the\n view.\n\nAfter this CL, accessing nested compounds will lead to accesses on the\noriginal TypedDataBase with an extra offset.\n\nThis removes the polymorphism on TypedData vs Pointer, because the\nfinal int/float/Pointer accesses in nested compounds operate on\nTypedDataBase.\n\nAlso, it simplifies creating an `offsetBy` accessor, because it will\nno longer have to be polymorphic in typed data vs pointer, nor will it\nhave to calculate the length of the field.\n\nImplementation details:\n\n* The changes in the CFE and patch files are straightforward.\n* VM: Struct-by-value returns (or callback params) are initialized\n with an offsetInBytes of 0.\n* VM: Struct-by-value arguments (and callback return) need to read out\n the offsetInBytes. Before this CL we were passing in the TypedData\n as tagged value. With this CL we are passing the TypedData as tagged\n value and the offset as unboxed int, from 1 IL input to 2 IL\n inputs. (The alternative would have been to take the compound as\n a tagged value, but that would have prevented optimizations from not\n allocating the compound object in the optimizer.\n The FfiCallInstr is updated to have two definitions for the case\n where we were passing in the TypedData previously.\n The NativeReturnInstr is refactored to be able to take two inputs\n instead of 1. (Note that we don\u0027t have VariadicInstr only\n VariadicDefinition in the code base. So the instruction is _not_\n implemented as variadic, rather as having a fixed length of 2.)\n* dart2wasm does no longer support nested compounds due to the\n compound implementation only storing a pointer address.\n https://github.com/dart-lang/sdk/issues/55083\n\nIntending to land this after\nhttps://dart-review.googlesource.com/c/sdk/+/353101.\n\nTEST\u003dtest/ffi\n\nCoreLibraryReviewExempt: VM and WASM-only implementation change.\nCloses: https://github.com/dart-lang/sdk/issues/54892\nBug: https://github.com/dart-lang/sdk/issues/44589\nChange-Id: I8749e21094bf8fa2d5ff1e48b6b002c375232eb5\nCq-Include-Trybots: dart-internal/g3.dart-internal.try:g3-cbuild-try\nCq-Include-Trybots: dart/try:vm-aot-android-release-arm64c-try,vm-aot-android-release-arm_x64-try,vm-aot-linux-debug-x64-try,vm-aot-linux-debug-x64c-try,vm-aot-mac-release-arm64-try,vm-aot-mac-release-x64-try,vm-aot-obfuscate-linux-release-x64-try,vm-aot-optimization-level-linux-release-x64-try,vm-aot-win-debug-arm64-try,vm-aot-win-debug-x64-try,vm-aot-win-debug-x64c-try,vm-appjit-linux-debug-x64-try,vm-asan-linux-release-x64-try,vm-checked-mac-release-arm64-try,vm-eager-optimization-linux-release-ia32-try,vm-eager-optimization-linux-release-x64-try,vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64c-try,vm-ffi-qemu-linux-release-arm-try,vm-ffi-qemu-linux-release-riscv64-try,vm-fuchsia-release-x64-try,vm-linux-debug-ia32-try,vm-linux-debug-x64-try,vm-linux-debug-x64c-try,vm-mac-debug-arm64-try,vm-mac-debug-x64-try,vm-msan-linux-release-x64-try,vm-reload-linux-debug-x64-try,vm-reload-rollback-linux-debug-x64-try,vm-ubsan-linux-release-x64-try,vm-win-debug-arm64-try,vm-win-debug-x64-try,vm-win-debug-x64c-try,vm-win-release-ia32-try\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/354226\nReviewed-by: Tess Strickland \u003csstrickl@google.com\u003e\n" }, { "commit": "8df8de82b38fae8e9ae1c310fef4f8b735649fd4", "tree": "0cc2e7fee487ade4b58e2ff6b9298ef23d65d8df", "parents": [ "d1a949a8e59aa35161b04779a999515dd4a117d0" ], "author": { "name": "Jake Macdonald", "email": "jakemac@google.com", "time": "Tue Mar 26 16:49:16 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Mar 26 16:49:16 2024 +0000" }, "message": "Ensure that the pubspecs of both _macros and macros packages are updated whenever the lib/ dir of _macros is edited.\n\nRelated to https://dart-review.googlesource.com/c/sdk/+/359040\n\nChange-Id: Iab3cfa89e0492282c348c6a72f3032191fa4998f\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359580\nAuto-Submit: Jake Macdonald \u003cjakemac@google.com\u003e\nCommit-Queue: Jake Macdonald \u003cjakemac@google.com\u003e\nReviewed-by: Bob Nystrom \u003crnystrom@google.com\u003e\n" }, { "commit": "d1a949a8e59aa35161b04779a999515dd4a117d0", "tree": "fbe63987d497bc096a29e40079785d1851f3bb14", "parents": [ "1232260158432584a3f2cf1161a97f68324b8478" ], "author": { "name": "Srujan Gaddam", "email": "srujzs@google.com", "time": "Tue Mar 26 15:43:19 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Mar 26 15:43:19 2024 +0000" }, "message": "Add static tests for external extension members on extension types\n\nWe have tests for whether external extension members are allowed\non certain classes, but not extension types.\n\nAlso rewords the error to be more accurate.\n\nChange-Id: I61c1fa4c101971986b6c8e7cc778aca94908816a\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/358380\nReviewed-by: Sigmund Cherem \u003csigmund@google.com\u003e\nCommit-Queue: Srujan Gaddam \u003csrujzs@google.com\u003e\n" }, { "commit": "1232260158432584a3f2cf1161a97f68324b8478", "tree": "a7d60b215fe6885e0820b844deaceecbda5f496b", "parents": [ "bcf64bdfeb28d1038bf01991939f518bcadecbe0" ], "author": { "name": "Srujan Gaddam", "email": "srujzs@google.com", "time": "Tue Mar 26 15:43:19 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Mar 26 15:43:19 2024 +0000" }, "message": "[dart:js_interop] Add ExternalDartReference\n\nCloses https://github.com/dart-lang/sdk/issues/55187\n\nAdds a faster way for users to pass opaque Dart values to\nJS without the need for boxing like in JSBoxedDartObject.\nThis does mean, however, that this new type can\u0027t be a JS type,\nand therefore cannot have interop members declared on it.\nRefactors existing code to handle that distinction.\n\nCoreLibraryReviewExempt: Backend-specific library that\u0027s been reviewed by both dart2wasm and JS compiler teams.\nChange-Id: Ia86f1fe3476512fc0e5f382e05739713b687f092\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/358224\nReviewed-by: Sigmund Cherem \u003csigmund@google.com\u003e\n" }, { "commit": "bcf64bdfeb28d1038bf01991939f518bcadecbe0", "tree": "1427e9c65d02a24c050835593445b7b0075291d1", "parents": [ "d7ee76326df3f4fe0c73989c3e746c5eac9c1521" ], "author": { "name": "Sam Rawlins", "email": "srawlins@google.com", "time": "Tue Mar 26 15:38:49 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Mar 26 15:38:49 2024 +0000" }, "message": "linter: Adjust require_trailing_commas reported token, and description\n\nFixes https://github.com/dart-lang/linter/issues/4918\n\nI migrated relevant tests.\n\nDescription fixes:\n\n* Don\u0027t use \"function calls\" or \"declarations\". First, I don\u0027t think\n we use the term \"function call\" much, I could be wrong. Second, it\u0027s\n not about function calls or declarations. It\u0027s about parameter lists\n and argument lists.\n* Remove more mixing up of parameters and arguments. E.g. A \"final\n parameter\" cannot be a list literal.\n* Fix naming of \"literal array\" to \"list literal\" and a few others.\n\nChange-Id: I15844f4a34dc4fe08f15dc00bce2592ec12ce5c7\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359841\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nCommit-Queue: Samuel Rawlins \u003csrawlins@google.com\u003e\n" }, { "commit": "d7ee76326df3f4fe0c73989c3e746c5eac9c1521", "tree": "7ab9ec2db17319725bf42fe1e9f2cb8db7228e0a", "parents": [ "3545100e32677deec96c466c70e33d6bc646f595" ], "author": { "name": "Jonas Termansen", "email": "sortie@google.com", "time": "Tue Mar 26 15:29:23 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Mar 26 15:29:23 2024 +0000" }, "message": "Clarify risk and multiple channel CLs in cherry-pick request template.\n\nClarify the same CP request can be used for both beta and stable and\nmake more room for doing so, as well as including a whole list of\nchangelists to be cherry-picked for complicated cases. Clarify distinct\ngerrit CLs are needed for beta and stable.\n\nReplace the informationless risk field that everyone says is low with a\nmandatory question to explain the actual risk involved.\n\nFixes: b/329611671\nChange-Id: Ibfb81d89722c237e4b8a531bcac2d475798369b7\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/357603\nCommit-Queue: Jonas Termansen \u003csortie@google.com\u003e\nReviewed-by: Kevin Chisholm \u003ckevinjchisholm@google.com\u003e\n" }, { "commit": "3545100e32677deec96c466c70e33d6bc646f595", "tree": "59c31c1f16b47a41dfab665b266637d85dbaec8d", "parents": [ "28258e54fd6aa0735352a11e16db9d740705e525" ], "author": { "name": "Alexander Markov", "email": "alexmarkov@google.com", "time": "Tue Mar 26 14:38:51 2024 +0000" }, "committer": { "name": "Alexander Markov", "email": "alexmarkov@google.com", "time": "Tue Mar 26 14:38:51 2024 +0000" }, "message": "[vm] Fix build\n\nFix the build failure after revert landed on top of\nReturnInstr -\u003e DartReturnInstr rename.\n\nTEST\u003dlocal build\n\nChange-Id: Ic0c7208485b9b3d1e6525cb8f31e3113765fd317\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359843\nCommit-Queue: Siva Annamalai \u003casiva@google.com\u003e\nReviewed-by: Siva Annamalai \u003casiva@google.com\u003e\nAuto-Submit: Alexander Markov \u003calexmarkov@google.com\u003e\nCommit-Queue: Alexander Markov \u003calexmarkov@google.com\u003e\n" }, { "commit": "28258e54fd6aa0735352a11e16db9d740705e525", "tree": "38be7460f6f24826e4accfb5b89af1b251e87e86", "parents": [ "77d10f2ed9a14d4c570c5bf26c632806d6471964" ], "author": { "name": "Alexander Markov", "email": "alexmarkov@google.com", "time": "Tue Mar 26 14:25:38 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Mar 26 14:25:38 2024 +0000" }, "message": "Revert \"[vm/compiler] Move handling of recognized methods from inliner to call specializer\"\n\nThis reverts commit eebc219bab77a0163d5a3b4e40b835290f6874de.\n\nReason for revert: performance regressions\n\nOriginal change\u0027s description:\n\u003e [vm/compiler] Move handling of recognized methods from inliner to call specializer\n\u003e\n\u003e This refactoring reduces number of places where recognized methods are\n\u003e handled and cleans up general-purpose inliner pass.\n\u003e\n\u003e The code is mostly moved as is to simplify reviewing, with a notable\n\u003e exception: in a few places handling of recognized method calls is\n\u003e removed as it duplicates handling performed during call specialization\n\u003e passes (ApplyClassIds and ApplyICData) which run both before and after\n\u003e inlining.\n\u003e\n\u003e TEST\u003dci\n\u003e\n\u003e Change-Id: I8d53d23587beb09e6edf64ee95524f6ad3e060de\n\u003e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/358221\n\u003e Reviewed-by: Slava Egorov \u003cvegorov@google.com\u003e\n\u003e Commit-Queue: Alexander Markov \u003calexmarkov@google.com\u003e\n\nChange-Id: I9576bc4b385b5d0e0b728556defedb4962ec0a8a\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359842\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nAuto-Submit: Alexander Markov \u003calexmarkov@google.com\u003e\nReviewed-by: Siva Annamalai \u003casiva@google.com\u003e\nCommit-Queue: Siva Annamalai \u003casiva@google.com\u003e\n" }, { "commit": "77d10f2ed9a14d4c570c5bf26c632806d6471964", "tree": "4e952a385f84080a0c8748e534c6ad1f48f986ee", "parents": [ "05936f4d0b0af933c6becced32c8efa6997b0f71" ], "author": { "name": "Daco Harkes", "email": "dacoharkes@google.com", "time": "Tue Mar 26 11:12:38 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Mar 26 11:12:38 2024 +0000" }, "message": "[vm] Split `DartReturnInstr` and `NativeReturnInstr`\n\nRenames `ReturnInstr` to `DartReturnInstr`, and introduces a new\n`ReturnBaseInstr` to be the common parent of `DartReturnInstr` and\n`NativeReturnInstr`. (Before this CL, `NativeReturnInstr` was a\nsubtype of `ReturnInstr`.)\n\nIn a follow up CL, the `NativeReturnInstr` will get up to two inputs.\nhttps://dart-review.googlesource.com/c/sdk/+/354226\nTherefore, the `ReturnBaseInstr` does not inherit from `TemplateInstr`\nwith 1 input, but instead only inherits from `Instruction`.\n\nTEST\u003dSDK build\nTEST\u003d*_il_test.dart\n\nChange-Id: I017eb7802ae6c902b64f1cda20edf4a11408dbe1\nCq-Include-Trybots: luci.dart.try:vm-aot-linux-debug-x64-try\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/358904\nReviewed-by: Tess Strickland \u003csstrickl@google.com\u003e\nCommit-Queue: Daco Harkes \u003cdacoharkes@google.com\u003e\n" }, { "commit": "05936f4d0b0af933c6becced32c8efa6997b0f71", "tree": "5955218670882b591b03c968c0b10c9c4e762d55", "parents": [ "2b2c6ec2675359010b7641b6ef886b836755fad9" ], "author": { "name": "Jonas Termansen", "email": "sortie@google.com", "time": "Tue Mar 26 11:10:48 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Mar 26 11:10:48 2024 +0000" }, "message": "[infra] Fail hard if starting RBE fails.\n\nThe build isn\u0027t going to go through anyway and the slow 3 minute default\ntimeout is just confusing and annoying when this happens. There isn\u0027t\nany additional useful context being output like the comment suggested.\n\nBug: b/331346866\nChange-Id: I0475002469c372fefe3a54d104b54692c89ca9f5\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359800\nCommit-Queue: Jonas Termansen \u003csortie@google.com\u003e\nReviewed-by: Daco Harkes \u003cdacoharkes@google.com\u003e\n" }, { "commit": "2b2c6ec2675359010b7641b6ef886b836755fad9", "tree": "821a5719d43ac67d4f820f02f5301b736e6ee6f6", "parents": [ "93d2d44b26040fb3e0f4dc03b85e87aa008f9909" ], "author": { "name": "Daco Harkes", "email": "dacoharkes@google.com", "time": "Tue Mar 26 10:01:22 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Mar 26 10:01:22 2024 +0000" }, "message": "[wasm] Update owners\n\nMake dart2wasm self-administrated.\n\nJackson as dart2wasm contributor.\nAdd self as `dart:ffi` maintainer.\n\nChange-Id: Ie339aab443e120dfd00a94d0c4130b47984bf0db\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359060\nReviewed-by: Jonas Termansen \u003csortie@google.com\u003e\nCommit-Queue: Daco Harkes \u003cdacoharkes@google.com\u003e\n" }, { "commit": "93d2d44b26040fb3e0f4dc03b85e87aa008f9909", "tree": "bdfeff42c9a48386401ef3c8bd4d70fb84de0e92", "parents": [ "34b7df107fb3133e3c74e48f6169449928d0c494" ], "author": { "name": "Kallen Tu", "email": "kallentu@google.com", "time": "Tue Mar 26 06:57:47 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Mar 26 06:57:47 2024 +0000" }, "message": "Add code block type to MdCodeBlock.\n\nAdds a code block type to `MdCodeBlock` which will allow us to differentiate between fenced code blocks and indented code blocks with the `missing_code_block_language_in_doc_comment` lint (since only fenced code blocks care about a missing info/language string).\n\nUpdated tests and added it to the AST printer as well.\n\nChange-Id: Ibffc4edc7708fdc0394b24db8da7c282ffe92eba\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/358326\nReviewed-by: Samuel Rawlins \u003csrawlins@google.com\u003e\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nCommit-Queue: Kallen Tu \u003ckallentu@google.com\u003e\nReviewed-by: Bob Nystrom \u003crnystrom@google.com\u003e\n" }, { "commit": "34b7df107fb3133e3c74e48f6169449928d0c494", "tree": "2e0b9325d927851aba6c9ad943681303fa45cde5", "parents": [ "b3aa031eb45c4afb51844ab3e97be45e9d435d95" ], "author": { "name": "Sigmund Cherem", "email": "sigmund@google.com", "time": "Tue Mar 26 00:58:58 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Mar 26 00:58:58 2024 +0000" }, "message": "[ddc] do not fail during cleanup of expression_compiler tests.\n\nCurrently our end-2-end tests create a temporary folder and delete\nit after the suite has completed. Only one folder is created for the\nentire test run, so the deletion only gets scheduled when the entire\nsuite has completed.\n\nOn windows bots, the cleanup very often fails causing up to 40%\nflakiness on some tests.\n\nThis CL keeps the cleanup logic as is, but will now deem tests as\npassing even when we can\u0027t do the proper cleanup.\n\nChange-Id: I8e2e2d39d1bbdaf48c138c0a05a9a2540345fc28\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359760\nCommit-Queue: Sigmund Cherem \u003csigmund@google.com\u003e\nReviewed-by: Nicholas Shahan \u003cnshahan@google.com\u003e\n" }, { "commit": "b3aa031eb45c4afb51844ab3e97be45e9d435d95", "tree": "34f75aeb4de57b08eeb2b40083cd9c0bcc3bd2a7", "parents": [ "d30283f0a190d78b2cb16c5db30ef50868a53740" ], "author": { "name": "MarkZ", "email": "markzipan@google.com", "time": "Mon Mar 25 23:58:32 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Mar 25 23:58:32 2024 +0000" }, "message": "[reload_test] Adding scaffolding for additional runtime platforms.\n\nChange-Id: Id4271567c078ca04d6ee17c41fa25e69587e4f92\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/358661\nReviewed-by: Nicholas Shahan \u003cnshahan@google.com\u003e\nCommit-Queue: Mark Zhou \u003cmarkzipan@google.com\u003e\n" }, { "commit": "d30283f0a190d78b2cb16c5db30ef50868a53740", "tree": "b9f9c2b1991db440d5e30e92b11da8e846e52856", "parents": [ "8e1751f4ce6ff4fec7e564034d8c5d6f920b8f19" ], "author": { "name": "MarkZ", "email": "markzipan@google.com", "time": "Mon Mar 25 23:58:26 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Mar 25 23:58:26 2024 +0000" }, "message": "[ddc] Adding tests for pkg:reload_test and enabling reload tests in test bots.\n\n* Adds tests for the memory filesystem\n* Enables hot restart/reload tests\n* Adds flags to the hot reload suite\n* Makes path resolution logic windows-friendly\n* Adds test-reporting logic for trybots to hot reload tests\n\nChange-Id: Ic51a0b8a3c6f8b6de20b58b2ac185dacf444cf47\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/353788\nReviewed-by: Nicholas Shahan \u003cnshahan@google.com\u003e\nReviewed-by: Nate Bosch \u003cnbosch@google.com\u003e\nCommit-Queue: Mark Zhou \u003cmarkzipan@google.com\u003e\n" }, { "commit": "8e1751f4ce6ff4fec7e564034d8c5d6f920b8f19", "tree": "c5a81358fbab2ada60a88410a001b4257fda1665", "parents": [ "734621fe74272566222487b8227d9d5c960e102c" ], "author": { "name": "Danny Tuppeny", "email": "danny@tuppeny.com", "time": "Mon Mar 25 22:32:24 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Mar 25 22:32:24 2024 +0000" }, "message": "[analysis_server] Add LSP CodeLenses for \"Go to Augmented\" and \"Go to Augmentation\"\n\nThese are on by default but can be toggled in the client with the \"dart.codeLens\" setting, either by disabling entirely:\n\n```\n\"dart.codeLens\": false\n```\n\nOr individually\n\n```\n\"dart.codeLens\": {\n \"augmented\": false,\n \"augmentation\": false,\n}\n```\n\nThey require a client-provided command to handle the navigation, so this also adds a \"commands\" section to the client capabilities (in \"experimental\", because that\u0027s the extension point for non-standard LSP) that allows the client to inform the server that it handles such a command (which is documented in the readme and implemented in Dart-Code in https://github.com/Dart-Code/Dart-Code/commit/ebe029c3f9aca724d386b3da10f414f624bc705a).\n\nChange-Id: I91791c9f4aa5957c4ab4b9c0c5bb4fcf8ebeb717\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359640\nCommit-Queue: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nReviewed-by: Konstantin Shcheglov \u003cscheglov@google.com\u003e\n" }, { "commit": "734621fe74272566222487b8227d9d5c960e102c", "tree": "48e10e285f6dc0e0773062b9d15ad1ce18cf62a1", "parents": [ "a6dff920eb0e313ccd4b30dee38ae89e5830aea7" ], "author": { "name": "Danny Tuppeny", "email": "danny@tuppeny.com", "time": "Mon Mar 25 22:17:58 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Mar 25 22:17:58 2024 +0000" }, "message": "[analysis_server] Fail LSP tests by default if the test code produces diagnostics\n\nThis will make it harder to accidentally create tests with incorrect code or forget to update them if syntax changes (such as \"library augment\" vs \"augment library\"). Tests deliberately using invalid code can set the `failTestOnErrorDiagnostic` flag to disable this behaviour.\n\nChange-Id: Ibc993fdc925f1434edc8f6ae7a8bd2a671700689\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/358701\nCommit-Queue: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nReviewed-by: Konstantin Shcheglov \u003cscheglov@google.com\u003e\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\n" }, { "commit": "a6dff920eb0e313ccd4b30dee38ae89e5830aea7", "tree": "9af549edcd573c348131f5a0977028f70afeb693", "parents": [ "97d8445e5f6395293f458761fe628588dd8ecb6a" ], "author": { "name": "Ryan Macnak", "email": "rmacnak@google.com", "time": "Mon Mar 25 22:07:13 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Mar 25 22:07:13 2024 +0000" }, "message": "[vm, compiler] Remove dead branch from ARM64 large offset generation.\n\nThis looks like it started as a copy of the MIPS code or LoadImmediate.\n\nTEST\u003dci\nBug: https://github.com/dart-lang/sdk/issues/55191\nChange-Id: I3bd78a45d6de5efbbed52d3a7d1e7cd5ca19ddb8\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359701\nReviewed-by: Alexander Aprelev \u003caam@google.com\u003e\nCommit-Queue: Ryan Macnak \u003crmacnak@google.com\u003e\n" }, { "commit": "97d8445e5f6395293f458761fe628588dd8ecb6a", "tree": "3bf482e78368880755522dcbf3d8722e1429ae85", "parents": [ "eebc219bab77a0163d5a3b4e40b835290f6874de" ], "author": { "name": "Brian Quinlan", "email": "bquinlan@google.com", "time": "Mon Mar 25 21:03:12 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Mar 25 21:03:12 2024 +0000" }, "message": "Revert \"[io] Fix a bug where Process.stdin.add exceptions could not be caught\"\n\nThis reverts commit 9967075787ba26f0a4e9082ec70d2f17070de88f.\n\nReason for revert: Ignoring `done` is asymmetrical with other IOSinks.\n\nOriginal change\u0027s description:\n\u003e [io] Fix a bug where Process.stdin.add exceptions could not be caught\n\u003e\n\u003e Change-Id: I2383a74bfa6950ab8f8934087fb68218f06dd681\n\u003e Bug:https://github.com/dart-lang/sdk/issues/48501\n\u003e Tested: Unit test\n\u003e CoreLibraryReviewExempt: dart:io only\n\u003e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/351380\n\u003e Reviewed-by: Alexander Aprelev \u003caam@google.com\u003e\n\u003e Commit-Queue: Brian Quinlan \u003cbquinlan@google.com\u003e\n\nBug: https://github.com/dart-lang/sdk/issues/48501\nChange-Id: Ib5356c640d4dddc30e561b9d60d93f794a935103\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359680\nReviewed-by: Alexander Aprelev \u003caam@google.com\u003e\nCommit-Queue: Brian Quinlan \u003cbquinlan@google.com\u003e\n" }, { "commit": "eebc219bab77a0163d5a3b4e40b835290f6874de", "tree": "384285fa34c4b72ad6a47be91509a20fcf2211a8", "parents": [ "403040c2f7cd245a69cb249e20f4e531f70d565e" ], "author": { "name": "Alexander Markov", "email": "alexmarkov@google.com", "time": "Mon Mar 25 20:58:15 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Mar 25 20:58:15 2024 +0000" }, "message": "[vm/compiler] Move handling of recognized methods from inliner to call specializer\n\nThis refactoring reduces number of places where recognized methods are\nhandled and cleans up general-purpose inliner pass.\n\nThe code is mostly moved as is to simplify reviewing, with a notable\nexception: in a few places handling of recognized method calls is\nremoved as it duplicates handling performed during call specialization\npasses (ApplyClassIds and ApplyICData) which run both before and after\ninlining.\n\nTEST\u003dci\n\nChange-Id: I8d53d23587beb09e6edf64ee95524f6ad3e060de\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/358221\nReviewed-by: Slava Egorov \u003cvegorov@google.com\u003e\nCommit-Queue: Alexander Markov \u003calexmarkov@google.com\u003e\n" }, { "commit": "403040c2f7cd245a69cb249e20f4e531f70d565e", "tree": "af643c9d1f07b523fa136d0d00fca82ac79525f7", "parents": [ "b771c6f45dc4563b29c26a18ce08034bf1a25b69" ], "author": { "name": "Danny Tuppeny", "email": "danny@tuppeny.com", "time": "Mon Mar 25 20:55:06 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Mar 25 20:55:06 2024 +0000" }, "message": "[analysis_server] Fix many LSP tests that produce diagnostics\n\nI\u0027m working towards having LSP tests fail by default if error diagnostics are produced. This updates a bunch of tests that currently do, but are not required to.\n\nIn many cases these are minor bugs in the test code and non-null variables without values. Some are where we create multiple files after the server is started (which is not atomic) which are generally updated to just create the files before starting up the server instead (as long as the test was not specifically testing open files).\n\nChange-Id: Ia3adfd413d22b2d3d04d6aba9453b919e0aa46dc\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359224\nCommit-Queue: Oleh Prypin \u003coprypin@google.com\u003e\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nReviewed-by: Konstantin Shcheglov \u003cscheglov@google.com\u003e\n" }, { "commit": "b771c6f45dc4563b29c26a18ce08034bf1a25b69", "tree": "74adb2def9ce5b61a0cbcd7de1ddde77a73be021", "parents": [ "cfe32173781833a6a7c6521a6fcaa9b95bf126fc" ], "author": { "name": "Alexander Markov", "email": "alexmarkov@google.com", "time": "Mon Mar 25 20:06:40 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Mar 25 20:06:40 2024 +0000" }, "message": "[vm/corelib] Remove intermediate _getIndexed/_setIndexed methods from typed data\n\nThis change aligns all typed data implementations with Int8 typed data\nand allows compiler to recognized and replace typed data access\noperations earlier, before method inlining. Consequently, this increases\nchances for [] and []\u003d to be inlined. In JIT, this also prevents\nnon-inlined calls to _getIndexed/_setIndexed as [] and []\u003d are graph\nintrinsics which bypass calls to _getIndexed/_setIndexed.\n\nTEST\u003dci\n\nChange-Id: I95a85963da07fd1c04c06e0af09f76eb15f93353\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359520\nReviewed-by: Ryan Macnak \u003crmacnak@google.com\u003e\nCommit-Queue: Alexander Markov \u003calexmarkov@google.com\u003e\n" }, { "commit": "cfe32173781833a6a7c6521a6fcaa9b95bf126fc", "tree": "74cd1ce3d2db5d4dffd451b25b66d364dd549e4d", "parents": [ "6a9c709afd4120603e249f5c25b0c6b7b7e98d19" ], "author": { "name": "Kenzie Schmoll", "email": "kenzieschmoll@google.com", "time": "Mon Mar 25 19:52:21 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Mar 25 19:52:21 2024 +0000" }, "message": "Add `getProjectRoots` API to DTD\n\nBug: https://github.com/flutter/devtools/issues/7366\nChange-Id: If0631f387306312655bdcbefe961692b00a7b4dc\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359320\nCommit-Queue: Kenzie Davisson \u003ckenzieschmoll@google.com\u003e\nReviewed-by: Dan Chevalier \u003cdanchevalier@google.com\u003e\nReviewed-by: Polina Cherkasova \u003cpolinach@google.com\u003e\nReviewed-by: Ben Konyi \u003cbkonyi@google.com\u003e\n" }, { "commit": "6a9c709afd4120603e249f5c25b0c6b7b7e98d19", "tree": "90820d21488b2c47ee2a0afed358006da99f0ceb", "parents": [ "19decc42702e071674d3cc09fd11a729dec4c095" ], "author": { "name": "pq", "email": "pquitslund@google.com", "time": "Mon Mar 25 18:48:16 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Mar 25 18:48:16 2024 +0000" }, "message": "don\u0027t lint unnecessary lib names pre `unnamedLibraries`\n\nRelated to: https://github.com/dart-lang/lints/issues/181\n\nChange-Id: I4a247fa93c6659d5082d2cb6047aedc6a13a4209\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359321\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nCommit-Queue: Phil Quitslund \u003cpquitslund@google.com\u003e\n" }, { "commit": "19decc42702e071674d3cc09fd11a729dec4c095", "tree": "0f8ec03cfc353515c8f24002055266a673909ba0", "parents": [ "2bc1ace7fcfbd5a27f7066e2612efc9efb00a809" ], "author": { "name": "Konstantin Shcheglov", "email": "scheglov@google.com", "time": "Mon Mar 25 17:35:05 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Mar 25 17:35:05 2024 +0000" }, "message": "QAF. Updates for SplitMultipleDeclarations.\n\nUse all tokens of the declaration, otherwise static fields don\u0027t work.\nTests for fields.\nUpdates to the implementation.\n\nAfter https://dart-review.googlesource.com/c/sdk/+/359280\n\nChange-Id: Ibebe035ae664ca46b789fe80474ef041a9f8dea1\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359340\nCommit-Queue: Konstantin Shcheglov \u003cscheglov@google.com\u003e\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\n" }, { "commit": "2bc1ace7fcfbd5a27f7066e2612efc9efb00a809", "tree": "c3c7aa78838acb2d947a955e221c36c870533ae2", "parents": [ "47f08fb1431b1a2e11290e241c1bd066f5055b91" ], "author": { "name": "Alexander Aprelev", "email": "aam@google.com", "time": "Mon Mar 25 17:33:01 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Mar 25 17:33:01 2024 +0000" }, "message": "[vm/compiler] Let SIMD values become constants.\n\nReland of https://github.com/dart-lang/sdk/commit/bdacbb8decbab527a43ff1fbe289c8e55b0f6ba6\n\nPatchset 2 has fixes for tests failing in the reland.\n\nTEST\u003dci\n\nChange-Id: I1053ef653d4112d3998070cc4fc098d19d8ff264\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/357440\nReviewed-by: Ryan Macnak \u003crmacnak@google.com\u003e\nCommit-Queue: Alexander Aprelev \u003caam@google.com\u003e\n" }, { "commit": "47f08fb1431b1a2e11290e241c1bd066f5055b91", "tree": "2a72878d6b0136eff72c67c4a50878e497e6dcd6", "parents": [ "7c51a86267c57f3d5ccfff5a6459a16fb57c8ceb" ], "author": { "name": "Srujan Gaddam", "email": "srujzs@google.com", "time": "Mon Mar 25 17:05:36 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Mar 25 17:05:36 2024 +0000" }, "message": "[dart:js_interop] Change several operators back to JSBoolean\n\nRelated issues:\nhttps://github.com/dart-lang/sdk/issues/55024\nhttps://github.com/dart-lang/sdk/issues/55267\n\nThese operators were initially broken in 3.3 and were exposed\nas returning JSBoolean but implemented as returning bool. They\nwere fixed to return bool in the public API, but we should\nprefer to have them return JS types as they\u0027re likely to be used\nin cases where implicit conversions are not useful.\n\nCoreLibraryReviewExempt: Fixing type mismatch in backend-specific library.\nChange-Id: I3b0e60550dcac78918f8399d11238dcfa34982cd\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359180\nCommit-Queue: Srujan Gaddam \u003csrujzs@google.com\u003e\nReviewed-by: Sigmund Cherem \u003csigmund@google.com\u003e\n" }, { "commit": "7c51a86267c57f3d5ccfff5a6459a16fb57c8ceb", "tree": "3273b68805c6b913ac290c373e5199f9ec05637c", "parents": [ "63c507642f92f9c12ebb29beb91e3a6b22f89322" ], "author": { "name": "Jonas Termansen", "email": "sortie@google.com", "time": "Mon Mar 25 15:43:48 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Mar 25 15:43:48 2024 +0000" }, "message": "[infra] Remove .packages OWNERS rule.\n\nFixes: b/331161789\nChange-Id: Ib94b84ce89f7b70ab1af41e36fd2e1a44f5f4ae5\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359460\nAuto-Submit: Jonas Termansen \u003csortie@google.com\u003e\nReviewed-by: Devon Carew \u003cdevoncarew@google.com\u003e\nCommit-Queue: Devon Carew \u003cdevoncarew@google.com\u003e\n" }, { "commit": "63c507642f92f9c12ebb29beb91e3a6b22f89322", "tree": "411de238d634402762226a137f71febd201b8c47", "parents": [ "5b0bf46bd242bd8dd4d53b03fb9e834a94e52170" ], "author": { "name": "Sigurd Meldgaard", "email": "sigurdm@google.com", "time": "Mon Mar 25 15:19:58 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Mar 25 15:19:58 2024 +0000" }, "message": "Bump pub to 3f0df78417f7c112b933fbcdc1c5c87bde680cb1\n\nChanges:\n```\n\u003e git log --format\u003d\"%C(auto) %h %s\" 4a0cd04..3f0df78\n https://dart.googlesource.com/pub.git/+/3f0df784 Close the global http client after `ensurePubspecResolved` (4199)\n https://dart.googlesource.com/pub.git/+/9532f0a8 Let add and remove act upon the work pubspec (4196)\n https://dart.googlesource.com/pub.git/+/2ce3da14 Remove stray lockfiles and packageconfigs from workspace (4194)\n https://dart.googlesource.com/pub.git/+/a44e2e51 Tests of workspace error handling (4195)\n https://dart.googlesource.com/pub.git/+/2179b765 Resolve workspace root and workPackage when invoking pub from any sub-directory (4186)\n https://dart.googlesource.com/pub.git/+/7a668d12 Update repository specification with info about the \u0027pub_display_url\u0027 field (4193)\n https://dart.googlesource.com/pub.git/+/cf9ba6c5 Use local pub in binstubs when testing (4192)\n https://dart.googlesource.com/pub.git/+/0b8a261e Import package:path `as p` everywhere (4187)\n https://dart.googlesource.com/pub.git/+/2a7c0e92 Update repository specification with info about the \u0027affected[].versions\u0027 fields in advisories (4191)\n\n```\n\nDiff: https://dart.googlesource.com/pub.git/+/4a0cd0403f70382feca9e17ae8854ffbef0fee98..3f0df78417f7c112b933fbcdc1c5c87bde680cb1/\nBug: https://github.com/dart-lang/sdk/issues/55289\nChange-Id: Ifc2e6280cfbb83b463dd197b463d6841f0528e3e\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359480\nReviewed-by: Jonas Jensen \u003cjonasfj@google.com\u003e\nCommit-Queue: Sigurd Meldgaard \u003csigurdm@google.com\u003e\n" }, { "commit": "5b0bf46bd242bd8dd4d53b03fb9e834a94e52170", "tree": "ba1f0600f3c777b3da8b8fdaa7e531d3c1869c40", "parents": [ "2d7af14120a2b68f3c8b5867972035700de85901" ], "author": { "name": "Chloe Stefantsova", "email": "cstefantsova@google.com", "time": "Mon Mar 25 14:45:52 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Mar 25 14:45:52 2024 +0000" }, "message": "[cfe] Implement sufficiency checks for the rest of type shapes\n\nPart of https://github.com/dart-lang/sdk/issues/54998\n\nChange-Id: Ib33391d56208e66dba0396da712ca05d21faece0\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/358453\nCommit-Queue: Chloe Stefantsova \u003ccstefantsova@google.com\u003e\nReviewed-by: Johnni Winther \u003cjohnniwinther@google.com\u003e\n" }, { "commit": "2d7af14120a2b68f3c8b5867972035700de85901", "tree": "6d54400114cf0253688eadbd0b2d883f92d2d1a5", "parents": [ "54cd6845492b8a58afb5eaa878e1e3abbdc70066" ], "author": { "name": "David Morgan", "email": "davidmorgan@google.com", "time": "Mon Mar 25 11:06:17 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Mar 25 11:06:17 2024 +0000" }, "message": "[macros] Find platform from resolvedExecutable then from target dill.\n\n`resolvedExecutable` is always running on the host, so this makes much\nmore sense than starting from the target which may be a different\nplatform. Still try from the target dill if that doesn\u0027t work: if the\nrunning tool is a third party tool using the CFE as a library then\nthat might be the best we have to go on.\n\nR\u003djakemac@google.com, johnniwinther@google.com\n\nChange-Id: If73dc49e8ee4eb2bc729d9713fa50ddd4ccbccf8\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359062\nReviewed-by: Chloe Stefantsova \u003ccstefantsova@google.com\u003e\nAuto-Submit: Morgan :) \u003cdavidmorgan@google.com\u003e\nCommit-Queue: Morgan :) \u003cdavidmorgan@google.com\u003e\n" }, { "commit": "54cd6845492b8a58afb5eaa878e1e3abbdc70066", "tree": "afabb3f0d2593d5b8d7c506b89e8db5b195ddee3", "parents": [ "35d86301764c239c1baf6e531eabde0b126062e8" ], "author": { "name": "Jonas Termansen", "email": "sortie@google.com", "time": "Mon Mar 25 10:35:49 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Mar 25 10:35:49 2024 +0000" }, "message": "Remove additional --no-goma options since it\u0027s the new default.\n\nBug: b/296994239\nTested: Commit queue\nChange-Id: I04f61149c1466db965866e95ffc6dccc457460d9\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359065\nReviewed-by: Alexander Thomas \u003cathom@google.com\u003e\nCommit-Queue: Jonas Termansen \u003csortie@google.com\u003e\nAuto-Submit: Jonas Termansen \u003csortie@google.com\u003e\n" }, { "commit": "35d86301764c239c1baf6e531eabde0b126062e8", "tree": "49e1d0196a4d3149bd54279cadf142e3c02e09ff", "parents": [ "c61aecda759a215824a479f0af1c2e05c9b87614" ], "author": { "name": "Alexander Markov", "email": "alexmarkov@google.com", "time": "Sun Mar 24 14:50:17 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Sun Mar 24 14:50:17 2024 +0000" }, "message": "[vm] Make String.codeUnitAt monomorphic\n\nThe new implementation of String.codeUnitAt is always inlined and\ndoesn\u0027t depend on the polymorphic inlining of recognized methods.\n\nString.codeUnitAt now has a custom body in the flow graph builder\nwhich performs non-speculative bounds check and then branches between\nOneByteString and TwoByteString. Corresponding graph intrinsic and\nnative method are removed.\n\nThis change also fixes passing of unboxed arguments to runtime\nin the slow path of GenericCheckBound instruction in JIT mode\n(when shared stubs are not used).\n\nTEST\u003dci\n\nChange-Id: Iab2805fc752df84c37089165f828e31aca5f043f\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359000\nReviewed-by: Slava Egorov \u003cvegorov@google.com\u003e\nCommit-Queue: Alexander Markov \u003calexmarkov@google.com\u003e\n" }, { "commit": "c61aecda759a215824a479f0af1c2e05c9b87614", "tree": "c179787d79fe64ffd7e4d3ed683665abfde2ee4f", "parents": [ "5acb2132f8a01807afaecce478cc6d56f4fd682e" ], "author": { "name": "Konstantin Shcheglov", "email": "scheglov@google.com", "time": "Sat Mar 23 17:01:30 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Sat Mar 23 17:01:30 2024 +0000" }, "message": "Completion. Issue 55167. Suggest type names for DeclaredVariablePattern, in SwitchPatternCase.\n\nBug: https://github.com/dart-lang/sdk/issues/55167\nChange-Id: I1f00fd0ea589786767443d97e7c74b7f482ba4be\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359243\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nCommit-Queue: Konstantin Shcheglov \u003cscheglov@google.com\u003e\n" }, { "commit": "5acb2132f8a01807afaecce478cc6d56f4fd682e", "tree": "8ad019e920f6dd7d40593dffb52030188bcbe2fd", "parents": [ "6bc1b01241658844a2293b50eb5ee142027a3c9f" ], "author": { "name": "Lasse R.H. Nielsen", "email": "lrn@google.com", "time": "Sat Mar 23 11:18:46 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Sat Mar 23 11:18:46 2024 +0000" }, "message": "Constant evaluator won\u0027t assume all `dart.library.x` entries exist.\n\nThe existing implementation assumed, hardcoded, that the compilation\nenvironment had an entry for any string of the form `dart.library.`+X,\nwith a value of either `\"true\"` or `\"\"`.\nThis did not match the runtime behavior of the standalone VM,\nwhich allows non-constant access to the compilation environment.\n\nChanged to only have entries with value `\"true\"` for libraries\nwhich exist.\nThis changes the value of `bool.hasEnvironment` or a\n`String.fromEnvironment` or `bool.fromEnvironment` with a\nnon-default `defaultValue`.\nThe existing behavior was that `bool.hasEnvironment` was always true,\nand that the other constructors ignored the `defaultValue`,\nso most likely such tests or `defaultValues` aren\u0027t used anyway.\n\nFixes #53815\n\nBug: https://dartbug.com/53815\nChange-Id: I995bb34b5ab04b39a8a588d6a59c0027a0fe855c\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/331261\nCommit-Queue: Lasse Nielsen \u003clrn@google.com\u003e\nReviewed-by: Johnni Winther \u003cjohnniwinther@google.com\u003e\n" }, { "commit": "6bc1b01241658844a2293b50eb5ee142027a3c9f", "tree": "ecc1da8eac65b19266dd947166d9e9b6a402d562", "parents": [ "19665111e5bb11cc54889d1caf06162e561943b1" ], "author": { "name": "Nate Biggs", "email": "natebiggs@google.com", "time": "Sat Mar 23 03:58:52 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Sat Mar 23 03:58:52 2024 +0000" }, "message": "[dart2js] Eagerly serialize generated impacts so that they can be GCed immediately.\n\nWhen dump info data is being serialized as part of the codegen + emitter joint phase, all the impacts are considered \"generated\" and so they must all be serialized with the dump info data. If we wait to serialize them until the end of the phase as we usually do, these impacts cannot be GCed right away. This leads to a much higher memory footprint. By serializing them eagerly we can GC the object and just maintain the much leaner serialized data.\n\nChange-Id: I11606f7291fe8d86af1f72724bd8c68e9666a00a\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359300\nReviewed-by: Sigmund Cherem \u003csigmund@google.com\u003e\nCommit-Queue: Nate Biggs \u003cnatebiggs@google.com\u003e\n" }, { "commit": "19665111e5bb11cc54889d1caf06162e561943b1", "tree": "7d8c0a4c1b596b20b9d1d975add6c02d390a2c13", "parents": [ "a19c07ffd46307485ffe7cbcca175941067e4994" ], "author": { "name": "pq", "email": "pquitslund@google.com", "time": "Fri Mar 22 23:45:30 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Mar 22 23:45:30 2024 +0000" }, "message": "remove unnecessary library names\n\nFixes generated using `dart fix --code\u003dunnecessary_library_name --apply`\n\nSee conversation in https://github.com/dart-lang/lints/issues/181\n\nChange-Id: Id2b975e4aa27348d8883f1aea22e00dd9f4fc493\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359322\nReviewed-by: Konstantin Shcheglov \u003cscheglov@google.com\u003e\nCommit-Queue: Phil Quitslund \u003cpquitslund@google.com\u003e\n" }, { "commit": "a19c07ffd46307485ffe7cbcca175941067e4994", "tree": "800a1942a69593dcd088be034e9f049b2e596953", "parents": [ "970582ec20ab69f7382ea8a1a989f7b29d11d5cc" ], "author": { "name": "pq", "email": "pquitslund@google.com", "time": "Fri Mar 22 23:02:33 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Mar 22 23:02:33 2024 +0000" }, "message": "guard against empty entity lists\n\nUnable to repro the reported issue, but this will at least protect against the exception.\n\nFixes: https://dart-review.googlesource.com/c/sdk/+/359280\n\nChange-Id: I712f9b92879ca6b80b2f1004206e4f77a3178a47\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359280\nReviewed-by: Keerti Parthasarathy \u003ckeertip@google.com\u003e\nCommit-Queue: Phil Quitslund \u003cpquitslund@google.com\u003e\n" }, { "commit": "970582ec20ab69f7382ea8a1a989f7b29d11d5cc", "tree": "b97e1248551113f5340609cda6d93b0cc4d53a03", "parents": [ "4145eeba066848a0b50250881de98705f3df00fd" ], "author": { "name": "pq", "email": "pquitslund@google.com", "time": "Fri Mar 22 21:24:50 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Mar 22 21:24:50 2024 +0000" }, "message": "fix options map sorting\n\nFixes: https://github.com/dart-lang/sdk/issues/55252\n\nChange-Id: I2dbd0513039903ed95265d4546163f68236d88e9\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359241\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nCommit-Queue: Phil Quitslund \u003cpquitslund@google.com\u003e\n" }, { "commit": "4145eeba066848a0b50250881de98705f3df00fd", "tree": "4ed441b666d262ea039a1e4cabc85708952c97b5", "parents": [ "ef3eb6b301d14c6207af7e9f5b006fb8c9eca068" ], "author": { "name": "pq", "email": "pquitslund@google.com", "time": "Fri Mar 22 21:24:41 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Mar 22 21:24:41 2024 +0000" }, "message": "don\u0027t replace is{Not}Empty for nullable targets\n\nFixes: https://github.com/dart-lang/sdk/issues/55250\n\nChange-Id: Iae692c0f6a36e7fc89028acd1934580d1648c937\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359262\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nCommit-Queue: Phil Quitslund \u003cpquitslund@google.com\u003e\n" }, { "commit": "ef3eb6b301d14c6207af7e9f5b006fb8c9eca068", "tree": "4485878ac809d2ed5f337029af7de7cccf8b55ee", "parents": [ "5a657600424a0f1d8eb57243bc91ab9e2c2a666f" ], "author": { "name": "Keerti Parthasarathy", "email": "keertip@google.com", "time": "Fri Mar 22 19:17:29 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Mar 22 19:17:29 2024 +0000" }, "message": "Modify completion test to address comments.\n\nChange-Id: Ib5d1237e9008a9ec1b68558894c3cc15d17347ec\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359242\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nReviewed-by: Konstantin Shcheglov \u003cscheglov@google.com\u003e\nCommit-Queue: Keerti Parthasarathy \u003ckeertip@google.com\u003e\n" }, { "commit": "5a657600424a0f1d8eb57243bc91ab9e2c2a666f", "tree": "971f070cf181c7b4af1f7fda4adf3b4dde5d5d47", "parents": [ "291051e02d92ce63b8d67d0c1cc8c349bd82fe1a" ], "author": { "name": "Konstantin Shcheglov", "email": "scheglov@google.com", "time": "Fri Mar 22 19:04:39 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Mar 22 19:04:39 2024 +0000" }, "message": "Completion. Rework KeywordSuggestion to better constructors.\n\nAs requested in https://dart-review.googlesource.com/c/sdk/+/359240\n\nChange-Id: I5047afaddfd74310303001669177f725aac9c02c\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359261\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nCommit-Queue: Konstantin Shcheglov \u003cscheglov@google.com\u003e\n" }, { "commit": "291051e02d92ce63b8d67d0c1cc8c349bd82fe1a", "tree": "745d236b3d848216ce602298809fd2948c9a98b0", "parents": [ "2447f1a9731ddd53b81be5e3d415a38b58829738" ], "author": { "name": "Tess Strickland", "email": "sstrickl@google.com", "time": "Fri Mar 22 19:03:31 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Mar 22 19:03:31 2024 +0000" }, "message": "[vm/compiler] Add an instruction to adjust unsafe untagged addresses.\n\nComputeElementAddress takes a base untagged address, an index, an index\nscale, and an offset and returns base + (index * scale) + offset as an\nuntagged address.\n\nThis removes the last conversions between untagged and unboxed integers\nfor untagged GC-movable pointers. The only remaining conversions are\nthe following cases, which all involve non-GC-movable pointers:\n\n1. Calls to the FFI resolver (on IA32 only).\n2. Returning nullptr when a pointer to memory is expected in\n exceptional returns from FFI callbacks.\n3. Converting user-provided integers to FFI pointer objects and back.\n\nIn addition, we no longer add the data field to materializations of\ntyped data views, but instead recompute the data field in\nDeferredObject::Fill(). This removes the last source of unsafe untagged\npointers that may have arbitrary lifetimes in the flow graph.\n\nThus, we can now verify in the FlowGraphChecker that there are no\nGC-triggering instructions between the creation of an untagged\nGC-movable pointer and its use (including the use itself). To do this,\nthis CL adds a predicate MayCreateUnsafeUntaggedPointer to definitions,\nwhich by default returns true for kUntagged results, false otherwise,\nand should only be overwritten in cases where the result can be proven\nto not be a untagged GC-movable pointer.\n\nTEST\u003dvm/dart/regress_54710_il_test\n vm/cc/AllocationSinking_NoViewDataMaterialization\n\nFixes: https://github.com/dart-lang/sdk/issues/54710\nCq-Include-Trybots: luci.dart.try:vm-aot-android-release-arm64c-try,vm-aot-linux-debug-x64-try,vm-aot-linux-debug-x64c-try,vm-aot-mac-release-arm64-try,vm-aot-mac-release-x64-try,vm-aot-obfuscate-linux-release-x64-try,vm-aot-optimization-level-linux-release-x64-try,vm-appjit-linux-debug-x64-try,vm-asan-linux-release-x64-try,vm-checked-mac-release-arm64-try,vm-eager-optimization-linux-release-ia32-try,vm-eager-optimization-linux-release-x64-try,vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64c-try,vm-ffi-qemu-linux-release-arm-try,vm-ffi-qemu-linux-release-riscv64-try,vm-fuchsia-release-x64-try,vm-linux-debug-ia32-try,vm-linux-debug-x64c-try,vm-mac-debug-arm64-try,vm-mac-debug-x64-try,vm-msan-linux-release-x64-try,vm-reload-linux-debug-x64-try,vm-reload-rollback-linux-debug-x64-try,vm-ubsan-linux-release-x64-try,vm-win-release-ia32-try\nChange-Id: Ie172a8bd0330a728a4f151478664a530f8d9b38a\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/354862\nCommit-Queue: Tess Strickland \u003csstrickl@google.com\u003e\nReviewed-by: Alexander Markov \u003calexmarkov@google.com\u003e\n" }, { "commit": "2447f1a9731ddd53b81be5e3d415a38b58829738", "tree": "e4a3ec03adcf678e0e48eb107a6974a5e4fe0b36", "parents": [ "683917ddd7bdf39cb4c505102bd9d3171d5ae5d3" ], "author": { "name": "Konstantin Shcheglov", "email": "scheglov@google.com", "time": "Fri Mar 22 17:19:05 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Mar 22 17:19:05 2024 +0000" }, "message": "Completion. Issue 55275. Suggest expressions in AssertStatement condition and message.\n\nBug: https://github.com/dart-lang/sdk/issues/55275\nChange-Id: Icda00b5f472db29bfba8b58bd1a022bf43525221\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359260\nReviewed-by: Phil Quitslund \u003cpquitslund@google.com\u003e\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nCommit-Queue: Konstantin Shcheglov \u003cscheglov@google.com\u003e\n" }, { "commit": "683917ddd7bdf39cb4c505102bd9d3171d5ae5d3", "tree": "88088346a850e094c56a6a95f462517292beba0c", "parents": [ "f1a064cd8afef048113ad547bf7da8f5db64c04c" ], "author": { "name": "Danny Tuppeny", "email": "danny@tuppeny.com", "time": "Fri Mar 22 17:01:40 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Mar 22 17:01:40 2024 +0000" }, "message": "[analysis_server] Change flag for enabling LSP virtual document support\n\nThis accepts the flag without a suffix because I\u0027m fairly confident we can ship this support without breaking changes to the API.\n\nFor a short period, the old flag is still supported so that Dart-Code + SDK don\u0027t need to be updated at the same time to avoid the support disappearing. I will remove the old flag in a few weeks (after a beta SDK branch and a stable Dart-Code release).\n\nChange-Id: I246a33f37a5d5fc5c05c15daab7d87d4cc4fd9e3\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359064\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nReviewed-by: Phil Quitslund \u003cpquitslund@google.com\u003e\nCommit-Queue: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\n" }, { "commit": "f1a064cd8afef048113ad547bf7da8f5db64c04c", "tree": "4a9e86de1b9ad64f30c88dd7cfc0dfecbe321f9b", "parents": [ "df0b1f74f701b05d3f866f33fe324a0170489b90" ], "author": { "name": "Konstantin Shcheglov", "email": "scheglov@google.com", "time": "Fri Mar 22 16:24:31 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Mar 22 16:24:31 2024 +0000" }, "message": "Completion. Issue 55276. Suggest \u0027part of\u0027 and URI completion in it.\n\nBug: https://github.com/dart-lang/sdk/issues/55276\nChange-Id: I7cc4bb94a06115899de941d2e72aa5efeb8831b4\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359240\nReviewed-by: Phil Quitslund \u003cpquitslund@google.com\u003e\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nCommit-Queue: Konstantin Shcheglov \u003cscheglov@google.com\u003e\n" }, { "commit": "df0b1f74f701b05d3f866f33fe324a0170489b90", "tree": "66120904cd1fc1918d48db5c3a4b45304c9d8624", "parents": [ "219f8a90135000ca61f9f83b556f965f1d79de02" ], "author": { "name": "Danny Tuppeny", "email": "danny@tuppeny.com", "time": "Fri Mar 22 16:06:58 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Mar 22 16:06:58 2024 +0000" }, "message": "[analysis_server] Tidy up LSP tests failTestOnAnyErrorNotification to be implied when using expectErrorNotification\n\nThis is a small tidy up that changes `failTestOnAnyErrorNotification` to be automatically set when using `expectErrorNotification` so there\u0027s slightly less noise in tests.\n\nChange-Id: I44056a23aca872b8e96109be4d4ba4356b8af53d\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359221\nCommit-Queue: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nReviewed-by: Konstantin Shcheglov \u003cscheglov@google.com\u003e\n" }, { "commit": "219f8a90135000ca61f9f83b556f965f1d79de02", "tree": "cf3bba1b7b220b3e4021a79605702a3cf831d88b", "parents": [ "4d9aeda9a8e0e08c4587d51f1712944106aa5f02" ], "author": { "name": "Konstantin Shcheglov", "email": "scheglov@google.com", "time": "Fri Mar 22 15:48:49 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Mar 22 15:48:49 2024 +0000" }, "message": "Completion. Issue 55167. Suggest type names for DeclaredVariablePattern.\n\nBug: https://github.com/dart-lang/sdk/issues/55167\nChange-Id: I3fad2f2559bf8677afbe893d8d147a0d443e441a\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359121\nReviewed-by: Keerti Parthasarathy \u003ckeertip@google.com\u003e\nCommit-Queue: Konstantin Shcheglov \u003cscheglov@google.com\u003e\n" }, { "commit": "4d9aeda9a8e0e08c4587d51f1712944106aa5f02", "tree": "17090db6efbd8c94587f59321c48a244d442045e", "parents": [ "e8ed4989026da45ea09f3d9dae230aff8f702a23" ], "author": { "name": "Chloe Stefantsova", "email": "cstefantsova@google.com", "time": "Fri Mar 22 13:01:05 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Mar 22 13:01:05 2024 +0000" }, "message": "[cfe] Use StructuralParameters in TypedefTearOff and TypedefTearOffConstant\n\nChange-Id: I6b221f36065b78c985c8a216b1ac43f9e518bb3e\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/358905\nReviewed-by: Johnni Winther \u003cjohnniwinther@google.com\u003e\nCommit-Queue: Chloe Stefantsova \u003ccstefantsova@google.com\u003e\n" }, { "commit": "e8ed4989026da45ea09f3d9dae230aff8f702a23", "tree": "61f4f584c168c8dd3090f5670fd51a0d8ffd33f3", "parents": [ "1cebdcb2da217ca264d2dfb245c081296852b2bf" ], "author": { "name": "Jonas Termansen", "email": "sortie@google.com", "time": "Fri Mar 22 12:21:39 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Mar 22 12:21:39 2024 +0000" }, "message": "[infra] Remove --no-goma from test matrix.\n\nGoma is off by default, and RBE is only enabled where it is known to\nwork, so there is no need to disable RBE instead. Some of these builders\nadditionally disable RBE in their infra/config definitions and there is\nno need to duplicate that information here.\n\nBug: b/296994239\nChange-Id: I9f9733ba5189b53b899289a23d68126f7c6adcc5\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/357610\nCommit-Queue: Jonas Termansen \u003csortie@google.com\u003e\nReviewed-by: William Hesse \u003cwhesse@google.com\u003e\n" }, { "commit": "1cebdcb2da217ca264d2dfb245c081296852b2bf", "tree": "507a1e90fa5395245989d2fbef0846c64bd1a318", "parents": [ "a6a34344047cc51f2b3fae2be1949b514fd1d54c" ], "author": { "name": "Tess Strickland", "email": "sstrickl@google.com", "time": "Fri Mar 22 10:20:48 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Mar 22 10:20:48 2024 +0000" }, "message": "[vm/ffi] Use untagged pointer representations for FFI pointers.\n\nPreviously, the FFI used unboxed integers as a native representation\nfor pointers in FFI code, as the compiler only handled very specific\nuses of untagged pointers flowing between instructions. Since then,\nthis restriction has been removed for untagged pointers that do not\npoint to memory managed by the GC, like FFI pointers, so now they can\nhave a more precise representation.\n\nBy being precise about when untagged (untagged pointers to freshly\nallocated Handles and the contents of Pointer data fields) and tagged\n(TypedData objects constructed to hold the byte representation of\ncompound data) values are expected, we can remove the need to have\nuntagged pointers to GC-movable objects and/or having untagged\npointers escape as unboxed integers in the generated IL.\n\nThis CL also renames kUnboxedFfiIntPtr -\u003e kUnboxedAddress and limits\nits uses specifically to where the unboxed integer represents the\nnumeric representation of an untagged pointer.\n\nThis CL changes CCall to take Representations for the arguments and\nreturn value instead of what looks like an arbitrary\nNativeCallingConvention. However, the serializer and deserializers for\nCCall, used in IL tests, originally assumed that the argument and return\nrepresentations were kUnboxedFfiIntPtr, so providing an arbitrary\nNativeCallingConvention which didn\u0027t match that assumption would cause\nfailures during IL tests. That assumption came from the fact that\nthe only creator of CCall instructions was in kernel_to_il.cc, and there\nthat was the case.\n\nNow CCall builds the native calling convention during construction\nand deserialization from the argument and return representations and\nstores both the representations and built native calling convention\ninternally. In the future, if we want to create CCall instructions with\nmore arbitrary native calling conventions, then we\u0027ll need to handle\nserialization/deserialization of arbitrary native calling conventions,\nand also add consistency checks that the provided representations\nappropriately match the native calling convention.\n\nTEST\u003dffi vm/dart/regress_306327173_il vm/dart/address_local_pointer_il\n\nIssue: https://github.com/dart-lang/sdk/issues/54710\nCq-Include-Trybots: luci.dart.try:vm-aot-android-release-arm64c-try,vm-aot-android-release-arm_x64-try,vm-aot-linux-debug-x64-try,vm-aot-linux-debug-x64c-try,vm-aot-mac-release-arm64-try,vm-aot-mac-release-x64-try,vm-aot-obfuscate-linux-release-x64-try,vm-aot-optimization-level-linux-release-x64-try,vm-aot-win-debug-arm64-try,vm-appjit-linux-debug-x64-try,vm-asan-linux-release-x64-try,vm-checked-mac-release-arm64-try,vm-eager-optimization-linux-release-ia32-try,vm-eager-optimization-linux-release-x64-try,vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64c-try,vm-ffi-qemu-linux-release-arm-try,vm-ffi-qemu-linux-release-riscv64-try,vm-fuchsia-release-x64-try,vm-linux-debug-ia32-try,vm-linux-debug-x64-try,vm-linux-debug-x64c-try,vm-mac-debug-arm64-try,vm-mac-debug-x64-try,vm-msan-linux-release-x64-try,vm-reload-linux-debug-x64-try,vm-reload-rollback-linux-debug-x64-try,vm-ubsan-linux-release-x64-try,vm-win-debug-arm64-try,vm-win-debug-x64-try,vm-win-release-ia32-try\nChange-Id: I34effe8fbdc80288b703e0152d5ba67ce2343400\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/353101\nReviewed-by: Daco Harkes \u003cdacoharkes@google.com\u003e\nCommit-Queue: Tess Strickland \u003csstrickl@google.com\u003e\n" }, { "commit": "a6a34344047cc51f2b3fae2be1949b514fd1d54c", "tree": "26a23ec2f9eba888ac76e246d7bde215500cf532", "parents": [ "0d3ade255ba88da3ea801a82eb7a8b73b16265dc" ], "author": { "name": "Tess Strickland", "email": "sstrickl@google.com", "time": "Fri Mar 22 10:17:11 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Mar 22 10:17:11 2024 +0000" }, "message": "[vm/compiler] Use temps instead of writable registers in MemoryCopy.\n\nThis keeps the array registers unchanged across the instruction,\nwhich can save instructions if there are unused registers to allocate\nfor the temporaries and the source or destination registers are live\nafter the copy (e.g., if the destination array is then used in a\nLoadIndexed instruction post-copy).\n\nOn IA32, we still use writable registers due to register pressure.\n\nTEST\u003dci\n\nChange-Id: Ia955f8db39e4aba0f01b9d06ea50992a7375a492\nCq-Include-Trybots: luci.dart.try:vm-aot-android-release-arm64c-try,vm-aot-android-release-arm_x64-try,vm-aot-linux-debug-x64-try,vm-aot-linux-debug-x64c-try,vm-aot-mac-release-arm64-try,vm-aot-mac-release-x64-try,vm-aot-obfuscate-linux-release-x64-try,vm-aot-optimization-level-linux-release-x64-try,vm-aot-win-debug-arm64-try,vm-appjit-linux-debug-x64-try,vm-asan-linux-release-x64-try,vm-checked-mac-release-arm64-try,vm-eager-optimization-linux-release-ia32-try,vm-eager-optimization-linux-release-x64-try,vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64c-try,vm-ffi-qemu-linux-release-arm-try,vm-ffi-qemu-linux-release-riscv64-try,vm-fuchsia-release-x64-try,vm-linux-debug-ia32-try,vm-linux-debug-x64-try,vm-linux-debug-x64c-try,vm-mac-debug-arm64-try,vm-mac-debug-x64-try,vm-msan-linux-release-x64-try,vm-reload-linux-debug-x64-try,vm-reload-rollback-linux-debug-x64-try,vm-ubsan-linux-release-x64-try,vm-win-debug-arm64-try,vm-win-debug-x64-try,vm-win-release-ia32-try\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/357901\nCommit-Queue: Tess Strickland \u003csstrickl@google.com\u003e\nReviewed-by: Alexander Markov \u003calexmarkov@google.com\u003e\n" }, { "commit": "0d3ade255ba88da3ea801a82eb7a8b73b16265dc", "tree": "dba6ff53c9bcd55d3a07293dd2ae8314e67d076d", "parents": [ "495d08eca870bc00fc1304b4d077c0b896f73c57" ], "author": { "name": "Tess Strickland", "email": "sstrickl@google.com", "time": "Fri Mar 22 10:12:39 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Mar 22 10:12:39 2024 +0000" }, "message": "[vm/compiler] Limit exposure of untagged pointers to managed memory.\n\nAfter https://dart-review.googlesource.com/c/sdk/+/330600, there were\nmore chances for the optimizing compiler to introduce or move\nGC-triggering instructions like allocations or boxings between the\nretrieval of an untagged pointer to GC-moveable memory and its use.\n\nTo limit the chance of this happening, this CL removes the explicit\nloading of the untagged payload address when building the initial\nflow graph in most cases when the array is not known to be an external\narray (an external string, an external typed data object, or an FFI\nPointer).\n\nThe remaining case is during view allocation, which extracts the\npayload address of the base typed data object underlying the view\n(which may be GC-movable) to calculate the payload address that should\nbe stored in the data field of the view object. See\nhttps://github.com/dart-lang/sdk/issues/54884.\n\nDuring canonicalization of LoadIndexed, StoreIndexed, and MemoryCopy\ninstructions, if the cid of an array input is an external array\n(external string, external typed data object, or Pointer), then a\nLoadField instruction that extracts the untagged payload address\nis inserted before the instruction and the corresponding input is\nrebound to that LoadField instruction.\n\nOnce all compiler passes that involve code motion have been performed,\na new pass looks for LoadIndexed, StoreIndexed, or MemoryCopy where\nthe cid stored in the instruction for the array is a typed data cid.\nIn these cases, if the array is not an internal typed data object,\nthen the payload address is extracted. Waiting until this point ensures\nthat no GC-triggering instructions are inserted between the extraction\nof the payload address and the use. (Internal typed data objects are\nleft as-is because the payload address is inside the object itself\nand doesn\u0027t require indirection through the data field of the object).\n\nThis CL also replaces code conditional on the array cid with code\nthat is instead conditional on the array element representation in\ncases where it makes sense to do so, since this is a less brittle\ncheck than checking the array cid (e.g., checking for kUnboxedInt8\nto load, store, or copy an signed byte from an array instead of\nlisting all possible array cids that store signed bytes).\n\nThis CL also fixes an issue with the ARM64 assembler where calling\nLoadFromOffset with an Address that has a non-Offset type would\nsilently generate bad code instead of triggering the ASSERT in\nPrepareLargeOffset.\n\nTEST\u003dvm/dart/typed_list_index_checkbound_il_test\n\nIssue: https://github.com/dart-lang/sdk/issues/54710\nCq-Include-Trybots: luci.dart.try:vm-aot-android-release-arm64c-try,vm-aot-android-release-arm_x64-try,vm-aot-linux-debug-x64-try,vm-aot-linux-debug-x64c-try,vm-aot-mac-release-arm64-try,vm-aot-mac-release-x64-try,vm-aot-obfuscate-linux-release-x64-try,vm-aot-optimization-level-linux-release-x64-try,vm-aot-win-debug-arm64-try,vm-appjit-linux-debug-x64-try,vm-asan-linux-release-x64-try,vm-checked-mac-release-arm64-try,vm-eager-optimization-linux-release-ia32-try,vm-eager-optimization-linux-release-x64-try,vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64c-try,vm-ffi-qemu-linux-release-arm-try,vm-ffi-qemu-linux-release-riscv64-try,vm-fuchsia-release-x64-try,vm-linux-debug-ia32-try,vm-linux-debug-x64-try,vm-linux-debug-x64c-try,vm-mac-debug-arm64-try,vm-mac-debug-x64-try,vm-msan-linux-release-x64-try,vm-reload-linux-debug-x64-try,vm-reload-rollback-linux-debug-x64-try,vm-ubsan-linux-release-x64-try,vm-win-debug-arm64-try,vm-win-debug-x64-try,vm-win-release-ia32-try\nChange-Id: I25b5f314943e9254d3d28986d720a5d47f12feeb\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/352363\nReviewed-by: Daco Harkes \u003cdacoharkes@google.com\u003e\nReviewed-by: Ryan Macnak \u003crmacnak@google.com\u003e\nCommit-Queue: Tess Strickland \u003csstrickl@google.com\u003e\nReviewed-by: Alexander Markov \u003calexmarkov@google.com\u003e\nReviewed-by: Martin Kustermann \u003ckustermann@google.com\u003e\n" }, { "commit": "495d08eca870bc00fc1304b4d077c0b896f73c57", "tree": "2f0a5d84480917948b131aa619342e9af85f3733", "parents": [ "529d2c78d0abd501b074ab827b13dbcfb023044d" ], "author": { "name": "Jonas Termansen", "email": "sortie@google.com", "time": "Fri Mar 22 10:09:06 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Mar 22 10:09:06 2024 +0000" }, "message": "[infra] Disable goma by default in favor of RBE.\n\nBug: b/296994239\nChange-Id: I99e1dcfb1016cbb064a742d8cc930f3468d26f3f\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/358161\nReviewed-by: William Hesse \u003cwhesse@google.com\u003e\nAuto-Submit: Jonas Termansen \u003csortie@google.com\u003e\nCommit-Queue: Jonas Termansen \u003csortie@google.com\u003e\n" }, { "commit": "529d2c78d0abd501b074ab827b13dbcfb023044d", "tree": "e2bf8fe9f8102ccfd9871f90e251ef6abbcaadee", "parents": [ "b626c255eb438b666876580bc0638c6f061cade2" ], "author": { "name": "Jens Johansen", "email": "jensj@google.com", "time": "Fri Mar 22 09:12:22 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Mar 22 09:12:22 2024 +0000" }, "message": "[CFE] update_expectations.dart can also run multiple special suits\n\nE.g. the below command should update both strong, weak, etc and\nincremental, parser etc suites with any test containing ffi:\n\n`out/ReleaseX64/dart pkg/front_end/tool/update_expectations.dart *ffi*`\n\nIn the future we should, I think, update the tool to be more like\n`unit_test_suites.dart` and get rid of the option for package:testing\nto generate a program and then run that.\n\nChange-Id: I19edfe2198cbe86326396dc2c8a8f871c599588d\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359061\nCommit-Queue: Jens Johansen \u003cjensj@google.com\u003e\nReviewed-by: Chloe Stefantsova \u003ccstefantsova@google.com\u003e\n" }, { "commit": "b626c255eb438b666876580bc0638c6f061cade2", "tree": "eeeed8fb8f6349a587f0330283fba757e89fcbac", "parents": [ "e5a60de9d866d771bad19e40ade9b31c41764544" ], "author": { "name": "Dan Chevalier", "email": "danchevalier@google.com", "time": "Fri Mar 22 01:28:39 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Mar 22 01:28:39 2024 +0000" }, "message": "Updating DTD docs to ensure they are ready for the consumption.\n\nChange-Id: Iccbf88959bbd68bac897e3f5b05dbf5fe2a0a4bd\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/355460\nReviewed-by: Ben Konyi \u003cbkonyi@google.com\u003e\nReviewed-by: Kenzie Davisson \u003ckenzieschmoll@google.com\u003e\nCommit-Queue: Dan Chevalier \u003cdanchevalier@google.com\u003e\n" }, { "commit": "e5a60de9d866d771bad19e40ade9b31c41764544", "tree": "70eba55d7e1ee56d3c2eec953370817a04ea1986", "parents": [ "9f64559a8d003edbf17051364431ecf3249cb349" ], "author": { "name": "Konstantin Shcheglov", "email": "scheglov@google.com", "time": "Fri Mar 22 00:56:15 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Mar 22 00:56:15 2024 +0000" }, "message": "Completion. Migrate UriContributor.\n\nChange-Id: If2b50d47736277eca2a2f4a20189cdb14d775f17\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359080\nCommit-Queue: Konstantin Shcheglov \u003cscheglov@google.com\u003e\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\n" }, { "commit": "9f64559a8d003edbf17051364431ecf3249cb349", "tree": "ac5ffd8fce9646f5ee1e5f5b15d626cdbe0fb5c3", "parents": [ "3ca76a245ae6f0fbd864eafe3cc5326bd38ad638" ], "author": { "name": "Konstantin Shcheglov", "email": "scheglov@google.com", "time": "Fri Mar 22 00:13:09 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Mar 22 00:13:09 2024 +0000" }, "message": "Completion. Issue 55263. Suggest formal parameters in AssertInitializer.\n\nBug: https://github.com/dart-lang/sdk/issues/55263\nChange-Id: Id210e1c98f9c8f5e20c09e6cade6c9893bd40761\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359140\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nCommit-Queue: Konstantin Shcheglov \u003cscheglov@google.com\u003e\n" }, { "commit": "3ca76a245ae6f0fbd864eafe3cc5326bd38ad638", "tree": "6a69e43c6a53afb554a8a59bdfa45c0fba586e3e", "parents": [ "4b5d3e05e9005e1a55065bb76c33f6310e54785a" ], "author": { "name": "Konstantin Shcheglov", "email": "scheglov@google.com", "time": "Thu Mar 21 22:44:02 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 21 22:44:02 2024 +0000" }, "message": "Completion. Migrate LibraryPrefixContributor.\n\nChange-Id: I26e3a2d2a4d724262a5444580987ab9ad8ca9507\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/358665\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nCommit-Queue: Konstantin Shcheglov \u003cscheglov@google.com\u003e\n" }, { "commit": "4b5d3e05e9005e1a55065bb76c33f6310e54785a", "tree": "e45194b495dfdf4fce53cdea9be84bc30a0a2461", "parents": [ "5a8bc19faf64fce3896937eecffd22ce0d9c2d51" ], "author": { "name": "Ryan Macnak", "email": "rmacnak@google.com", "time": "Thu Mar 21 22:22:42 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 21 22:22:42 2024 +0000" }, "message": "[vm, gc] Use temporal coarsening when accounting for old-space bump pointer allocations.\n\nTo avoid accounting overhead during each bump pointer allocation, we add the size of the whole bump area when starting to use that area and\nsubtract the remaining size when switching to a new area.\n\nTEST\u003dci\nChange-Id: If0c429db47c27ca51aac5c055268e85f70bad9ac\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359160\nReviewed-by: Alexander Aprelev \u003caam@google.com\u003e\nCommit-Queue: Ryan Macnak \u003crmacnak@google.com\u003e\n" }, { "commit": "5a8bc19faf64fce3896937eecffd22ce0d9c2d51", "tree": "54fbfc3bec2dc7761ef0f97a43d72ea2cebb5b5e", "parents": [ "fc168c6a5f398f5588d4e1b20e1d7fd069f6c6d0" ], "author": { "name": "Jake Macdonald", "email": "jakemac@google.com", "time": "Thu Mar 21 21:22:12 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 21 21:22:12 2024 +0000" }, "message": "add skeleton for _macros package\n\nChange-Id: I9a4a84e4292b7fef1de76222a540c341ed041e51\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359041\nCommit-Queue: Jake Macdonald \u003cjakemac@google.com\u003e\nCommit-Queue: Ilya Yanok \u003cyanok@google.com\u003e\nAuto-Submit: Jake Macdonald \u003cjakemac@google.com\u003e\nReviewed-by: Ilya Yanok \u003cyanok@google.com\u003e\n" }, { "commit": "fc168c6a5f398f5588d4e1b20e1d7fd069f6c6d0", "tree": "15bff746ffe964a37effb3e5ae8fa2a20efe9183", "parents": [ "5536951738ba599d96e075b7140e52b28e2336a2" ], "author": { "name": "Konstantin Shcheglov", "email": "scheglov@google.com", "time": "Thu Mar 21 21:18:29 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 21 21:18:29 2024 +0000" }, "message": "Completion. Migrate EnumConstantConstructorContributor.\n\nChange-Id: If09014bad3467a9c0933d4f8aad6950051172efe\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/358683\nReviewed-by: Keerti Parthasarathy \u003ckeertip@google.com\u003e\nCommit-Queue: Konstantin Shcheglov \u003cscheglov@google.com\u003e\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\n" }, { "commit": "5536951738ba599d96e075b7140e52b28e2336a2", "tree": "bcc76a3ef9c00b9cce86ab64193d2b9ab1ed374e", "parents": [ "6eb85949fdd7b893ed74c82914ed86abc37f1b27" ], "author": { "name": "Ben Konyi", "email": "bkonyi@google.com", "time": "Thu Mar 21 21:09:42 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 21 21:09:42 2024 +0000" }, "message": "[ DDS ] Rework client resume permissions API\n\nThis change reworks the client resume permissions API to make it easier\nfor clients to deal with user provided `--pause-isolates-on-start` and\n`--pause-isolates-on-exit` flags.\n\n`requireUserPermissionToResume` should be called by the tool that\nlaunches the Dart process to indicate whether or not the user provided\n`--pause-isolates-on-{start,exit}`. The default behavior is to assume\nthat a tool set these flags for its own use (e.g., resetting breakpoints\nafter a hot restart in Flutter), where isolates will resume immediately\nafter each client that has indicated interest in that pause event has\ninvoked `readyToResume`.\n\nIf a user provided one of the previously mentioned flags, isolates will\nnot immediately resume after each relevant client has invoked\n`readyToResume`. Instead, a call to `resume()` must be made to indicate\nthe user has triggered the resume request instead of tooling. If the\nuser permissions to resume are changed while the isolate is paused and\nall relevant clients have invoked `readyToResume`, the isolate will\nautomatically resume if the user no longer requires us to wait for a\nuser resume.\n\n`resume()` now also acts as a \"force resume\", bypassing any required\npermissions set by tooling.\n\nThis behavior change is breaking, so the DDS protocol version is being\nbumped to 2.0.\n\n`package:dds_service_extensions` has also been updated to include the\nfollowing DDS RPCs:\n\n - `requireUserPermissionToResume`\n - `readyToResume`\n\nChange-Id: Id5f0806b3c56507d39eb00b6305b8896bab13ae7\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/357420\nReviewed-by: Elliott Brooks \u003celliottbrooks@google.com\u003e\nCommit-Queue: Ben Konyi \u003cbkonyi@google.com\u003e\n" }, { "commit": "6eb85949fdd7b893ed74c82914ed86abc37f1b27", "tree": "8ca7d3c1f8ade69932ba1036e7e941c632a96079", "parents": [ "87df8c4691f258f132a904992fe11b92e50dac6c" ], "author": { "name": "Ben Konyi", "email": "bkonyi@google.com", "time": "Thu Mar 21 19:50:46 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 21 19:50:46 2024 +0000" }, "message": "[ VM / DDS ] Add --print-dtd-uri flag and launch DTD from the correct snapshot for AOT\n\nThis adds support for printing the DTD connection information to stdout\nwhen --print-dtd-uri is passed.\n\nThis change also fixes an issue where DDS would fail to spawn an isolate\nwith the DTD snapshot when DDS was running in AOT mode. This means the\nSDK must be shipped with both AppJIT and AOT DTD snapshots, at least\nuntil dartdev is moved to run from AOT.\n\nFixes https://github.com/dart-lang/sdk/issues/55034\n\nTEST\u003drun_test.dart\n\nChange-Id: I788ef9bfe76297a8d594992a2aac440ed9e2ecac\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/358541\nReviewed-by: Siva Annamalai \u003casiva@google.com\u003e\nCommit-Queue: Ben Konyi \u003cbkonyi@google.com\u003e\nReviewed-by: Kenzie Davisson \u003ckenzieschmoll@google.com\u003e\n" }, { "commit": "87df8c4691f258f132a904992fe11b92e50dac6c", "tree": "eedaaebcea6d502957d000c34fd02ed2ad0be645", "parents": [ "4c689ca7f51780690520d96dd904e2d23aaa50cb" ], "author": { "name": "Devon Carew", "email": "devoncarew@google.com", "time": "Thu Mar 21 17:15:58 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 21 17:15:58 2024 +0000" }, "message": "rev to the latest package:args; update pkg/dartdev\n\nChange-Id: I7535e4c9cd9afb78905525fc0986dc6d60894362\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/358225\nReviewed-by: Ben Konyi \u003cbkonyi@google.com\u003e\nCommit-Queue: Devon Carew \u003cdevoncarew@google.com\u003e\n" }, { "commit": "4c689ca7f51780690520d96dd904e2d23aaa50cb", "tree": "4bb0f692943277d5f50fc22d9603b3f65b7b66eb", "parents": [ "701cd77844840fe3cbedcefadef601a065df661f" ], "author": { "name": "Sam Rawlins", "email": "srawlins@google.com", "time": "Thu Mar 21 17:07:43 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 21 17:07:43 2024 +0000" }, "message": "das: Extract CorrectionUtils.getTypeSource; tidy ExtractMethodRefactoring\n\nThis is mostly a very tidy extraction of `getTypeSource`. This method\nrelied on a handful of helper functions, all of which were _only_\npresent in order to help `getTypeSource`. This method also does not\nrely on `_buffer` or `eol`. And it is only used by one piece of code,\n`extract_method`. Almost a slam dunk!\n\nHowever, there appeared some strange caveats that I must document\nhere:\n\nCorrectionUtils also featured two mutable fields, `targetClassElement`\nand `targetExecutableElement`. Theoretically, these fields are\nsupposed to be set before calling `getTypeSource`, to help understand\nwhether a TypeParameter will be visible when extracting a method, or\nsomething like that. But it appears to be totally broken:\n\n* The singular caller of `getTypeSource`, `ExtractMethodRefactoring`,\n _never sets those fields_.\n* Two other pieces of code, the AddTypeAnnotation fix, and the\n CreateField, CreateFunction, and CreateOverrides fixes, all set the\n fields, but _never call getTypeSource_.\n\nSince this all looked like just very stale / rotten code, I removed\neverything which looks to be dead: `targetClassElement` and\n`targetExecutableElement`, and lo and behold: no tests fail! I\u0027ve kept\nthose things deleted, and added a TODO for TypeParameters.\n\nLastly, since I was trying to figure out ExtractMethodRefactoring, I\ntidied it up:\n\n* Make it final\n* Rename `ERROR_EXITS` to `errorExits`\n* Privatize `searchEngine`, `resolveResult`, `selectionOffset`,\n `selectionLength`, `librariesToImport`, and `variableType`.\n* Both `selectionRange` and `utils` could be final as they were set\n in the constructor body, so move that to initializers, make final,\n and make private.\n\nChange-Id: Ia3fb948e5424971eb4250e711c179707552ad8aa\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/358663\nCommit-Queue: Samuel Rawlins \u003csrawlins@google.com\u003e\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nReviewed-by: Konstantin Shcheglov \u003cscheglov@google.com\u003e\n" }, { "commit": "701cd77844840fe3cbedcefadef601a065df661f", "tree": "ae972df8eba71c34d5cd0abfabae4ec6e3d8101f", "parents": [ "5119fb93c46f70245cf3ba019e7132610a9b5215" ], "author": { "name": "Paul Berry", "email": "paulberry@google.com", "time": "Thu Mar 21 16:38:11 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 21 16:38:11 2024 +0000" }, "message": "Ignore TODO in pkg/analyzer_plugin.\n\nThe analyzer team has decided to adopt the convention of using `TODO`\ncomments to document long term issues that should persist in the\ncodebase, and `FIXME` comments to document short term issues that need\nimmediate attention. They may even consider adding a presubmit hook\nto ensure that `FIXME` comments are only used during local\ndevelopment.\n\nAccordingly, it makes sense to suppress `TODO` comments from being\nsurfaced to the IDE \"problems\" view (since there are hundreds of them,\nand they\u0027re not immediately actionable). This makes VSCode\u0027s\n\"problems\" view much more usable in \"tree\" mode.\n\n(See also https://dart-review.googlesource.com/c/sdk/+/295662, which\nmade the corresponding change to the `analysis_server` and `analyzer`\npackages, and https://dart-review.googlesource.com/c/sdk/+/325121,\nwhich made the corresponding change to the `linter` package).\n\nChange-Id: Ifbd2f6bed468408b1906b25ab94f745eed0b3e55\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/358980\nReviewed-by: Konstantin Shcheglov \u003cscheglov@google.com\u003e\nCommit-Queue: Paul Berry \u003cpaulberry@google.com\u003e\n" }, { "commit": "5119fb93c46f70245cf3ba019e7132610a9b5215", "tree": "81d3342606dad71c25cf4182682e2f92669bad20", "parents": [ "56f2e00fd658e6a3a80a2456379622777323b8c9" ], "author": { "name": "Keerti Parthasarathy", "email": "keertip@google.com", "time": "Thu Mar 21 16:22:38 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 21 16:22:38 2024 +0000" }, "message": "Completion Issue 52839: Show local declarations intead of global when shadowed.\n\nFixes https://github.com/dart-lang/sdk/issues/52839.\n\nChange-Id: I84c112d2aff9cb60c829d366c14a621558eb7712\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/358560\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nCommit-Queue: Keerti Parthasarathy \u003ckeertip@google.com\u003e\n" } ], "next": "56f2e00fd658e6a3a80a2456379622777323b8c9" }