Prepare a point release of analyzer 0.32.x.
Error checking was recently added to the front end and the analyzer
(see bb2775b16a027c885d1bd4a313d8f234b3181f93 and
9185294e7a80943b05be50ea3305173217da62cc) to ensure that mixin
applications could not introduce invalid overrides. This causes
problems if a user tries to analyze the old (0.32.5) version of the
analyzer using the latest dart SDK, since the analyzer and the front
end had invalid overrides of this sort at the time that analyzer
0.32.x was branched (note that the invalid overrides in the analyzer
were only in test code).
This CL cherry-picks the invalid override fixes from master to the
0.32.x branch so that we can do a point release of the analyzer,
front_end, and kernel. Once we've done the point release, users who
see errors in the analyzer or front_end packages when using the latest
dart SDK will be able to fix the problem by running "pub upgrade".
See https://github.com/dart-lang/sdk/issues/34675.
Change-Id: I8e5ccd2472eea4aefc75b9bcdf92e6c8e39b2897
Reviewed-on: https://dart-review.googlesource.com/c/78149
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
diff --git a/pkg/analyzer/CHANGELOG.md b/pkg/analyzer/CHANGELOG.md
index 7c7f33c..2fd718e 100644
--- a/pkg/analyzer/CHANGELOG.md
+++ b/pkg/analyzer/CHANGELOG.md
@@ -1,3 +1,11 @@
+## 0.32.6
+* Fixed some invalid overrides that were previously undetected due to
+ https://github.com/dart-lang/sdk/issues/34392.
+
+## 0.32.5
+* Made SummaryBuilder's "strong" argument optional. This should ease clients in
+ preparing for analyzer version 0.33.
+
## 0.32.4
* Updated SDK constraint to <3.0.0.
* Updated to be compatible with Dart 2 void usage semantics.
diff --git a/pkg/analyzer/pubspec.yaml b/pkg/analyzer/pubspec.yaml
index b998656..65f46d2 100644
--- a/pkg/analyzer/pubspec.yaml
+++ b/pkg/analyzer/pubspec.yaml
@@ -1,5 +1,5 @@
name: analyzer
-version: 0.32.5
+version: 0.32.6
author: Dart Team <misc@dartlang.org>
description: Static analyzer for Dart.
homepage: https://github.com/dart-lang/sdk/tree/master/pkg/analyzer
@@ -11,10 +11,10 @@
collection: ^1.10.1
convert: ^2.0.0
crypto: '>=1.1.1 <3.0.0'
- front_end: 0.1.4+1
+ front_end: 0.1.4+2
glob: ^1.0.3
html: '>=0.12.0 <1.14.0'
- kernel: 0.3.4+1
+ kernel: 0.3.4+2
meta: ^1.0.2
package_config: '>=0.1.5 <2.0.0'
path: '>=0.9.0 <2.0.0'
diff --git a/pkg/analyzer/test/src/summary/resynthesize_ast_test.dart b/pkg/analyzer/test/src/summary/resynthesize_ast_test.dart
index 43cccd7..a4d4032 100644
--- a/pkg/analyzer/test/src/summary/resynthesize_ast_test.dart
+++ b/pkg/analyzer/test/src/summary/resynthesize_ast_test.dart
@@ -7,6 +7,7 @@
import 'package:analyzer/dart/ast/ast.dart';
import 'package:analyzer/dart/element/element.dart';
import 'package:analyzer/error/error.dart';
+import 'package:analyzer/src/context/context.dart';
import 'package:analyzer/src/dart/element/element.dart';
import 'package:analyzer/src/generated/engine.dart'
show AnalysisContext, AnalysisOptionsImpl;
@@ -52,7 +53,7 @@
final Map<String, UnlinkedUnitBuilder> uriToUnit =
<String, UnlinkedUnitBuilder>{};
- AnalysisContext get context;
+ AnalysisContextImpl get context;
TestSummaryResynthesizer encodeLibrary(Source source) {
_serializeLibrary(source);
@@ -207,7 +208,7 @@
*/
abstract class _AstResynthesizeTestMixin
implements _AstSerializeTestMixinInterface {
- AnalysisContext get context;
+ AnalysisContextImpl get context;
TestSummaryResynthesizer encodeLibrary(Source source);
diff --git a/pkg/front_end/lib/src/fasta/kernel/expression_generator.dart b/pkg/front_end/lib/src/fasta/kernel/expression_generator.dart
index 5678166..5b704d7 100644
--- a/pkg/front_end/lib/src/fasta/kernel/expression_generator.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/expression_generator.dart
@@ -790,7 +790,8 @@
{int offset: -1,
bool voidContext: false,
Procedure interfaceTarget,
- bool isPreIncDec: false}) {
+ bool isPreIncDec: false,
+ bool isPostIncDec: false}) {
return new SyntheticExpressionJudgment(buildError(
forest.arguments(<Expression>[value], token, token),
isGetter: true));
@@ -953,7 +954,8 @@
{int offset: -1,
bool voidContext: false,
Procedure interfaceTarget,
- bool isPreIncDec: false}) {
+ bool isPreIncDec: false,
+ bool isPostIncDec: false}) {
return makeInvalidWrite(value);
}
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator.dart
index 5f5a608..8e91ea5 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator.dart
@@ -1537,7 +1537,8 @@
{int offset: TreeNode.noOffset,
bool voidContext: false,
Procedure interfaceTarget,
- bool isPreIncDec: false}) {
+ bool isPreIncDec: false,
+ bool isPostIncDec: false}) {
return _buildUnresolvedVariableAssignment(true, value);
}
diff --git a/pkg/front_end/pubspec.yaml b/pkg/front_end/pubspec.yaml
index c8eeab0..d5f7142 100644
--- a/pkg/front_end/pubspec.yaml
+++ b/pkg/front_end/pubspec.yaml
@@ -1,7 +1,7 @@
name: front_end
# Currently, front_end API is not stable and users should not
# depend on semver semantics when depending on this package.
-version: 0.1.4+1
+version: 0.1.4+2
author: Dart Team <misc@dartlang.org>
description: Front end for compilation of Dart code.
homepage: https://github.com/dart-lang/sdk/tree/master/pkg/front_end
@@ -11,7 +11,7 @@
charcode: '^1.1.1'
convert: '^2.0.1'
crypto: '^2.0.2'
- kernel: 0.3.4+1
+ kernel: 0.3.4+2
meta: '^1.1.1'
package_config: '^1.0.1'
path: '^1.3.9'
diff --git a/pkg/kernel/pubspec.yaml b/pkg/kernel/pubspec.yaml
index 71dcd66..8aed8e6 100644
--- a/pkg/kernel/pubspec.yaml
+++ b/pkg/kernel/pubspec.yaml
@@ -1,7 +1,7 @@
name: kernel
# Currently, kernel API is not stable and users should
# not depend on semver semantics when depending on this package.
-version: 0.3.4+1
+version: 0.3.4+2
author: Dart Team <misc@dartlang.org>
description: Dart IR (Intermediate Representation)
homepage: https://github.com/dart-lang/sdk/tree/master/pkg/kernel
@@ -14,7 +14,7 @@
package_config: ^1.0.0
dev_dependencies:
analyzer: '>=0.31.0 <0.33.0'
- front_end: 0.1.4+1
+ front_end: 0.1.4+2
test: ^0.12.15+6
stack_trace: ^1.6.6
test_reflective_loader: ^0.1.0
