commit | e767dca0a69ae25121f83e21e736c66d1b4ef1f4 | [log] [tgz] |
---|---|---|
author | Martin Kustermann <kustermann@google.com> | Wed Jan 12 08:30:42 2022 +0000 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Jan 12 08:30:42 2022 +0000 |
tree | 88d599cbcc3c88144cab55cdb4c3cef5f39db28c | |
parent | 1bf93d73a1076223dad79c9af9113de368089436 [diff] |
[vm] Make stack trace generation code more conservative If the _FutureListener.handleValue function gets deoptimized at a point when the `this` is no longer needed/live the deoptimization procedure may override the `this` slot in the caller frame with "<optimized out>". This has been triggered on the "iso-stress" builder due to using VM testing flags that cause many deoptimizations in many places. The stack walking code should take this possibility into consideration and be therefore conservative. Alternatives considered: * Use "copy parameters" into our own frame approach - like we do with methods that have optional parameters => This will make all unoptimized code slower. * Add a reachability fence to the _FutureListener.handleValue function => The reachabilityFench is only available in dart:_internal for VM => If the function could be debugged after fence but before return one might be able to trigger the issue nonetheless. Closes https://github.com/dart-lang/sdk/issues/46823 TEST=Should remove flaky crashes on "iso-stress" builder. Change-Id: I9d953706b292e02d2ba75fd794c872865faf45d0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/227401 Reviewed-by: Alexander Markov <alexmarkov@google.com> Reviewed-by: Slava Egorov <vegorov@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.