tree b2bc4ea41b2a1957815520f4881dcca144c63a2d
parent 40757e679e7d8baebbdbe76e3cabed2a6a7632bb
author Sam Rawlins <srawlins@google.com> 1646091357 +0000
committer Commit Bot <commit-bot@chromium.org> 1646091357 +0000

Tidy code in dartdev

Just code I was tidying while investigating a dartdev bug. Complies
better with Effective Dart.

* https://dart.dev/guides/language/effective-dart/design#dont-redundantly-type-annotate-initialized-local-variables
* https://dart.dev/guides/language/effective-dart/design#avoid-abbreviations

Also restrict a utility function to accept a non-nullable String and
return a non-nullable String.

Change-Id: I465a320cbd4fe9f7625119e873f67425b4caf8e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>