tree 575eab13a646af7082f843327439cfb1aba02ddd
parent 285eea93388145deaced5f1d36892791970d894f
author Tess Strickland <sstrickl@google.com> 1638966750 +0000
committer Commit Bot <commit-bot@chromium.org> 1638966750 +0000

[vm/compiler] Make TemplateLoadField::CanCallDart more precise.

Only return true if the stub being invoked will call the
initializer function directly. Notably, return false if the stub
just calls the runtime.

This removes some write barriers in legacy code that were added
after 37d45743.

TEST=New asserts that check CanCallDart() is false when calling runtime
     and is true when calling stubs that call initializer functions
     directly, combined with legacy code tests that use non-late fields.

Change-Id: I4118968b6ea42371d068c35d50339574939556e5
Bug: b/208619946
Cq-Include-Trybots: luci.dart.try:vm-kernel-linux-release-simarm-try,vm-kernel-linux-release-simarm64-try,vm-kernel-linux-release-ia32-try,vm-kernel-linux-release-x64-try,vm-kernel-nnbd-linux-release-ia32-try,vm-kernel-nnbd-linux-release-simarm-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-precomp-linux-release-simarm-try,vm-kernel-precomp-linux-release-simarm64-try,vm-kernel-precomp-linux-release-simarm_x64-try,vm-kernel-precomp-linux-release-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-simarm_x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/221943
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Tess Strickland <sstrickl@google.com>