tree de4743e56b3d69a4ec9c6c300796abccaff6e933
parent b67f45f9557b813787ce963ad809fc70b31d6600
author Sam Rawlins <srawlins@google.com> 1629753130 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> 1629753130 +0000

Analyzer: Fix representation of an arrow generator (illegal) function

Fixes https://github.com/dart-lang/sdk/issues/43665

A function like `foo() sync* => []` is illegal, but there is no _parse_
error, only a compile-time error. So the analyzer needs to be able to
represent this function accurately.

I think that without this fix, the formatter crashes trying to format
such a function.

Without this fix, a function like `foo() sync* => []` has a
FunctionElement with `isAsynchronous` true (because there _is_ a
modifier) and `isGenerator` false, because an arrow function cannot be
a generator. But these bool values lead to wrong errors being reported.

Change-Id: I1f7bda3696d04b437f6ea12491ca4aa19b893574
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210820
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>