tree 7538ec8b4b4e77d116bf068c2f417874a1bdf17e
parent 78b9f5495796463bd09e01ab7f90477840d8f0e4
author Paul Berry <paulberry@google.com> 1631875739 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> 1631875739 +0000

Fix analyzerCode corresponding to CFE error ConstructorWithTypeArguments.

Previously we had identified this error with the analyzer error code
CompileTimeErrorCode.WRONG_NUMBER_OF_TYPE_ARGUMENTS_CONSTRUCTOR, but
they're not the same error at all.  As a result, code like this:

    var x = new a.b.c<C>();

would lead to the bogus analyzer error text "The constructor '{0}.{1}'
doesn't have type parameters." (with the placeholders "{0}" and "{1}"
visible to the user).

With this change, the error text is the same as that from the CFE: "A
constructor invocation can't have type arguments after the constructor
name."

Change-Id: Ib69d1ff8f7089e59b71d2dcd9a8ec51edffd94dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213621
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>