tree 86ca577b8c60591c4614bc6908aa7f3b816b5a54
parent ae8a2aac09e8d96f1e9a31df2b0ec16444a6cc1c
author Nicholas Shahan <nshahan@google.com> 1626740134 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> 1626740134 +0000

[ddc] Fix generic method constant tearoffs

Previously all functions objects returned by `dart.gbind()` would
contain the same 3 properties: name, length, and runtimeType. For
two distinct functions, if these three properties were the same
our constant canonicalization would incorrectly canonicalize to the
same value. Attaching the original function and the type arguments
used in instantiation ensures the const canonicalization will treat
different functions or instantiations as different values.

These values will also be used for equality checks proposed here:
https://github.com/dart-lang/language/issues/1712

Fixes: https://github.com/dart-lang/sdk/issues/46568
Issue: https://github.com/dart-lang/sdk/issues/46486
Change-Id: I65111df9af80d878eb3127c5e3dfac1ffba95535
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206423
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>