tree 3127dd8eeb2ef0b3da8b1f8c253d643dfa542bd5
parent 627292bcc0eeb54051d6fd910cda4b7717df3bf3
author Tess Strickland <sstrickl@google.com> 1626431508 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> 1626431508 +0000

[vm] Remove Closure::signature().

Revert the changes in 0920ac88 to use Closure::signature() and
remove the previously existing uses.

Refactor the majority of Object_haveSameRuntimeType out into a helper
function, which lifts the various Bool::Get()s out of the return
statements for easier reading. Also delay retrieving the class out of
the instance until after checking for closure, since we can check the
retrieved cids against kClosureCid instead.

Also move ASSERTs from debug printing of SubtypeTestCache entries
to UpdateTypeTestCache, to ensure they are checked when
--trace-type-checks is not enabled.

TEST=Refactoring, so existing tests. Checked manually on a separate
     CL which triggered a case where Closure::signature() was
     erroneously returning null due to the direct trip through ptrs.

Change-Id: Iff9b5c8e3f6426cc7deb5ce73c02606597d99d5b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/207124
Commit-Queue: Tess Strickland <sstrickl@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>