commit | 69f6378ed52dd118364c8e6b25a6ecbd8353ad07 | [log] [tgz] |
---|---|---|
author | Jens Johansen <jensj@google.com> | Wed Apr 07 12:25:27 2021 +0000 |
committer | commit-bot@chromium.org <commit-bot@chromium.org> | Wed Apr 07 12:25:27 2021 +0000 |
tree | 35d57cd25f5b34b2d0a639b7f4899e48f3f53e96 | |
parent | 363da9038517e8895d69a39393c4023ba9a43ba1 [diff] |
[CFE] Make unit_test_suites log better message when test starts to pass In for instance https://dart-review.googlesource.com/c/sdk/+/193961/5 we had an instance of something good happening (a crashing-ish test that started to pass) but where the author was told no (red bot) and not given a path to make the bot happy (bad messaging). Specifically tests failed and the best log one got was ``` To re-run this test, run: dart pkg/front_end/test/unit_test_suites.dart -p pkg/front_end/test/fasta/textual_outline/general/constants/js_semantics/issue45376 ``` which isn't very helpful. If running it locally a little more information is given via stdout, but having to do that isn't great (and the little extra information still wasn't great). This CL updates the messaging to - hopefully - give a path to make the bot happy. The messaging will now - directly from the log on the bot - be ``` FAILED: pkg/front_end/test/fasta/textual_outline/general/constants/js_semantics/issue45376: Pass To re-run this test, run: dart pkg/front_end/test/unit_test_suites.dart -p pkg/front_end/test/fasta/textual_outline/general/constants/js_semantics/issue45376 The test passed, but wasn't expected to. You should update the status file for this test. There's a status entry looking something like general/constants/js_semantics/issue45376: FormatterCrash which should be removed. The status file is file:///[wherever]/sdk/pkg/front_end/testcases/textual_outline.status. ``` which a) gives the extra information previously only available via stdout when running locally (the first line). b) Gives an explanation as to why it failed ("The test passed, but wasn't expected to."). c) A path to make the bot green ("You should update the status file for this test. [...] should be removed"). Hopefully this will make it easier to deal with in the future when something good happens. Change-Id: I838699abce580334c956d8b4753884fd600802ae Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194242 Commit-Queue: Jens Johansen <jensj@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.