commit dab1efeb5d471f354dedd15b136420a5bef999af
author Martin Kustermann <kustermann@google.com> Tue Nov 24 11:25:58 2020 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> Tue Nov 24 11:25:58 2020 +0000
tree 1e60be46f573cb15bd9aa5894cb3cb876c219d23
parent 3536a5e6ef682a4cfd46652a5b790446c329b8ea

[vm/concurrency] Make the IGs own the initial static field value table

As part of making lightweight isolates work in JIT, we will need to
ensure that whenever a new isolate is spawned it will get it's initial
global field table populated.

In order to achieve this we make the isolate groups initial field table
the authoritive place where we

  a) register initial static field values
  b) serializer reads them from, deserializer writes them to

This allows us to also remove the `FieldLayout::initial_saved_value_`
that was present for both static and non-static fields. In reality this
initial saved value is only meaningful for static fields though it was
kept in memory as well as (de)serialized even for non-static fields.

The one place where it was actually used for non-static fields was
incorrect and should instead use `null`.

The removal of this field results in net removal of code in this CL.

Issue https://github.com/dart-lang/sdk/issues/36097

TEST=Internal refactoring, relying on existing test coverage.

Change-Id: I088a87e2ea159bac7fa7f1f360da553d752e6569
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173263
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>