Version 2.12.0-286.0.dev
Merge commit '2f004a27d474612a816f9fc2f8702aad346b6490' into 'dev'
diff --git a/pkg/_fe_analyzer_shared/lib/src/parser/identifier_context_impl.dart b/pkg/_fe_analyzer_shared/lib/src/parser/identifier_context_impl.dart
index b49806d..5c3963f 100644
--- a/pkg/_fe_analyzer_shared/lib/src/parser/identifier_context_impl.dart
+++ b/pkg/_fe_analyzer_shared/lib/src/parser/identifier_context_impl.dart
@@ -1103,14 +1103,23 @@
return identifier;
}
- // Recovery
+ // Recovery: If the next token (the one currently in 'identifier') is any
+ // of these values we don't "eat" the it but instead insert an identifier
+ // between "token" and "token.next" and return that as the last consumed
+ // token. Otherwise such a token would be consumed: an identifier would be
+ // inserted after "token.next" and that would be returned as the last
+ // consumed token, effectively skipping the token.
const List<String> followingValues = const [
'<',
'>',
';',
'}',
'extends',
- 'super'
+ 'super',
+ // If currently adding type variables to a typedef this could easily
+ // occur and we don't want to 'eat' the equal sign.
+ '=',
+ '>=',
];
if (looksLikeStartOfNextTopLevelDeclaration(identifier) ||
looksLikeStartOfNextClassMember(identifier) ||
diff --git a/pkg/analyzer/test/generated/top_level_parser_test.dart b/pkg/analyzer/test/generated/top_level_parser_test.dart
index f61ec88..16aed27 100644
--- a/pkg/analyzer/test/generated/top_level_parser_test.dart
+++ b/pkg/analyzer/test/generated/top_level_parser_test.dart
@@ -1725,6 +1725,62 @@
expect(alias.semicolon, isNotNull);
}
+ void test_parseGenericTypeAlias_TypeParametersInProgress1() {
+ createParser('typedef F< = int Function(int);');
+ GenericTypeAlias alias =
+ parseFullCompilationUnitMember() as GenericTypeAlias;
+ expect(alias, isNotNull);
+ assertErrors(errors: [
+ expectedError(ParserErrorCode.MISSING_IDENTIFIER, 11, 1),
+ ]);
+ expect(alias.name, isNotNull);
+ expect(alias.name.name, 'F');
+ expect(alias.typeParameters, isNotNull);
+ expect(alias.typeParameters!.typeParameters.length, 1);
+ expect(alias.typeParameters!.typeParameters.single.name.name, '');
+ expect(alias.equals, isNotNull);
+ expect(alias.functionType, isNotNull);
+ expect(alias.semicolon, isNotNull);
+ }
+
+ void test_parseGenericTypeAlias_TypeParametersInProgress2() {
+ createParser('typedef F<>= int Function(int);');
+ GenericTypeAlias alias =
+ parseFullCompilationUnitMember() as GenericTypeAlias;
+ expect(alias, isNotNull);
+ assertErrors(errors: [
+ expectedError(ParserErrorCode.MISSING_IDENTIFIER, 10, 2),
+ ]);
+ expect(alias.name, isNotNull);
+ expect(alias.name.name, 'F');
+ expect(alias.name.name, 'F');
+ expect(alias.typeParameters, isNotNull);
+ expect(alias.typeParameters!.typeParameters.length, 1);
+ expect(alias.typeParameters!.typeParameters.single.name.name, '');
+ expect(alias.equals, isNotNull);
+ expect(alias.functionType, isNotNull);
+ expect(alias.semicolon, isNotNull);
+ }
+
+ void test_parseGenericTypeAlias_TypeParametersInProgress3() {
+ createParser('typedef F<> = int Function(int);');
+ GenericTypeAlias alias =
+ parseFullCompilationUnitMember() as GenericTypeAlias;
+ expect(alias, isNotNull);
+ assertErrors(errors: [
+ expectedError(ParserErrorCode.MISSING_IDENTIFIER, 10, 1),
+ ]);
+ expect(alias.name, isNotNull);
+ expect(alias.name.name, 'F');
+ expect(alias.name.name, 'F');
+ expect(alias.typeParameters, isNotNull);
+ expect(alias.typeParameters!.typeParameters.length, 1);
+ expect(alias.typeParameters!.typeParameters.single.name.name, '');
+ expect(alias.equals, isNotNull);
+ expect(alias.functionType, isNotNull);
+ expect(alias.semicolon, isNotNull);
+ }
+
void test_parseImportDirective_configuration_multiple() {
createParser("import 'lib/lib.dart' if (a) 'b.dart' if (c) 'd.dart';");
var directive = parseFullDirective() as ImportDirective;
diff --git a/pkg/front_end/parser_testcases/error_recovery/issue_43090.crash_dart b/pkg/front_end/parser_testcases/error_recovery/issue_43090.crash_dart
new file mode 100644
index 0000000..4ba99a6
--- /dev/null
+++ b/pkg/front_end/parser_testcases/error_recovery/issue_43090.crash_dart
@@ -0,0 +1 @@
+typedef A< = void Function();
diff --git a/pkg/front_end/parser_testcases/error_recovery/issue_43090.crash_dart.expect b/pkg/front_end/parser_testcases/error_recovery/issue_43090.crash_dart.expect
new file mode 100644
index 0000000..38e3d3b
--- /dev/null
+++ b/pkg/front_end/parser_testcases/error_recovery/issue_43090.crash_dart.expect
@@ -0,0 +1,31 @@
+Problems reported:
+
+parser/error_recovery/issue_43090.crash:1:12: Expected an identifier, but got '='.
+typedef A< = void Function();
+ ^
+
+beginCompilationUnit(typedef)
+ beginMetadataStar(typedef)
+ endMetadataStar(0)
+ beginUncategorizedTopLevelDeclaration(typedef)
+ beginFunctionTypeAlias(typedef)
+ handleIdentifier(A, typedefDeclaration)
+ beginTypeVariables(<)
+ beginMetadataStar(=)
+ endMetadataStar(0)
+ handleRecoverableError(Message[ExpectedIdentifier, Expected an identifier, but got '='., Try inserting an identifier before '='., {lexeme: =}], =, =)
+ handleIdentifier(, typeVariableDeclaration)
+ beginTypeVariable()
+ handleTypeVariablesDefined(, 1)
+ handleNoType()
+ endTypeVariable(=, 0, null, null)
+ endTypeVariables(<, >)
+ beginFunctionType(void)
+ handleNoTypeVariables(()
+ handleVoidKeyword(void)
+ beginFormalParameters((, MemberKind.GeneralizedFunctionType)
+ endFormalParameters(0, (, ), MemberKind.GeneralizedFunctionType)
+ endFunctionType(Function, null)
+ endFunctionTypeAlias(typedef, =, ;)
+ endTopLevelDeclaration()
+endCompilationUnit(1, )
diff --git a/pkg/front_end/parser_testcases/error_recovery/issue_43090.crash_dart.intertwined.expect b/pkg/front_end/parser_testcases/error_recovery/issue_43090.crash_dart.intertwined.expect
new file mode 100644
index 0000000..b25871b
--- /dev/null
+++ b/pkg/front_end/parser_testcases/error_recovery/issue_43090.crash_dart.intertwined.expect
@@ -0,0 +1,42 @@
+parseUnit(typedef)
+ skipErrorTokens(typedef)
+ listener: beginCompilationUnit(typedef)
+ syntheticPreviousToken(typedef)
+ parseTopLevelDeclarationImpl(, Instance of 'DirectiveContext')
+ parseMetadataStar()
+ listener: beginMetadataStar(typedef)
+ listener: endMetadataStar(0)
+ parseTopLevelKeywordDeclaration(, typedef, Instance of 'DirectiveContext')
+ parseTopLevelKeywordModifiers(, typedef)
+ parseTypedef(typedef)
+ listener: beginUncategorizedTopLevelDeclaration(typedef)
+ listener: beginFunctionTypeAlias(typedef)
+ ensureIdentifierPotentiallyRecovered(typedef, typedefDeclaration, true)
+ listener: handleIdentifier(A, typedefDeclaration)
+ listener: beginTypeVariables(<)
+ parseMetadataStar(<)
+ listener: beginMetadataStar(=)
+ listener: endMetadataStar(0)
+ ensureIdentifier(<, typeVariableDeclaration)
+ reportRecoverableErrorWithToken(=, Instance of 'Template<(Token) => Message>')
+ listener: handleRecoverableError(Message[ExpectedIdentifier, Expected an identifier, but got '='., Try inserting an identifier before '='., {lexeme: =}], =, =)
+ rewriter()
+ listener: handleIdentifier(, typeVariableDeclaration)
+ listener: beginTypeVariable()
+ listener: handleTypeVariablesDefined(, 1)
+ listener: handleNoType()
+ listener: endTypeVariable(=, 0, null, null)
+ listener: endTypeVariables(<, >)
+ listener: beginFunctionType(void)
+ listener: handleNoTypeVariables(()
+ listener: handleVoidKeyword(void)
+ parseFormalParametersRequiredOpt(Function, MemberKind.GeneralizedFunctionType)
+ parseFormalParametersRest((, MemberKind.GeneralizedFunctionType)
+ listener: beginFormalParameters((, MemberKind.GeneralizedFunctionType)
+ listener: endFormalParameters(0, (, ), MemberKind.GeneralizedFunctionType)
+ listener: endFunctionType(Function, null)
+ ensureSemicolon())
+ listener: endFunctionTypeAlias(typedef, =, ;)
+ listener: endTopLevelDeclaration()
+ reportAllErrorTokens(typedef)
+ listener: endCompilationUnit(1, )
diff --git a/pkg/front_end/parser_testcases/error_recovery/issue_43090.crash_dart.parser.expect b/pkg/front_end/parser_testcases/error_recovery/issue_43090.crash_dart.parser.expect
new file mode 100644
index 0000000..2ee22c4
--- /dev/null
+++ b/pkg/front_end/parser_testcases/error_recovery/issue_43090.crash_dart.parser.expect
@@ -0,0 +1,7 @@
+NOTICE: Stream was rewritten by parser!
+
+typedef A< >= void Function();
+
+
+typedef[KeywordToken] A[StringToken]<[BeginToken] [SyntheticStringToken]>[SyntheticToken]=[SimpleToken] void[KeywordToken] Function[KeywordToken]([BeginToken])[SimpleToken];[SimpleToken]
+[SimpleToken]
diff --git a/pkg/front_end/parser_testcases/error_recovery/issue_43090.crash_dart.scanner.expect b/pkg/front_end/parser_testcases/error_recovery/issue_43090.crash_dart.scanner.expect
new file mode 100644
index 0000000..56ad91a
--- /dev/null
+++ b/pkg/front_end/parser_testcases/error_recovery/issue_43090.crash_dart.scanner.expect
@@ -0,0 +1,5 @@
+typedef A< = void Function();
+
+
+typedef[KeywordToken] A[StringToken]<[BeginToken] =[SimpleToken] void[KeywordToken] Function[KeywordToken]([BeginToken])[SimpleToken];[SimpleToken]
+[SimpleToken]
diff --git a/pkg/front_end/parser_testcases/error_recovery/issue_43090_prime_01.crash_dart b/pkg/front_end/parser_testcases/error_recovery/issue_43090_prime_01.crash_dart
new file mode 100644
index 0000000..3b36868
--- /dev/null
+++ b/pkg/front_end/parser_testcases/error_recovery/issue_43090_prime_01.crash_dart
@@ -0,0 +1 @@
+typedef A<int> = void Function();
diff --git a/pkg/front_end/parser_testcases/error_recovery/issue_43090_prime_01.crash_dart.expect b/pkg/front_end/parser_testcases/error_recovery/issue_43090_prime_01.crash_dart.expect
new file mode 100644
index 0000000..06f3c99
--- /dev/null
+++ b/pkg/front_end/parser_testcases/error_recovery/issue_43090_prime_01.crash_dart.expect
@@ -0,0 +1,24 @@
+beginCompilationUnit(typedef)
+ beginMetadataStar(typedef)
+ endMetadataStar(0)
+ beginUncategorizedTopLevelDeclaration(typedef)
+ beginFunctionTypeAlias(typedef)
+ handleIdentifier(A, typedefDeclaration)
+ beginTypeVariables(<)
+ beginMetadataStar(int)
+ endMetadataStar(0)
+ handleIdentifier(int, typeVariableDeclaration)
+ beginTypeVariable(int)
+ handleTypeVariablesDefined(int, 1)
+ handleNoType(int)
+ endTypeVariable(>, 0, null, null)
+ endTypeVariables(<, >)
+ beginFunctionType(void)
+ handleNoTypeVariables(()
+ handleVoidKeyword(void)
+ beginFormalParameters((, MemberKind.GeneralizedFunctionType)
+ endFormalParameters(0, (, ), MemberKind.GeneralizedFunctionType)
+ endFunctionType(Function, null)
+ endFunctionTypeAlias(typedef, =, ;)
+ endTopLevelDeclaration()
+endCompilationUnit(1, )
diff --git a/pkg/front_end/parser_testcases/error_recovery/issue_43090_prime_01.crash_dart.intertwined.expect b/pkg/front_end/parser_testcases/error_recovery/issue_43090_prime_01.crash_dart.intertwined.expect
new file mode 100644
index 0000000..e0ba1a2
--- /dev/null
+++ b/pkg/front_end/parser_testcases/error_recovery/issue_43090_prime_01.crash_dart.intertwined.expect
@@ -0,0 +1,37 @@
+parseUnit(typedef)
+ skipErrorTokens(typedef)
+ listener: beginCompilationUnit(typedef)
+ syntheticPreviousToken(typedef)
+ parseTopLevelDeclarationImpl(, Instance of 'DirectiveContext')
+ parseMetadataStar()
+ listener: beginMetadataStar(typedef)
+ listener: endMetadataStar(0)
+ parseTopLevelKeywordDeclaration(, typedef, Instance of 'DirectiveContext')
+ parseTopLevelKeywordModifiers(, typedef)
+ parseTypedef(typedef)
+ listener: beginUncategorizedTopLevelDeclaration(typedef)
+ listener: beginFunctionTypeAlias(typedef)
+ ensureIdentifierPotentiallyRecovered(typedef, typedefDeclaration, true)
+ listener: handleIdentifier(A, typedefDeclaration)
+ listener: beginTypeVariables(<)
+ listener: beginMetadataStar(int)
+ listener: endMetadataStar(0)
+ listener: handleIdentifier(int, typeVariableDeclaration)
+ listener: beginTypeVariable(int)
+ listener: handleTypeVariablesDefined(int, 1)
+ listener: handleNoType(int)
+ listener: endTypeVariable(>, 0, null, null)
+ listener: endTypeVariables(<, >)
+ listener: beginFunctionType(void)
+ listener: handleNoTypeVariables(()
+ listener: handleVoidKeyword(void)
+ parseFormalParametersRequiredOpt(Function, MemberKind.GeneralizedFunctionType)
+ parseFormalParametersRest((, MemberKind.GeneralizedFunctionType)
+ listener: beginFormalParameters((, MemberKind.GeneralizedFunctionType)
+ listener: endFormalParameters(0, (, ), MemberKind.GeneralizedFunctionType)
+ listener: endFunctionType(Function, null)
+ ensureSemicolon())
+ listener: endFunctionTypeAlias(typedef, =, ;)
+ listener: endTopLevelDeclaration()
+ reportAllErrorTokens(typedef)
+ listener: endCompilationUnit(1, )
diff --git a/pkg/front_end/parser_testcases/error_recovery/issue_43090_prime_01.crash_dart.parser.expect b/pkg/front_end/parser_testcases/error_recovery/issue_43090_prime_01.crash_dart.parser.expect
new file mode 100644
index 0000000..f305182
--- /dev/null
+++ b/pkg/front_end/parser_testcases/error_recovery/issue_43090_prime_01.crash_dart.parser.expect
@@ -0,0 +1,5 @@
+typedef A<int> = void Function();
+
+
+typedef[KeywordToken] A[StringToken]<[BeginToken]int[StringToken]>[SimpleToken] =[SimpleToken] void[KeywordToken] Function[KeywordToken]([BeginToken])[SimpleToken];[SimpleToken]
+[SimpleToken]
diff --git a/pkg/front_end/parser_testcases/error_recovery/issue_43090_prime_01.crash_dart.scanner.expect b/pkg/front_end/parser_testcases/error_recovery/issue_43090_prime_01.crash_dart.scanner.expect
new file mode 100644
index 0000000..f305182
--- /dev/null
+++ b/pkg/front_end/parser_testcases/error_recovery/issue_43090_prime_01.crash_dart.scanner.expect
@@ -0,0 +1,5 @@
+typedef A<int> = void Function();
+
+
+typedef[KeywordToken] A[StringToken]<[BeginToken]int[StringToken]>[SimpleToken] =[SimpleToken] void[KeywordToken] Function[KeywordToken]([BeginToken])[SimpleToken];[SimpleToken]
+[SimpleToken]
diff --git a/pkg/front_end/parser_testcases/error_recovery/issue_43090_prime_02.crash_dart b/pkg/front_end/parser_testcases/error_recovery/issue_43090_prime_02.crash_dart
new file mode 100644
index 0000000..e3d8ed7
--- /dev/null
+++ b/pkg/front_end/parser_testcases/error_recovery/issue_43090_prime_02.crash_dart
@@ -0,0 +1 @@
+typedef A<>= void Function();
diff --git a/pkg/front_end/parser_testcases/error_recovery/issue_43090_prime_02.crash_dart.expect b/pkg/front_end/parser_testcases/error_recovery/issue_43090_prime_02.crash_dart.expect
new file mode 100644
index 0000000..bc0db5a
--- /dev/null
+++ b/pkg/front_end/parser_testcases/error_recovery/issue_43090_prime_02.crash_dart.expect
@@ -0,0 +1,31 @@
+Problems reported:
+
+parser/error_recovery/issue_43090_prime_02.crash:1:11: Expected an identifier, but got '>='.
+typedef A<>= void Function();
+ ^^
+
+beginCompilationUnit(typedef)
+ beginMetadataStar(typedef)
+ endMetadataStar(0)
+ beginUncategorizedTopLevelDeclaration(typedef)
+ beginFunctionTypeAlias(typedef)
+ handleIdentifier(A, typedefDeclaration)
+ beginTypeVariables(<)
+ beginMetadataStar(>=)
+ endMetadataStar(0)
+ handleRecoverableError(Message[ExpectedIdentifier, Expected an identifier, but got '>='., Try inserting an identifier before '>='., {lexeme: >=}], >=, >=)
+ handleIdentifier(, typeVariableDeclaration)
+ beginTypeVariable()
+ handleTypeVariablesDefined(, 1)
+ handleNoType()
+ endTypeVariable(>=, 0, null, null)
+ endTypeVariables(<, >)
+ beginFunctionType(void)
+ handleNoTypeVariables(()
+ handleVoidKeyword(void)
+ beginFormalParameters((, MemberKind.GeneralizedFunctionType)
+ endFormalParameters(0, (, ), MemberKind.GeneralizedFunctionType)
+ endFunctionType(Function, null)
+ endFunctionTypeAlias(typedef, =, ;)
+ endTopLevelDeclaration()
+endCompilationUnit(1, )
diff --git a/pkg/front_end/parser_testcases/error_recovery/issue_43090_prime_02.crash_dart.intertwined.expect b/pkg/front_end/parser_testcases/error_recovery/issue_43090_prime_02.crash_dart.intertwined.expect
new file mode 100644
index 0000000..da37ef6
--- /dev/null
+++ b/pkg/front_end/parser_testcases/error_recovery/issue_43090_prime_02.crash_dart.intertwined.expect
@@ -0,0 +1,42 @@
+parseUnit(typedef)
+ skipErrorTokens(typedef)
+ listener: beginCompilationUnit(typedef)
+ syntheticPreviousToken(typedef)
+ parseTopLevelDeclarationImpl(, Instance of 'DirectiveContext')
+ parseMetadataStar()
+ listener: beginMetadataStar(typedef)
+ listener: endMetadataStar(0)
+ parseTopLevelKeywordDeclaration(, typedef, Instance of 'DirectiveContext')
+ parseTopLevelKeywordModifiers(, typedef)
+ parseTypedef(typedef)
+ listener: beginUncategorizedTopLevelDeclaration(typedef)
+ listener: beginFunctionTypeAlias(typedef)
+ ensureIdentifierPotentiallyRecovered(typedef, typedefDeclaration, true)
+ listener: handleIdentifier(A, typedefDeclaration)
+ listener: beginTypeVariables(<)
+ parseMetadataStar(<)
+ listener: beginMetadataStar(>=)
+ listener: endMetadataStar(0)
+ ensureIdentifier(<, typeVariableDeclaration)
+ reportRecoverableErrorWithToken(>=, Instance of 'Template<(Token) => Message>')
+ listener: handleRecoverableError(Message[ExpectedIdentifier, Expected an identifier, but got '>='., Try inserting an identifier before '>='., {lexeme: >=}], >=, >=)
+ rewriter()
+ listener: handleIdentifier(, typeVariableDeclaration)
+ listener: beginTypeVariable()
+ listener: handleTypeVariablesDefined(, 1)
+ listener: handleNoType()
+ listener: endTypeVariable(>=, 0, null, null)
+ listener: endTypeVariables(<, >)
+ listener: beginFunctionType(void)
+ listener: handleNoTypeVariables(()
+ listener: handleVoidKeyword(void)
+ parseFormalParametersRequiredOpt(Function, MemberKind.GeneralizedFunctionType)
+ parseFormalParametersRest((, MemberKind.GeneralizedFunctionType)
+ listener: beginFormalParameters((, MemberKind.GeneralizedFunctionType)
+ listener: endFormalParameters(0, (, ), MemberKind.GeneralizedFunctionType)
+ listener: endFunctionType(Function, null)
+ ensureSemicolon())
+ listener: endFunctionTypeAlias(typedef, =, ;)
+ listener: endTopLevelDeclaration()
+ reportAllErrorTokens(typedef)
+ listener: endCompilationUnit(1, )
diff --git a/pkg/front_end/parser_testcases/error_recovery/issue_43090_prime_02.crash_dart.parser.expect b/pkg/front_end/parser_testcases/error_recovery/issue_43090_prime_02.crash_dart.parser.expect
new file mode 100644
index 0000000..d4a3d9c
--- /dev/null
+++ b/pkg/front_end/parser_testcases/error_recovery/issue_43090_prime_02.crash_dart.parser.expect
@@ -0,0 +1,7 @@
+NOTICE: Stream was rewritten by parser!
+
+typedef A<>= void Function();
+
+
+typedef[KeywordToken] A[StringToken]<[BeginToken][SyntheticStringToken]>[SimpleToken]=[SimpleToken] void[KeywordToken] Function[KeywordToken]([BeginToken])[SimpleToken];[SimpleToken]
+[SimpleToken]
diff --git a/pkg/front_end/parser_testcases/error_recovery/issue_43090_prime_02.crash_dart.scanner.expect b/pkg/front_end/parser_testcases/error_recovery/issue_43090_prime_02.crash_dart.scanner.expect
new file mode 100644
index 0000000..5c8e181
--- /dev/null
+++ b/pkg/front_end/parser_testcases/error_recovery/issue_43090_prime_02.crash_dart.scanner.expect
@@ -0,0 +1,5 @@
+typedef A<>= void Function();
+
+
+typedef[KeywordToken] A[StringToken]<[BeginToken]>=[SimpleToken] void[KeywordToken] Function[KeywordToken]([BeginToken])[SimpleToken];[SimpleToken]
+[SimpleToken]
diff --git a/pkg/front_end/test/fasta/parser/parser.status b/pkg/front_end/test/fasta/parser/parser.status
index 5a6bc42..47b4856 100644
--- a/pkg/front_end/test/fasta/parser/parser.status
+++ b/pkg/front_end/test/fasta/parser/parser.status
@@ -81,7 +81,6 @@
runtime/lib/vmservice_patch: Fail
runtime/lib/weak_property: Fail
runtime/observatory/tests/service/developer_extension_test: Fail
-runtime/observatory/tests/service/get_isolate_after_language_error_test: Fail
samples/sample_extension/sample_asynchronous_extension: Fail
samples/sample_extension/sample_synchronous_extension: Fail
sdk/lib/_blink/dartium/_blink_dartium: Fail
diff --git a/pkg/front_end/testcases/general/error_recovery/issue_43090.crash_dart b/pkg/front_end/testcases/general/error_recovery/issue_43090.crash_dart
new file mode 100644
index 0000000..a560a5b
--- /dev/null
+++ b/pkg/front_end/testcases/general/error_recovery/issue_43090.crash_dart
@@ -0,0 +1,2 @@
+typedef A< = void Function();
+main() {}
diff --git a/pkg/front_end/testcases/general/error_recovery/issue_43090.crash_dart.outline.expect b/pkg/front_end/testcases/general/error_recovery/issue_43090.crash_dart.outline.expect
new file mode 100644
index 0000000..67ac964
--- /dev/null
+++ b/pkg/front_end/testcases/general/error_recovery/issue_43090.crash_dart.outline.expect
@@ -0,0 +1,14 @@
+library;
+//
+// Problems in library:
+//
+// pkg/front_end/testcases/general/error_recovery/issue_43090.crash_dart:1:12: Error: Expected an identifier, but got '='.
+// Try inserting an identifier before '='.
+// typedef A< = void Function();
+// ^
+//
+import self as self;
+
+typedef A = () →* void;
+static method main() → dynamic
+ ;
diff --git a/pkg/front_end/testcases/general/error_recovery/issue_43090.crash_dart.strong.expect b/pkg/front_end/testcases/general/error_recovery/issue_43090.crash_dart.strong.expect
new file mode 100644
index 0000000..bb2548b
--- /dev/null
+++ b/pkg/front_end/testcases/general/error_recovery/issue_43090.crash_dart.strong.expect
@@ -0,0 +1,13 @@
+library;
+//
+// Problems in library:
+//
+// pkg/front_end/testcases/general/error_recovery/issue_43090.crash_dart:1:12: Error: Expected an identifier, but got '='.
+// Try inserting an identifier before '='.
+// typedef A< = void Function();
+// ^
+//
+import self as self;
+
+typedef A = () →* void;
+static method main() → dynamic {}
diff --git a/pkg/front_end/testcases/general/error_recovery/issue_43090.crash_dart.strong.transformed.expect b/pkg/front_end/testcases/general/error_recovery/issue_43090.crash_dart.strong.transformed.expect
new file mode 100644
index 0000000..bb2548b
--- /dev/null
+++ b/pkg/front_end/testcases/general/error_recovery/issue_43090.crash_dart.strong.transformed.expect
@@ -0,0 +1,13 @@
+library;
+//
+// Problems in library:
+//
+// pkg/front_end/testcases/general/error_recovery/issue_43090.crash_dart:1:12: Error: Expected an identifier, but got '='.
+// Try inserting an identifier before '='.
+// typedef A< = void Function();
+// ^
+//
+import self as self;
+
+typedef A = () →* void;
+static method main() → dynamic {}
diff --git a/pkg/front_end/testcases/general/error_recovery/issue_43090.crash_dart.textual_outline.expect b/pkg/front_end/testcases/general/error_recovery/issue_43090.crash_dart.textual_outline.expect
new file mode 100644
index 0000000..7046ff3
--- /dev/null
+++ b/pkg/front_end/testcases/general/error_recovery/issue_43090.crash_dart.textual_outline.expect
@@ -0,0 +1,2 @@
+typedef A< >= void Function();
+main() {}
diff --git a/pkg/front_end/testcases/outline.status b/pkg/front_end/testcases/outline.status
index 7221323..03eecfc 100644
--- a/pkg/front_end/testcases/outline.status
+++ b/pkg/front_end/testcases/outline.status
@@ -37,7 +37,6 @@
inference/infer_assign_to_property_custom: Fail
inference/infer_assign_to_property: Fail
inference/infer_method_missing_params: TypeCheckError
-inference/infer_type_cast: Fail
inference/infer_types_on_generic_instantiations_infer: TypeCheckError
inference/mixin_inference_outwards_3: TypeCheckError
inference/mixin_inference_outwards_4: TypeCheckError
diff --git a/pkg/front_end/testcases/sdk.status b/pkg/front_end/testcases/sdk.status
index 9119938..7a1b5ef 100644
--- a/pkg/front_end/testcases/sdk.status
+++ b/pkg/front_end/testcases/sdk.status
@@ -13,8 +13,6 @@
language_2/conditional_property_increment_decrement_test/16_generated: VerificationError
language_2/conditional_property_increment_decrement_test/21_generated: VerificationError
language_2/conditional_property_increment_decrement_test/27_generated: VerificationError
-language_2/constructor5_test: VerificationError
-language_2/constructor6_test: VerificationError
language_2/extension_methods/static_extension_operators_test: VerificationError
language_2/if_null_assignment_behavior_test/13_generated: Crash
language_2/if_null_assignment_behavior_test/15_generated: Crash
diff --git a/pkg/front_end/testcases/strong.status b/pkg/front_end/testcases/strong.status
index fef6e8a..0b27f74 100644
--- a/pkg/front_end/testcases/strong.status
+++ b/pkg/front_end/testcases/strong.status
@@ -9,6 +9,7 @@
# general/platform_invalid_uris/main: SemiFuzzFailure # semi fuzz fails but isn't currently enabled by default.
extensions/call_methods: TypeCheckError
+extensions/compounds: Crash # assert error
extensions/extension_setter_error: TypeCheckError
extensions/instance_access_of_static: RuntimeError
extensions/invalid_explicit_access: RuntimeError
@@ -172,12 +173,13 @@
nnbd/covariant_late_field: TypeCheckError
nnbd/duplicates_instance_extension: VerificationError
nnbd/getter_vs_setter_type: TypeCheckError
-nnbd/issue41180: RuntimeError # Strong mode runtime checking fails due to mixed strong mode.
nnbd/issue42546: TypeCheckError
nnbd/issue42603: TypeCheckError
nnbd/no_support_for_old_null_aware_index_access_syntax: RuntimeError # Expected.
nnbd/nullable_object_access: TypeCheckError
nnbd/nullable_receiver: TypeCheckError
+nnbd/null_shorting_explicit_extension: Crash # assert error
+nnbd/null_shorting_index: Crash # assert error
nnbd/potentially_nullable_access: TypeCheckError
none/equals: TypeCheckError
none/method_invocation: TypeCheckError
diff --git a/pkg/front_end/testcases/text_serialization.status b/pkg/front_end/testcases/text_serialization.status
index a422b0b..2a84b11 100644
--- a/pkg/front_end/testcases/text_serialization.status
+++ b/pkg/front_end/testcases/text_serialization.status
@@ -7,6 +7,7 @@
# Kernel files are produced by compiling Dart code via Fasta.
extensions/call_methods: TypeCheckError
+extensions/compounds: Crash # assert error
extensions/extension_setter_error: TypeCheckError
extensions/instance_access_of_static: RuntimeError
extensions/invalid_explicit_access: RuntimeError
@@ -172,12 +173,13 @@
nnbd/covariant_late_field: TypeCheckError
nnbd/duplicates_instance_extension: VerificationError
nnbd/getter_vs_setter_type: TypeCheckError
-nnbd/issue41180: RuntimeError
nnbd/issue42546: TypeCheckError
nnbd/issue42603: TypeCheckError
nnbd/no_support_for_old_null_aware_index_access_syntax: RuntimeError # Expected.
nnbd/nullable_object_access: TypeCheckError
nnbd/nullable_receiver: TypeCheckError
+nnbd/null_shorting_explicit_extension: Crash # assert error
+nnbd/null_shorting_index: Crash # assert error
nnbd/potentially_nullable_access: TypeCheckError
none/equals: TypeCheckError
none/method_invocation: TypeCheckError
diff --git a/pkg/front_end/testcases/textual_outline.status b/pkg/front_end/testcases/textual_outline.status
index a6f248c..68e7e6b 100644
--- a/pkg/front_end/testcases/textual_outline.status
+++ b/pkg/front_end/testcases/textual_outline.status
@@ -25,6 +25,16 @@
extensions/issue38600: FormatterCrash
extensions/issue38712: FormatterCrash
extensions/issue38745: FormatterCrash
+general_nnbd_opt_out/annotation_eof: FormatterCrash
+general_nnbd_opt_out/bad_setter_abstract: FormatterCrash
+general_nnbd_opt_out/bug31124: FormatterCrash
+general_nnbd_opt_out/clone_function_type: FormatterCrash
+general_nnbd_opt_out/constructor_initializer_invalid: FormatterCrash
+general_nnbd_opt_out/duplicated_declarations: FormatterCrash
+general_nnbd_opt_out/function_type_default_value: FormatterCrash
+general_nnbd_opt_out/incomplete_field_formal_parameter: FormatterCrash
+general_nnbd_opt_out/many_errors: FormatterCrash
+general_nnbd_opt_out/var_as_type_name: FormatterCrash
general/annotation_eof: FormatterCrash
general/bad_setter_abstract: FormatterCrash
general/bug31124: FormatterCrash
@@ -49,33 +59,24 @@
general/error_recovery/issue_39202.crash: FormatterCrash
general/error_recovery/issue_39230.crash: FormatterCrash
general/error_recovery/issue_39958_01: FormatterCrash
+general/error_recovery/issue_43090.crash: FormatterCrash
general/function_type_default_value: FormatterCrash
general/incomplete_field_formal_parameter: FormatterCrash
-general/invalid_operator2: FormatterCrash
general/invalid_operator: FormatterCrash
+general/invalid_operator2: FormatterCrash
general/issue42997: FormatterCrash
general/issue43363: FormatterCrash
general/many_errors: FormatterCrash
general/null_safety_invalid_experiment_and_language_version: FormatterCrash
general/type_parameters_on_void: FormatterCrash
general/var_as_type_name: FormatterCrash
-general_nnbd_opt_out/annotation_eof: FormatterCrash
-general_nnbd_opt_out/bad_setter_abstract: FormatterCrash
-general_nnbd_opt_out/bug31124: FormatterCrash
-general_nnbd_opt_out/clone_function_type: FormatterCrash
-general_nnbd_opt_out/constructor_initializer_invalid: FormatterCrash
-general_nnbd_opt_out/duplicated_declarations: FormatterCrash
-general_nnbd_opt_out/function_type_default_value: FormatterCrash
-general_nnbd_opt_out/incomplete_field_formal_parameter: FormatterCrash
-general_nnbd_opt_out/many_errors: FormatterCrash
-general_nnbd_opt_out/var_as_type_name: FormatterCrash
inference/unsafe_block_closure_inference_function_call_explicit_dynamic_param_via_expr1: FormatterCrash
inference/unsafe_block_closure_inference_function_call_explicit_type_param_via_expr1: FormatterCrash
late_lowering/covariant_late_field: FormatterCrash
late_lowering/getter_vs_setter_type: FormatterCrash
late_lowering/infer_late_field_type: FormatterCrash
-late_lowering/initializer_rewrite: FormatterCrash
late_lowering/initializer_rewrite_from_opt_out: FormatterCrash
+late_lowering/initializer_rewrite: FormatterCrash
late_lowering/instance_field_with_initializer: FormatterCrash
late_lowering/instance_field_without_initializer: FormatterCrash
late_lowering/instance_final_field_without_initializer: FormatterCrash
@@ -102,20 +103,22 @@
late_lowering/late_nullable_field_without_initializer: FormatterCrash
late_lowering/late_override: FormatterCrash
late_lowering/later: FormatterCrash
-late_lowering/override: FormatterCrash
late_lowering/override_getter_setter: FormatterCrash
+late_lowering/override: FormatterCrash
late_lowering/skip_late_final_uninitialized_instance_fields/main: FormatterCrash
late_lowering/uninitialized_non_nullable_late_fields: FormatterCrash
+nnbd_mixed/inheritance_from_opt_in: FormatterCrash
+nnbd_mixed/issue41597: FormatterCrash
+nnbd_mixed/null_safety_invalid_language_version: FormatterCrash
nnbd/abstract_field_errors: FormatterCrash
nnbd/covariant_late_field: FormatterCrash
-nnbd/duplicates_instance: FormatterCrash
nnbd/duplicates_instance_extension: FormatterCrash
-nnbd/duplicates_static: FormatterCrash
+nnbd/duplicates_instance: FormatterCrash
nnbd/duplicates_static_extension: FormatterCrash
+nnbd/duplicates_static: FormatterCrash
nnbd/field_vs_setter: FormatterCrash
nnbd/forbidden_supers: FormatterCrash
nnbd/getter_vs_setter_type_late: FormatterCrash
-nnbd/inheritance_from_opt_in: FormatterCrash
nnbd/issue40805: FormatterCrash
nnbd/issue41597: FormatterCrash
nnbd/issue42967: FormatterCrash
@@ -124,14 +127,11 @@
nnbd/later: FormatterCrash
nnbd/no_null_shorting_explicit_extension: FormatterCrash
nnbd/no_null_shorting_extension: FormatterCrash
-nnbd/nonfield_vs_setter: FormatterCrash
nnbd/non_nullable_field_initialization: FormatterCrash
+nnbd/nonfield_vs_setter: FormatterCrash
nnbd/opt_out: FormatterCrash
nnbd/potentially_non_nullable_field: FormatterCrash
nnbd/uninitialized_non_nullable_late_fields: FormatterCrash
-nnbd_mixed/inheritance_from_opt_in: FormatterCrash
-nnbd_mixed/issue41597: FormatterCrash
-nnbd_mixed/null_safety_invalid_language_version: FormatterCrash
nonfunction_type_aliases/issue41501: FormatterCrash
rasta/bad_redirection: FormatterCrash
rasta/issue_000032: FormatterCrash
diff --git a/pkg/front_end/testcases/weak.status b/pkg/front_end/testcases/weak.status
index fa279da..663cb4e 100644
--- a/pkg/front_end/testcases/weak.status
+++ b/pkg/front_end/testcases/weak.status
@@ -5,6 +5,7 @@
# Status file for the weak_suite.dart test suite.
extensions/call_methods: TypeCheckError
+extensions/compounds: Crash # assert error
extensions/extension_setter_error: TypeCheckError
extensions/instance_access_of_static: RuntimeError
extensions/invalid_explicit_access: RuntimeError
@@ -64,6 +65,8 @@
nnbd/no_support_for_old_null_aware_index_access_syntax: RuntimeError # Expected.
nnbd/nullable_object_access: TypeCheckError
nnbd/nullable_receiver: TypeCheckError
+nnbd/null_shorting_explicit_extension: Crash # assert error
+nnbd/null_shorting_index: Crash # assert error
nnbd/potentially_nullable_access: TypeCheckError
nnbd_mixed/bad_mixins: TypeCheckError
nnbd_mixed/covariant_from_opt_in: TypeCheckError
@@ -82,6 +85,7 @@
nnbd_mixed/issue41567: TypeCheckError
nnbd_mixed/messages_with_types_opt_in: TypeCheckError
nnbd_mixed/messages_with_types_opt_out: TypeCheckError
+nnbd_mixed/no_null_shorting_explicit_extension: Crash # assert error
none/equals: TypeCheckError
none/method_invocation: TypeCheckError
none/operator: TypeCheckError
diff --git a/pkg/pkg.status b/pkg/pkg.status
index 18c8c4a..825fabe 100644
--- a/pkg/pkg.status
+++ b/pkg/pkg.status
@@ -9,19 +9,6 @@
*/*/*/packages/*/*: Skip
*/*/packages/*/*: Skip
*/packages/*/*: Skip
-analyzer/test/generated/compile_time_error_code_driver_test: Slow, Pass
-analyzer/test/generated/compile_time_error_code_kernel_test: Slow, Pass
-analyzer/test/generated/compile_time_error_code_test: Slow, Pass
-analyzer/test/generated/hint_code_kernel_test: Slow, Pass
-analyzer/test/generated/non_error_resolver_driver_test: Slow, Pass
-analyzer/test/generated/non_error_resolver_kernel_test: Slow, Pass
-analyzer/test/generated/non_hint_code_kernel_test: Slow, Pass
-analyzer/test/generated/static_type_warning_code_kernel_test: Slow, Pass
-analyzer/test/generated/static_warning_code_driver_test: Slow, Pass
-analyzer/test/generated/static_warning_code_kernel_test: Slow, Pass
-analyzer/test/generated/strong_mode_kernel_test: Slow, Pass
-analyzer/test/src/dart/analysis/driver_kernel_test: Slow, Pass
-analyzer/test/src/summary/resynthesize_kernel_test: Slow, Pass
analyzer/test/src/task/strong/checker_test: Slow, Pass
analyzer_plugin/test/plugin/folding_mixin_test: Slow, Pass
compiler/test/analyses/analyze_test: Slow, Pass
@@ -32,20 +19,16 @@
compiler/test/codegen/model_test: Slow, Pass
compiler/test/deferred_loading/deferred_loading_test: Slow, Pass
compiler/test/end_to_end/dump_info_test: Slow, Pass
-compiler/test/equivalence/id_equivalence1_test: Slow, Pass
-compiler/test/equivalence/id_equivalence2_test: Slow, Pass
compiler/test/impact/impact_test: Slow, Pass
compiler/test/inference/inference0_test: Slow, Pass
compiler/test/inference/inference1_test: Slow, Pass
compiler/test/inference/inference2_test: Slow, Pass
compiler/test/inference/inference3_test: Slow, Pass
-compiler/test/inference/swarm_test: Slow, Pass #
compiler/test/inlining/inlining_test: Slow, Pass
compiler/test/model/native_test: Slow, Pass
compiler/test/model/no_such_method_enabled_test: Slow, Pass
compiler/test/model/subtype_test: Slow, Pass
compiler/test/modular/*: Slow, Pass
-compiler/test/nalyses/analyze_test: Slow, Pass
compiler/test/packages/*: SkipByDesign
compiler/test/rti/rti_emission0_test: Slow, Pass
compiler/test/rti/rti_emission1_test: Slow, Pass
@@ -69,30 +52,17 @@
dev_compiler/test/sourcemap/testfiles/*: SkipByDesign # Skip dev_compiler codegen tests
dev_compiler/test/worker/*: Skip # test needs fixes
front_end/test/fasta/analyze_git_test: Pass, Slow
-front_end/test/fasta/ast_builder_test: Pass, Slow
front_end/test/fasta/bootstrap_test: Pass, Slow
-front_end/test/fasta/fast_legacy_test: Pass, Slow
-front_end/test/fasta/fast_strong_test: Pass, Slow
-front_end/test/fasta/legacy_test: Pass, ExtraSlow
-front_end/test/fasta/outline_test: Pass, Slow
front_end/test/fasta/rasta/*: SkipByDesign # Anything in rasta is input to fasta unit tests and shouldn't be run as tests.
front_end/test/fasta/sdk_test: SkipByDesign # sdk_test would take too long to complete, and should be run in a different way.
-front_end/test/fasta/shaker_test: Skip # Issue http://dartbug.com/32531
-front_end/test/fasta/strong1_test: Pass, ExtraSlow
-front_end/test/fasta/strong2_test: Pass, ExtraSlow
-front_end/test/fasta/strong3_test: Pass, ExtraSlow
-front_end/test/fasta/strong4_test: Pass, ExtraSlow
front_end/test/fasta/text_serialization_test: Pass, ExtraSlow
front_end/test/fasta/types/dart2js_benchmark_test: Pass, Slow
front_end/test/fasta/types/large_app_benchmark_test: Pass, ExtraSlow
front_end/test/incremental_compiler_leak_test: Pass, ExtraSlow
front_end/test/incremental_dart2js_test: Pass, Slow
-front_end/test/minimal_incremental_kernel_generator_test: Slow, Pass
front_end/testcases/*: Skip # These are not tests but input for tests.
front_end/tool/incremental_perf_test: Slow, Pass
-kernel/test/closures_test: Slow, Pass
kernel/testcases/*: Skip # These are not tests but input for tests.
-vm/test/frontend_server_test: Slow, Pass
vm/test/transformations/type_flow/transformer_test: Slow, Pass
vm/testcases/*: SkipByDesign # These are not tests but input for tests.
@@ -100,9 +70,6 @@
dev_compiler/test/options/*: SkipByDesign
testing/test/dart_sdk_negative_test: SkipByDesign
-[ $compiler != dart2analyzer ]
-analyzer/test/src/summary/summarize_fasta_test: Slow, Pass
-
[ $compiler == dart2js ]
_fe_analyzer_shared/test/*: SkipByDesign # Only meant to run on vm
analysis_server/test/integration: SkipByDesign # Analysis server integration tests don't make sense to run under dart2js, since the code under test always runs in the Dart vm as a subprocess.
@@ -134,7 +101,6 @@
compiler/test/deferred/load_mapping_test: Slow, Pass
compiler/test/end_to_end/dart2js_batch_test: Slow, Pass
compiler/test/end_to_end/exit_code_test: Slow, Pass
-compiler/test/end_to_end/in_user_code_test: Slow, Pass
vm_snapshot_analysis/test/precompiler_trace_test: SkipSlow
[ $runtime == dart_precompiled ]
@@ -147,26 +113,19 @@
analysis_server/test/integration/*: Slow, Pass
analysis_server/test/services/completion/dart/imported_reference_contributor_test: Slow, Pass
analysis_server/test/services/completion/dart/keyword_contributor_test: Slow, Pass
-analysis_server/test/services/completion/dart/local_constructor_contributor_test: Slow, Pass
analysis_server/test/services/completion/dart/local_reference_contributor_test: Slow, Pass
analysis_server/test/services/completion/dart/type_member_contributor_test: Slow, Pass
-analysis_server/test/services/correction/assist_test: Slow, Pass
analysis_server/test/services/refactoring/extract_method_test: Slow, Pass
analysis_server/test/services/refactoring/inline_method_test: Slow, Pass
analysis_server/test/socket_server_test: Skip # Pass, Slow
analysis_server/test/src/plugin/plugin_manager_test: Slow, Pass
-analyzer/test/generated/hint_code_driver_test: Slow, Pass
-analyzer/test/generated/non_error_resolver_kernel_test: Slow, Pass
analyzer/test/generated/strong_mode_driver_test: Slow, Pass
analyzer/test/src/dart/analysis/driver_resolution_kernel_test: Slow, Pass
analyzer/test/src/dart/analysis/driver_test: Slow, Pass
-analyzer/test/src/summary/resynthesize_ast_test: Slow, Pass
-analyzer/test/src/task/strong/front_end_inference_test: Slow, Pass
analyzer/test/src/task/strong/inferred_type_test: Slow, Pass
analyzer_plugin/test/src/utilities/change_builder/change_builder_dart_test: Slow, Pass
analyzer_plugin/test/src/utilities/completion/optype_test: Slow, Pass
dartdev/test/*: Slow, Pass
-mutation_observer: Skip # Skip tests on the VM if the package depends on dart:html
[ $runtime != vm ]
dds/test/*: SkipByDesign # Only meant to run on vm
@@ -179,8 +138,6 @@
vm_snapshot_analysis/test/*: SkipByDesign # Only meant to run on vm
[ $system == windows ]
-analysis_server/test/integration/analysis/get_errors_nonStandard_sdk_test: Skip
-front_end/test/fasta/ast_builder_test: Pass, Slow, Timeout
front_end/test/fasta/bootstrap_test: Skip # Issue 31902
front_end/test/fasta/strong_test: Pass, Slow, Timeout
front_end/test/fasta/text_serialization_test: Pass, Slow, Timeout
@@ -193,17 +150,14 @@
analysis_server/tool/spec/check_all_test: SkipByDesign # Uses dart:io.
analyzer/test/*: SkipByDesign # Uses dart:io.
analyzer/tool/summary/check_test: SkipByDesign # Uses dart:io.
-analyzer/tool/task_dependency_graph/check_test: SkipByDesign # Uses dart:io.
analyzer_cli/*: SkipByDesign # Uses dart:io.
compiler/tool/*: SkipByDesign # Only meant to run on vm
front_end/tool/*: SkipByDesign # Only meant to run on vm
kernel/test/*: SkipByDesign # Uses dart:io and bigints.
-observe/test/unique_message_test: SkipByDesign # Uses dart:io.
status_file/*: SkipByDesign # Only meant to run on the standalone VM.
testing/test/analyze_test: SkipByDesign
[ $checked ]
-compiler/test/codegen/value_range_kernel_test: Slow, Pass
compiler/test/codegen/value_range_test: Slow, Pass
compiler/test/end_to_end/exit_code_test: Slow, Pass
compiler/test/end_to_end/output_type_test: Slow, Pass
@@ -236,9 +190,6 @@
modular_test/test/specification_parser_test: SkipByDesign
modular_test/test/src/find_sdk_root2_test: SkipByDesign
-[ $compiler == dart2js && $runtime == chrome && $system == macos ]
-third_party/di_tests/di_test: Slow, Pass # Issue 22896
-
[ $compiler == dart2js && $runtime == d8 ]
front_end/test/src/base/uri_resolver_test: SkipByDesign # Relies on access to file system
@@ -252,9 +203,6 @@
[ $compiler == dart2js && $checked ]
crypto/test/base64_test: Slow, Pass
-[ $compiler == dart2js && $csp ]
-mutation_observer: Skip # This test cannot run under CSP because it is injecting a JavaScript polyfill
-
[ $compiler == dart2js && $host_checked ]
js_ast/test/printer_callback_test: Slow, Pass
js_ast/test/string_escape_test: Slow, Pass
@@ -275,11 +223,7 @@
[ $runtime == vm && $checked ]
analysis_server/test/completion_test: Slow, Pass
analysis_server/test/integration/edit/sort_members_test: Slow, Pass
-analysis_server/test/services/correction/fix_test: Slow, Pass
analysis_server/test/socket_server_test: Skip # Pass, Slow
-analyzer/test/generated/non_error_resolver_kernel_test: Slow, Pass
-analyzer/test/src/summary/resynthesize_ast_test: Slow, Pass
-analyzer/test/src/task/strong/front_end_inference_test: Slow, Pass
# Timeout. These tests do not run efficiently on our simulator or low-end
# devices.
@@ -293,8 +237,5 @@
front_end/test/fasta/*: Skip
front_end/tool/_fasta/*: Skip
-[ $mode != release || $runtime != vm || $system == windows ]
-kernel/test/closures_test: Skip
-
[ $runtime == chrome || $runtime == ff || $runtime == firefox || $runtime == safari || $jscl ]
compiler/test/*: Skip # dart2js uses #import('dart:io'); and it is not self-hosted (yet).
diff --git a/runtime/observatory/analysis_options.yaml b/runtime/observatory/analysis_options.yaml
index e579874..7259783 100644
--- a/runtime/observatory/analysis_options.yaml
+++ b/runtime/observatory/analysis_options.yaml
@@ -10,7 +10,6 @@
- tests/service/complex_reload/v2/main.dart
- tests/service/developer_extension_test.dart
- tests/service/evaluate_activation_in_method_class_test.dart
- - tests/service/get_isolate_after_language_error_test.dart
- tests/service/get_user_level_retaining_path_rpc_test.dart
- tests/service/pause_on_unhandled_async_exceptions_test.dart
diff --git a/runtime/observatory/tests/service/service.status b/runtime/observatory/tests/service/service.status
index 5896d37..62efb1a 100644
--- a/runtime/observatory/tests/service/service.status
+++ b/runtime/observatory/tests/service/service.status
@@ -21,7 +21,6 @@
# Tests with known analyzer issues
[ $compiler == dart2analyzer ]
developer_extension_test: SkipByDesign
-get_isolate_after_language_error_test: SkipByDesign
# The _1 versions of this test can be slow due to stress testing flags.
[ $mode == debug ]
diff --git a/runtime/observatory/tests/service/service_kernel.status b/runtime/observatory/tests/service/service_kernel.status
index 0be2c2e5..aa164a1 100644
--- a/runtime/observatory/tests/service/service_kernel.status
+++ b/runtime/observatory/tests/service/service_kernel.status
@@ -87,7 +87,6 @@
debugging_inlined_finally_test: SkipByDesign # Debugger is disabled in AOT mode.
debugging_test: SkipByDesign # Debugger is disabled in AOT mode.
deferred_import_reload_test: SkipByDesign # Hot reload is disabled in AOT mode.
-dev_fs_spawn_test: SkipByDesign # Debugger is disabled in AOT mode.
developer_extension_test: SkipByDesign # Debugger is disabled in AOT mode.
developer_service_get_isolate_id_test: SkipByDesign # Debugger is disabled in AOT mode.
eval_internal_class_test: SkipByDesign # Debugger is disabled in AOT mode.
@@ -107,7 +106,6 @@
evaluate_with_scope_test: SkipByDesign # Debugger is disabled in AOT mode.
field_script_test: SkipByDesign # Debugger is disabled in AOT mode.
get_allocation_samples_test: SkipByDesign # Debugger is disabled in AOT mode.
-get_isolate_after_language_error_test: CompileTimeError
get_object_rpc_test: SkipByDesign # Debugger is disabled in AOT mode.
get_source_report_const_coverage_test: SkipByDesign # Debugger is disabled in AOT mode.
get_source_report_test: SkipByDesign # Debugger is disabled in AOT mode.
@@ -195,9 +193,6 @@
weak_properties_test: CompileTimeError
yield_positions_with_finally_test: SkipByDesign # Debugger is disabled in AOT mode.
-[ $fasta ]
-get_isolate_after_language_error_test: CompileTimeError
-
[ $arch == arm64 && $compiler == dartk ]
coverage_optimized_function_test: Pass, Slow
diff --git a/runtime/observatory_2/analysis_options.yaml b/runtime/observatory_2/analysis_options.yaml
index 6babf28..3a0de1f 100644
--- a/runtime/observatory_2/analysis_options.yaml
+++ b/runtime/observatory_2/analysis_options.yaml
@@ -7,7 +7,6 @@
- tests/service/complex_reload/v2/main.dart
- tests/service/developer_extension_test.dart
- tests/service/evaluate_activation_in_method_class_test.dart
- - tests/service/get_isolate_after_language_error_test.dart
- tests/service/get_user_level_retaining_path_rpc_test.dart
- tests/service/pause_on_unhandled_async_exceptions_test.dart
diff --git a/runtime/observatory_2/tests/service_2/service_2.status b/runtime/observatory_2/tests/service_2/service_2.status
index 874b3f4..ea6eaa1 100644
--- a/runtime/observatory_2/tests/service_2/service_2.status
+++ b/runtime/observatory_2/tests/service_2/service_2.status
@@ -23,7 +23,6 @@
# Tests with known analyzer issues
[ $compiler == dart2analyzer ]
developer_extension_test: SkipByDesign
-get_isolate_after_language_error_test: SkipByDesign
# The _1 versions of this test can be slow due to stress testing flags.
[ $mode == debug ]
diff --git a/runtime/observatory_2/tests/service_2/service_2_kernel.status b/runtime/observatory_2/tests/service_2/service_2_kernel.status
index fda49e7..092bab9 100644
--- a/runtime/observatory_2/tests/service_2/service_2_kernel.status
+++ b/runtime/observatory_2/tests/service_2/service_2_kernel.status
@@ -87,7 +87,6 @@
debugging_inlined_finally_test: SkipByDesign # Debugger is disabled in AOT mode.
debugging_test: SkipByDesign # Debugger is disabled in AOT mode.
deferred_import_reload_test: SkipByDesign # Hot reload is disabled in AOT mode.
-dev_fs_spawn_test: SkipByDesign # Debugger is disabled in AOT mode.
developer_extension_test: SkipByDesign # Debugger is disabled in AOT mode.
developer_service_get_isolate_id_test: SkipByDesign # Debugger is disabled in AOT mode.
eval_internal_class_test: SkipByDesign # Debugger is disabled in AOT mode.
@@ -107,7 +106,6 @@
evaluate_with_scope_test: SkipByDesign # Debugger is disabled in AOT mode.
field_script_test: SkipByDesign # Debugger is disabled in AOT mode.
get_allocation_samples_test: SkipByDesign # Debugger is disabled in AOT mode.
-get_isolate_after_language_error_test: CompileTimeError
get_object_rpc_test: SkipByDesign # Debugger is disabled in AOT mode.
get_source_report_const_coverage_test: SkipByDesign # Debugger is disabled in AOT mode.
get_source_report_test: SkipByDesign # Debugger is disabled in AOT mode.
@@ -194,9 +192,6 @@
weak_properties_test: CompileTimeError
yield_positions_with_finally_test: SkipByDesign # Debugger is disabled in AOT mode.
-[ $fasta ]
-get_isolate_after_language_error_test: CompileTimeError
-
[ $arch == arm64 && $compiler == dartk ]
coverage_optimized_function_test: Pass, Slow
diff --git a/runtime/tests/vm/vm.status b/runtime/tests/vm/vm.status
index 4b8f66d..44a7888 100644
--- a/runtime/tests/vm/vm.status
+++ b/runtime/tests/vm/vm.status
@@ -35,13 +35,8 @@
dart_2/transferable_throws_oom_test: SkipByDesign # This test tries to allocate too much memory on purpose. Still dartbug.com/37188
[ $builder_tag == obfuscated ]
-dart/causal_stacks/async_throws_stack_lazy_test: SkipByDesign # Asserts exact stacktrace output.
-dart/causal_stacks/async_throws_stack_no_causal_test: SkipByDesign # Asserts exact stacktrace output.
-dart/causal_stacks/async_throws_stack_test: SkipByDesign # Asserts exact stacktrace output.
-dart/causal_stacks/sync_async_start_pkg_test_test: SkipByDesign # Asserts exact stacktrace output.
dart_2/causal_stacks/async_throws_stack_lazy_test: SkipByDesign # Asserts exact stacktrace output.
dart_2/causal_stacks/async_throws_stack_no_causal_test: SkipByDesign # Asserts exact stacktrace output.
-dart_2/causal_stacks/async_throws_stack_test: SkipByDesign # Asserts exact stacktrace output.
dart_2/causal_stacks/sync_async_start_pkg_test_test: SkipByDesign # Asserts exact stacktrace output.
[ $builder_tag == optimization_counter_threshold ]
@@ -94,14 +89,10 @@
[ $compiler == dartkp ]
dart/causal_stacks/async_throws_stack_no_causal_non_symbolic_test: SkipByDesign # --no-lazy... does nothing on precompiler.
dart/causal_stacks/async_throws_stack_no_causal_test: SkipByDesign # --no-lazy... does nothing on precompiler.
-dart/causal_stacks/async_throws_stack_non_symbolic_test: SkipByDesign # --no-lazy... does nothing on precompiler.
-dart/causal_stacks/async_throws_stack_test: SkipByDesign # --no-lazy... does nothing on precompiler.
dart/scavenger_abort_test: SkipSlow
dart/v8_snapshot_profile_writer_test: Pass, Slow # Can be slow due to re-invoking the precompiler.
dart_2/causal_stacks/async_throws_stack_no_causal_non_symbolic_test: SkipByDesign # --no-lazy... does nothing on precompiler.
dart_2/causal_stacks/async_throws_stack_no_causal_test: SkipByDesign # --no-lazy... does nothing on precompiler.
-dart_2/causal_stacks/async_throws_stack_non_symbolic_test: SkipByDesign # --no-lazy... does nothing on precompiler.
-dart_2/causal_stacks/async_throws_stack_test: SkipByDesign # --no-lazy... does nothing on precompiler.
dart_2/scavenger_abort_test: SkipSlow
dart_2/v8_snapshot_profile_writer_test: Pass, Slow # Can be slow due to re-invoking the precompiler.
diff --git a/tests/language/language.status b/tests/language/language.status
index 5739de1..02f2ef4 100644
--- a/tests/language/language.status
+++ b/tests/language/language.status
@@ -33,7 +33,6 @@
parameter/named_type_test/03: SkipByDesign # Requires checked mode.
parameter/positional_type_test/01: SkipByDesign # Requires checked mode.
parameter/positional_type_test/02: SkipByDesign # Requires checked mode.
-regress/regress13474_test: SkipByDesign # Requires checked mode.
regress/regress29784_test/02: SkipByDesign # Requires checked mode.
stack_trace/demangle_ctors_test: SkipByDesign # Names are not scrubbed.
type/checks_in_factory_method_test: SkipByDesign # Requires checked mode.
diff --git a/tests/language/language_dart2js.status b/tests/language/language_dart2js.status
index dbac77c..aaaf533 100644
--- a/tests/language/language_dart2js.status
+++ b/tests/language/language_dart2js.status
@@ -20,7 +20,6 @@
[ $compiler == dart2js && $runtime == d8 ]
import/conditional_string_test: SkipByDesign # No XHR in d8
-import/conditional_test: SkipByDesign # No XHR in d8
[ $compiler == dart2js && $runtime == jsshell ]
await/for_test: Skip # Jsshell does not provide periodic timers, Issue 7728
diff --git a/tests/language/language_kernel.status b/tests/language/language_kernel.status
index c3aae5e..71b36a0 100644
--- a/tests/language/language_kernel.status
+++ b/tests/language/language_kernel.status
@@ -200,7 +200,6 @@
nnbd/syntax/class_member_declarations_test/none: Skip # Issue 39823
nnbd/syntax/nullable_type_test: Skip # Issue 39820
nnbd/syntax/opt_out_nnbd_modifiers_test: Skip # Issue 37957
-nnbd/syntax/pre_nnbd_modifiers_test: Skip # Issue 37957
[ $builder_tag == obfuscated && $compiler == dartkp ]
generic/function_dcall_test/01: SkipByDesign # Prints type names
@@ -209,14 +208,12 @@
mixin/mixin5_test: SkipByDesign # Prints type names
mixin/mixin6_test: SkipByDesign # Prints type names
mixin/mixin_bound2_test: SkipByDesign # Prints type names
-type_object/literal_test: SkipByDesign # Uses lots of strings with type names in them
unsorted/many_named_arguments_test: SkipByDesign # Checks names of arguments
unsorted/symbol_literal_test/02: SkipByDesign # We don't obfuscate const Symbol constructor
vm/bool_check_stack_traces_test: SkipByDesign # Looks for filenames in stacktrace output
vm/no_such_args_error_message_vm_test: SkipByDesign # Looks for function name in error message
vm/no_such_method_error_message_callable_vm_test: SkipByDesign # Expects unobfuscated method names
vm/no_such_method_error_message_vm_test: SkipByDesign # Looks for unobfuscated name in error message
-vm/regress_28325_test: SkipByDesign # Looks for filename in stack trace
[ $compiler == dartk && $mode == debug && $hot_reload ]
async_star/async_star2_test/01: Crash
@@ -226,7 +223,6 @@
enum/duplicate_test/02: Crash # Issue 34606
enum/duplicate_test/none: Crash # Issue 34606
enum/private_test/01: Crash # Issue 34606
-enum/test: Crash # Issue 34606
unsorted/inference_enum_list_test: Skip # Issue 35885
[ $compiler == dartk && $mode == product && $runtime == vm ]
@@ -262,36 +258,23 @@
# ==== dartkp + dart_precompiled status lines ====
[ $compiler == dartkp && $runtime == dart_precompiled ]
assert/with_type_test_or_cast_test: Crash
-closure/implicit_test: Skip # Incompatible flag: --use_slow_path
const/const2_test: Skip # Incompatible flag: --compile_all
const/evaluation_test: SkipByDesign
deferred/redirecting_factory_test: Crash # Issue 23408, KernelVM bug: Deferred loading kernel issue 30273.
-enum/mirror_test: SkipByDesign
export/ambiguous_main_test: Skip # Issue 29895 Fail Issue 14763
export/double_same_main_test: Skip # Issue 29895 Crash Issue 29895
field/increment_bailout_test: SkipByDesign
generic_methods_recursive_bound_test/03: Crash
-instance/creation_in_function_annotation_test: SkipByDesign
main/no_main_test/01: Skip
main/not_a_function_test: Skip
mixin/illegal_super_use_test: Skip # Issues 24478 and 23773
mixin/illegal_superclass_test: Skip # Issues 24478 and 23773
no_such_method/many_overridden_test.dart: SkipByDesign
-no_such_method/overridden_test: SkipByDesign
-no_such_method/test: SkipByDesign
null_test/mirrors: Skip # Uses mirrors.
null_test/none: SkipByDesign
optimize/deopt_inlined_function_lazy_test: Skip # Incompatible flag: --deoptimize-alot
-redirecting/factory_reflection_test: SkipByDesign
-regress/regress13462_0_test: SkipByDesign
-regress/regress13462_1_test: SkipByDesign
-regress/regress18535_test: SkipByDesign
-regress/regress21079_test: SkipByDesign
-regress/regress28255_test: SkipByDesign
unsorted/hello_dart_test: Skip # Incompatible flag: --compile_all
unsorted/invocation_mirror2_test: SkipByDesign
-unsorted/invocation_mirror_invoke_on2_test: SkipByDesign
-unsorted/invocation_mirror_invoke_on_test: SkipByDesign
vm/causal_async_exception_stack2_test: SkipByDesign
vm/causal_async_exception_stack_test: SkipByDesign
vm/closure_memory_retention_test: Skip # KernelVM bug: Hits OOM
diff --git a/tests/language/language_precompiled.status b/tests/language/language_precompiled.status
index 3100f76..4850aa0 100644
--- a/tests/language/language_precompiled.status
+++ b/tests/language/language_precompiled.status
@@ -37,7 +37,6 @@
vm/no_such_args_error_message_vm_test: Skip
vm/no_such_method_error_message_callable_vm_test: Skip
vm/no_such_method_error_message_vm_test: Skip
-vm/regress_28325_test: Skip
[ $runtime == dart_precompiled && ($mode == product || $minified) ]
stack_trace/rethrow_error_test: SkipByDesign # obfuscation/minification and instruction deduplication cause names of frames to be mangled (expected)
diff --git a/tests/language/language_spec_parser.status b/tests/language/language_spec_parser.status
index 6b5318d..a6af39f 100644
--- a/tests/language/language_spec_parser.status
+++ b/tests/language/language_spec_parser.status
@@ -7,9 +7,7 @@
closure/type_test: Pass # Marked as RuntimeError for all in language_2.status.
const/native_factory_test: Skip # Uses `native`.
double/invalid_test: Skip # Contains illegaly formatted double.
-identifier/built_in_prefix_test: Skip # A built-in identifier can _not_ be a prefix.
nnbd/syntax/opt_out_nnbd_modifiers_test: Skip # Requires opt-out of NNBD.
-nnbd/syntax/pre_nnbd_modifiers_test: Skip # Requires opt-out of NNBD.
regress/regress1751477_test: Skip # Times out: 9 levels, exponential blowup => 430 secs.
syntax/deep_nesting_expression_test: Skip # JVM stack overflow.
syntax/deep_nesting_statement_test: Skip # JVM stack overflow.
diff --git a/tests/language_2/language_2.status b/tests/language_2/language_2.status
index 4322081..536cc7a 100644
--- a/tests/language_2/language_2.status
+++ b/tests/language_2/language_2.status
@@ -27,7 +27,6 @@
parameter/named_type_test/03: SkipByDesign # Requires checked mode.
parameter/positional_type_test/01: SkipByDesign # Requires checked mode.
parameter/positional_type_test/02: SkipByDesign # Requires checked mode.
-regress/regress13474_test: SkipByDesign # Requires checked mode.
regress/regress29784_test/02: SkipByDesign # Requires checked mode.
stack_trace/demangle_ctors_test: SkipByDesign # Names are not scrubbed.
type/checks_in_factory_method_test: SkipByDesign # Requires checked mode.
diff --git a/tests/language_2/language_2_dart2js.status b/tests/language_2/language_2_dart2js.status
index dbac77c..aaaf533 100644
--- a/tests/language_2/language_2_dart2js.status
+++ b/tests/language_2/language_2_dart2js.status
@@ -20,7 +20,6 @@
[ $compiler == dart2js && $runtime == d8 ]
import/conditional_string_test: SkipByDesign # No XHR in d8
-import/conditional_test: SkipByDesign # No XHR in d8
[ $compiler == dart2js && $runtime == jsshell ]
await/for_test: Skip # Jsshell does not provide periodic timers, Issue 7728
diff --git a/tests/language_2/language_2_kernel.status b/tests/language_2/language_2_kernel.status
index 8c0d481..914a376 100644
--- a/tests/language_2/language_2_kernel.status
+++ b/tests/language_2/language_2_kernel.status
@@ -14,9 +14,6 @@
[ $compiler == fasta ]
number/web_int_literals_test/*: SkipByDesign # Test applies only to JavaScript targets
-[ ($hot_reload || $hot_reload_rollback) && $mode == debug ]
-regress/regress41983_test: Pass, Slow
-
[ $fasta ]
nnbd/*: Skip
superinterface_variance/mixin_error_test/37: Crash # Issue dart-lang/language#113
@@ -37,54 +34,63 @@
mixin/mixin5_test: SkipByDesign # Prints type names
mixin/mixin6_test: SkipByDesign # Prints type names
mixin/mixin_bound2_test: SkipByDesign # Prints type names
-type_object/literal_test: SkipByDesign # Uses lots of strings with type names in them
unsorted/many_named_arguments_test: SkipByDesign # Checks names of arguments
unsorted/symbol_literal_test/02: SkipByDesign # We don't obfuscate const Symbol constructor
vm/bool_check_stack_traces_test: SkipByDesign # Looks for filenames in stacktrace output
vm/no_such_args_error_message_vm_test: SkipByDesign # Looks for function name in error message
vm/no_such_method_error_message_callable_vm_test: SkipByDesign # Expects unobfuscated method names
vm/no_such_method_error_message_vm_test: SkipByDesign # Looks for unobfuscated name in error message
-vm/regress_28325_test: SkipByDesign # Looks for filename in stack trace
[ $compiler == dartk && $mode == debug && ($hot_reload || $hot_reload_rollback) ]
+enum/duplicate_test/02: Crash # Issue 34606
+enum/duplicate_test/none: Crash # Issue 34606
+enum/private_test/01: Crash # Issue 34606
unsorted/inference_enum_list_test: Skip # Issue 35885
+[ $compiler == dartk && $mode == product && $runtime == vm ]
+vm/causal_async_exception_stack2_test: SkipByDesign
+vm/causal_async_exception_stack_test: SkipByDesign
+
+# ===== dartk + vm status lines =====
+[ $compiler == dartk && $runtime == vm ]
+const/const2_test: Crash # Flaky
+main/no_main_test/01: Skip
+mixin/illegal_super_use_test: Skip # Issues 24478 and 23773
+mixin/illegal_superclass_test: Skip # Issues 24478 and 23773
+unsorted/disassemble_test: Slow, Crash # dartbug.com/34971
+vm/closure_memory_retention_test: Skip # KernelVM bug: Hits OOM
+vm/regress_29145_test: Skip # Issue 29145
+web_int_literals_test/*: SkipByDesign # Test applies only to JavaScript targets
+
+[ $compiler == dartk && $hot_reload_rollback ]
+symbol/conflict_test: Slow, Pass
+
+[ $compiler == dartk && ($hot_reload || $hot_reload_rollback) ]
+type_constants_test/none: Skip # Deferred libraries and hot reload.
+
[ $compiler == dartkp && $mode == debug && $runtime == dart_precompiled ]
vm/precompiled_static_initializer_test: Slow, Pass
# ==== dartkp + dart_precompiled status lines ====
[ $compiler == dartkp && $runtime == dart_precompiled ]
assert/with_type_test_or_cast_test: Crash
-closure/implicit_test: Skip # Incompatible flag: --use_slow_path
const/const2_test: Skip # Incompatible flag: --compile_all
const/evaluation_test: SkipByDesign
deferred/redirecting_factory_test: Crash # Issue 23408, KernelVM bug: Deferred loading kernel issue 30273.
-enum/mirror_test: SkipByDesign
export/ambiguous_main_test: Skip # Issue 29895 Fail Issue 14763
export/double_same_main_test: Skip # Issue 29895 Crash Issue 29895
field/increment_bailout_test: SkipByDesign
generic_methods_recursive_bound_test/03: Crash
-instance/creation_in_function_annotation_test: SkipByDesign
main/no_main_test/01: Skip
main/not_a_function_test: Skip
mixin/illegal_super_use_test: Skip # Issues 24478 and 23773
mixin/illegal_superclass_test: Skip # Issues 24478 and 23773
no_such_method/many_overridden_test.dart: SkipByDesign
-no_such_method/overridden_test: SkipByDesign
-no_such_method/test: SkipByDesign
null_test/mirrors: Skip # Uses mirrors.
null_test/none: SkipByDesign
optimize/deopt_inlined_function_lazy_test: Skip # Incompatible flag: --deoptimize-alot
-redirecting/factory_reflection_test: SkipByDesign
-regress/regress13462_0_test: SkipByDesign
-regress/regress13462_1_test: SkipByDesign
-regress/regress18535_test: SkipByDesign
-regress/regress21079_test: SkipByDesign
-regress/regress28255_test: SkipByDesign
unsorted/hello_dart_test: Skip # Incompatible flag: --compile_all
unsorted/invocation_mirror2_test: SkipByDesign
-unsorted/invocation_mirror_invoke_on2_test: SkipByDesign
-unsorted/invocation_mirror_invoke_on_test: SkipByDesign
vm/causal_async_exception_stack2_test: SkipByDesign
vm/causal_async_exception_stack_test: SkipByDesign
vm/closure_memory_retention_test: Skip # KernelVM bug: Hits OOM
@@ -111,29 +117,5 @@
[ $mode == debug && $runtime == vm && ($compiler == app_jitk || $compiler == dartk) ]
optimize/deopt_inlined_function_lazy_test: Skip
-[ $mode == debug && ($compiler == dartk) && ($hot_reload || $hot_reload_rollback) ]
-enum/duplicate_test/02: Crash # Issue 34606
-enum/duplicate_test/none: Crash # Issue 34606
-enum/private_test/01: Crash # Issue 34606
-enum/test: Crash # Issue 34606
-
-[ $mode == product && $runtime == vm && ($compiler == dartk) ]
-vm/causal_async_exception_stack2_test: SkipByDesign
-vm/causal_async_exception_stack_test: SkipByDesign
-
-# ===== dartk + vm status lines =====
-[ $runtime == vm && ($compiler == dartk) ]
-const/const2_test: Crash # Flaky
-main/no_main_test/01: Skip
-mixin/illegal_super_use_test: Skip # Issues 24478 and 23773
-mixin/illegal_superclass_test: Skip # Issues 24478 and 23773
-unsorted/disassemble_test: Slow, Crash # dartbug.com/34971
-vm/closure_memory_retention_test: Skip # KernelVM bug: Hits OOM
-vm/regress_29145_test: Skip # Issue 29145
-web_int_literals_test/*: SkipByDesign # Test applies only to JavaScript targets
-
-[ $hot_reload_rollback && ($compiler == dartk) ]
-symbol/conflict_test: Slow, Pass
-
-[ ($compiler == dartk) && ($hot_reload || $hot_reload_rollback) ]
-type_constants_test/none: Skip # Deferred libraries and hot reload.
+[ $mode == debug && ($hot_reload || $hot_reload_rollback) ]
+regress/regress41983_test: Pass, Slow
diff --git a/tests/language_2/language_2_precompiled.status b/tests/language_2/language_2_precompiled.status
index 3100f76..4850aa0 100644
--- a/tests/language_2/language_2_precompiled.status
+++ b/tests/language_2/language_2_precompiled.status
@@ -37,7 +37,6 @@
vm/no_such_args_error_message_vm_test: Skip
vm/no_such_method_error_message_callable_vm_test: Skip
vm/no_such_method_error_message_vm_test: Skip
-vm/regress_28325_test: Skip
[ $runtime == dart_precompiled && ($mode == product || $minified) ]
stack_trace/rethrow_error_test: SkipByDesign # obfuscation/minification and instruction deduplication cause names of frames to be mangled (expected)
diff --git a/tests/language_2/language_2_spec_parser.status b/tests/language_2/language_2_spec_parser.status
index 6b5318d..a6af39f 100644
--- a/tests/language_2/language_2_spec_parser.status
+++ b/tests/language_2/language_2_spec_parser.status
@@ -7,9 +7,7 @@
closure/type_test: Pass # Marked as RuntimeError for all in language_2.status.
const/native_factory_test: Skip # Uses `native`.
double/invalid_test: Skip # Contains illegaly formatted double.
-identifier/built_in_prefix_test: Skip # A built-in identifier can _not_ be a prefix.
nnbd/syntax/opt_out_nnbd_modifiers_test: Skip # Requires opt-out of NNBD.
-nnbd/syntax/pre_nnbd_modifiers_test: Skip # Requires opt-out of NNBD.
regress/regress1751477_test: Skip # Times out: 9 levels, exponential blowup => 430 secs.
syntax/deep_nesting_expression_test: Skip # JVM stack overflow.
syntax/deep_nesting_statement_test: Skip # JVM stack overflow.
diff --git a/tests/lib/lib.status b/tests/lib/lib.status
index 6cc876f..3d14826 100644
--- a/tests/lib/lib.status
+++ b/tests/lib/lib.status
@@ -44,9 +44,6 @@
[ $compiler != dart2js && $compiler != dartdevk ]
web/*: SkipByDesign
-[ $runtime == chrome && $system == linux ]
-mirrors/native_class_test: Slow, Pass
-
[ $runtime == chrome && $system == macos ]
convert/streamed_conversion_utf8_encode_test: SkipSlow # Times out. Issue 22050
html/canvasrendering/arc_test: Skip # Issue 42048
@@ -66,9 +63,6 @@
[ $arch != x64 || $runtime != vm ]
isolate/int32_length_overflow_test: SkipSlow
-[ $mode == product || $runtime != vm ]
-isolate/checked_test: Skip # Unsupported.
-
[ $runtime == chrome || $runtime == ff ]
async/slow_consumer2_test: SkipSlow # Times out. Issue 22050
async/stream_timeout_test: SkipSlow # Times out. Issue 22050
diff --git a/tests/lib/lib_dart2js.status b/tests/lib/lib_dart2js.status
index d66a2c8..7478db8 100644
--- a/tests/lib/lib_dart2js.status
+++ b/tests/lib/lib_dart2js.status
@@ -12,12 +12,8 @@
html/custom/document_register_type_extensions_test/construction: Slow, Pass
html/custom/document_register_type_extensions_test/registration: Slow, Pass
html/custom/entered_left_view/shadow_dom_test: Slow, Pass
-html/custom/js_custom_test: Skip # mirrors not supported, delete this test.
-html/custom/mirrors_2_test: Skip # mirrors not supported, delete this test.
-html/custom/mirrors_test: Skip # mirrors not supported, delete this test.
html/custom_elements_test: Slow, Pass # Issue 26789
html/isolates_test: SkipByDesign
-html/mirrors_js_typed_interop_test: Skip # mirrors not supported, delete this test.
html/worker_api_test: SkipByDesign
html/wrapping_collections_test: SkipByDesign # Testing an issue that is only relevant to Dartium
html/xhr_test: Slow, Pass
@@ -37,7 +33,6 @@
convert/streamed_conversion_utf8_decode_test: SkipSlow # Times out. Issue 22050
[ $compiler == dart2js && $runtime == chromeOnAndroid ]
-html/crypto_test/functional: Slow, Pass # TODO(dart2js-team): Please triage this failure.
html/input_element_datetime_test: Slow, Pass # TODO(dart2js-team): Please triage this failure.
[ $compiler == dart2js && $runtime == d8 ]
@@ -89,7 +84,6 @@
html/js_typed_interop_type_test: SkipByDesign
html/js_typed_interop_window_property_test: SkipByDesign
html/js_util_test: SkipByDesign
-html/mirrors_js_typed_interop_test: SkipByDesign
html/postmessage_structured_test: SkipByDesign
[ $compiler == dart2js && ($runtime == chrome || $runtime == ff) ]
diff --git a/tests/lib/lib_dartdevc.status b/tests/lib/lib_dartdevc.status
index cfdf3fa..a8a3790 100644
--- a/tests/lib/lib_dartdevc.status
+++ b/tests/lib/lib_dartdevc.status
@@ -25,14 +25,12 @@
developer/metrics_num_test: Skip # Because of an int / double type test.
html/callback_list_test: Skip # Test requires user interaction to accept permissions.
html/custom/attribute_changed_callback_test: Skip # Issue 31577
-html/custom/constructor_calls_created_synchronously_test: Skip # Issue 31577
html/custom/created_callback_test: Skip # Issue 31577
html/custom/document_register_basic_test: Skip # Issue 31577
html/custom/document_register_template_test: Skip # Issue 31577
html/custom/document_register_type_extensions_test: Skip # Issue 31577
html/custom/element_upgrade_test: Skip # Issue 31577
html/custom/entered_left_view/*: Skip # Issue 31577
-html/custom/mirrors_2_test: Skip # Issue 31577
html/custom_element_method_clash_test: Skip # Issue 29922
html/custom_element_name_clash_test: Skip # Issue 29922
html/custom_elements_23127_test: Skip # Issue 29922
diff --git a/tests/lib/lib_kernel.status b/tests/lib/lib_kernel.status
index 03ac748..20fb8dc 100644
--- a/tests/lib/lib_kernel.status
+++ b/tests/lib/lib_kernel.status
@@ -41,7 +41,6 @@
isolate/static_function_test: Skip # Times out. Issue 31855. CompileTimeError. Issue 31402
mirrors/invocation_fuzz_test: Crash
mirrors/metadata_allowed_values_test/16: Skip # Flaky, crashes.
-mirrors/native_class_test: SkipByDesign # Imports dart:html
[ $compiler == dartk && $hot_reload_rollback ]
isolate/illegal_msg_function_test: Skip # Timeout
diff --git a/tests/lib_2/lib_2.status b/tests/lib_2/lib_2.status
index 888c0d1..a5af78e 100644
--- a/tests/lib_2/lib_2.status
+++ b/tests/lib_2/lib_2.status
@@ -44,9 +44,6 @@
[ $compiler != dart2js && $compiler != dartdevk ]
web/*: SkipByDesign
-[ $runtime == chrome && $system == linux ]
-mirrors/native_class_test: Slow, Pass
-
[ $runtime == chrome && $system == macos ]
convert/streamed_conversion_utf8_encode_test: SkipSlow # Times out. Issue 22050
html/canvasrendering/arc_test: Skip # Issue 42048
@@ -66,9 +63,6 @@
[ $arch != x64 || $runtime != vm ]
isolate/int32_length_overflow_test: SkipSlow
-[ $mode == product || $runtime != vm ]
-isolate/checked_test: Skip # Unsupported.
-
[ $runtime == chrome || $runtime == ff ]
async/slow_consumer2_test: SkipSlow # Times out. Issue 22050
async/stream_timeout_test: SkipSlow # Times out. Issue 22050
diff --git a/tests/lib_2/lib_2_dart2js.status b/tests/lib_2/lib_2_dart2js.status
index 14a0a1a..2db76f5 100644
--- a/tests/lib_2/lib_2_dart2js.status
+++ b/tests/lib_2/lib_2_dart2js.status
@@ -12,12 +12,8 @@
html/custom/document_register_type_extensions_test/construction: Slow, Pass
html/custom/document_register_type_extensions_test/registration: Slow, Pass
html/custom/entered_left_view/shadow_dom_test: Slow, Pass
-html/custom/js_custom_test: Skip # mirrors not supported, delete this test.
-html/custom/mirrors_2_test: Skip # mirrors not supported, delete this test.
-html/custom/mirrors_test: Skip # mirrors not supported, delete this test.
html/custom_elements_test: Slow, Pass # Issue 26789
html/isolates_test: SkipByDesign
-html/mirrors_js_typed_interop_test: Skip # mirrors not supported, delete this test.
html/worker_api_test: SkipByDesign
html/wrapping_collections_test: SkipByDesign # Testing an issue that is only relevant to Dartium
html/xhr_test: Slow, Pass
@@ -35,7 +31,6 @@
convert/streamed_conversion_utf8_decode_test: SkipSlow # Times out. Issue 22050
[ $compiler == dart2js && $runtime == chromeOnAndroid ]
-html/crypto_test/functional: Slow, Pass # TODO(dart2js-team): Please triage this failure.
html/input_element_datetime_test: Slow, Pass # TODO(dart2js-team): Please triage this failure.
[ $compiler == dart2js && $runtime == d8 ]
@@ -87,7 +82,6 @@
html/js_typed_interop_type_test: SkipByDesign
html/js_typed_interop_window_property_test: SkipByDesign
html/js_util_test: SkipByDesign
-html/mirrors_js_typed_interop_test: SkipByDesign
html/postmessage_structured_test: SkipByDesign
[ $compiler == dart2js && ($runtime == chrome || $runtime == ff) ]
diff --git a/tests/lib_2/lib_2_dartdevc.status b/tests/lib_2/lib_2_dartdevc.status
index 5e435c6..d6a6dd7 100644
--- a/tests/lib_2/lib_2_dartdevc.status
+++ b/tests/lib_2/lib_2_dartdevc.status
@@ -25,14 +25,12 @@
developer/metrics_num_test: Skip # Because of an int / double type test.
html/callback_list_test: Skip # Test requires user interaction to accept permissions.
html/custom/attribute_changed_callback_test: Skip # Issue 31577
-html/custom/constructor_calls_created_synchronously_test: Skip # Issue 31577
html/custom/created_callback_test: Skip # Issue 31577
html/custom/document_register_basic_test: Skip # Issue 31577
html/custom/document_register_template_test: Skip # Issue 31577
html/custom/document_register_type_extensions_test: Skip # Issue 31577
html/custom/element_upgrade_test: Skip # Issue 31577
html/custom/entered_left_view/.*: Skip # Issue 31577
-html/custom/mirrors_2_test: Skip # Issue 31577
html/custom_element_method_clash_test: Skip # Issue 29922
html/custom_element_name_clash_test: Skip # Issue 29922
html/custom_elements_23127_test: Skip # Issue 29922
diff --git a/tests/lib_2/lib_2_kernel.status b/tests/lib_2/lib_2_kernel.status
index 03ac748..20fb8dc 100644
--- a/tests/lib_2/lib_2_kernel.status
+++ b/tests/lib_2/lib_2_kernel.status
@@ -41,7 +41,6 @@
isolate/static_function_test: Skip # Times out. Issue 31855. CompileTimeError. Issue 31402
mirrors/invocation_fuzz_test: Crash
mirrors/metadata_allowed_values_test/16: Skip # Flaky, crashes.
-mirrors/native_class_test: SkipByDesign # Imports dart:html
[ $compiler == dartk && $hot_reload_rollback ]
isolate/illegal_msg_function_test: Skip # Timeout
diff --git a/tests/standalone/standalone.status b/tests/standalone/standalone.status
index 8c060c3..bc31c1d 100644
--- a/tests/standalone/standalone.status
+++ b/tests/standalone/standalone.status
@@ -35,10 +35,8 @@
causal_async_stack_test: Skip # Flaky.
[ $mode == product ]
-dart_developer_env_test: SkipByDesign
io/stdio_implicit_close_test: Skip # SkipByDesign
no_profiler_test: SkipByDesign
-no_support_coverage_test: SkipByDesign
no_support_debugger_test: SkipByDesign
no_support_disassembler_test: SkipByDesign
no_support_il_printer_test: SkipByDesign
@@ -62,8 +60,8 @@
verbose_gc_to_bmu_test: Skip # Attempts to spawn dart using Platform.executable
[ $system != macos ]
-io/https_nonblocking_trust_evaluation_test: SkipByDesign
io/https_connection_closed_during_handshake_test: SkipByDesign # long_ssl_cert_evaluation needed for long handshake is only supported on mac.
+io/https_nonblocking_trust_evaluation_test: SkipByDesign
[ $builder_tag == swarming && $system == macos ]
io/*: Skip # Issue 30618
@@ -79,7 +77,6 @@
[ $runtime == vm && $system == linux ]
io/http_basic_test: Slow, Pass # Issue 28046, These tests might be slow on an opt counter threshold bot. They also time out on the bot occasionally => flaky test issue 28046
-io/http_launch_test: Slow, Pass # Issue 28046, These tests might be slow on an opt counter threshold bot. They also time out on the bot occasionally => flaky test issue 28046
[ $system == macos && ($runtime == dart_precompiled || $runtime == vm) ]
io/raw_secure_server_socket_test: Crash
@@ -94,9 +91,6 @@
[ $compiler == dart2js || $compiler == dartdevc || $compiler == dartdevk ]
*: SkipByDesign
-[ $mode == product || $runtime == dart_precompiled ]
-no_assert_test: SkipByDesign
-
[ $runtime == dart_precompiled || $runtime == vm ]
deferred_transitive_import_error_test: Skip
diff --git a/tests/standalone/standalone_kernel.status b/tests/standalone/standalone_kernel.status
index 7d8b98f..c444a59 100644
--- a/tests/standalone/standalone_kernel.status
+++ b/tests/standalone/standalone_kernel.status
@@ -8,7 +8,6 @@
io/process_sync_test: Pass, Slow # Spawns synchronously subprocesses in sequence.
[ $builder_tag == tsan ]
-fragmentation_data_test: Skip # This test crashes on the bot, but not locally, and infrastructure repeatly fails to locate its coredump.
fragmentation_typed_data_test: Skip # This test crashes on the bot, but not locally, and infrastructure repeatly fails to locate its coredump.
[ $system == android ]
@@ -30,7 +29,6 @@
[ $compiler == dartk && $mode == debug && $runtime == vm ]
io/file_lock_test: Slow, Pass
io/raw_socket_test: Crash
-io/socket_exception_test: Crash
io/socket_finalizer_test: Crash
io/socket_info_ipv4_test: Crash
io/socket_info_ipv6_test: Crash
@@ -79,7 +77,6 @@
[ $compiler == dartkp && $mode == debug && $runtime == dart_precompiled ]
io/raw_socket_test: Crash
-io/socket_exception_test: Crash
io/socket_finalizer_test: Crash
io/socket_info_ipv4_test: Crash
io/socket_info_ipv6_test: Crash
diff --git a/tests/standalone/standalone_precompiled.status b/tests/standalone/standalone_precompiled.status
index 5e5ec81..f6c27d2 100644
--- a/tests/standalone/standalone_precompiled.status
+++ b/tests/standalone/standalone_precompiled.status
@@ -65,6 +65,3 @@
[ $runtime == dart_precompiled && $checked ]
io/namespace_test: RuntimeError
-
-[ $mode == product || $runtime == dart_precompiled ]
-no_assert_test: SkipByDesign # Requires checked mode.
diff --git a/tests/standalone_2/standalone_2.status b/tests/standalone_2/standalone_2.status
index 9dc0156..53879fd 100644
--- a/tests/standalone_2/standalone_2.status
+++ b/tests/standalone_2/standalone_2.status
@@ -35,10 +35,8 @@
causal_async_stack_test: Skip # Flaky.
[ $mode == product ]
-dart_developer_env_test: SkipByDesign
io/stdio_implicit_close_test: Skip # SkipByDesign
no_profiler_test: SkipByDesign
-no_support_coverage_test: SkipByDesign
no_support_debugger_test: SkipByDesign
no_support_disassembler_test: SkipByDesign
no_support_il_printer_test: SkipByDesign
@@ -61,7 +59,8 @@
io/wait_for_test: SkipByDesign # Uses mirrors.
verbose_gc_to_bmu_test: Skip # Attempts to spawn dart using Platform.executable
-[ $system == fuchsia ] # Fuchsia test runner doesn't support multi-tests yet.
+# Fuchsia test runner doesn't support multi-tests yet.
+[ $system == fuchsia ]
deny_listed_test: Skip
io/dart_std_io_pipe_test: Skip
io/platform_resolved_executable_test: Skip
@@ -71,8 +70,8 @@
regress_29350_test: Skip
[ $system != macos ]
-io/https_nonblocking_trust_evaluation_test: SkipByDesign
io/https_connection_closed_during_handshake_test: SkipByDesign # long_ssl_cert_evaluation needed for long handshake is only supported on mac.
+io/https_nonblocking_trust_evaluation_test: SkipByDesign
[ $builder_tag == swarming && $system == macos ]
io/*: Skip # Issue 30618
@@ -85,7 +84,6 @@
[ $runtime == vm && $system == linux ]
io/http_basic_test: Slow, Pass # Issue 28046, These tests might be slow on an opt counter threshold bot. They also time out on the bot occasionally => flaky test issue 28046
-io/http_launch_test: Slow, Pass # Issue 28046, These tests might be slow on an opt counter threshold bot. They also time out on the bot occasionally => flaky test issue 28046
[ $system == macos && ($runtime == dart_precompiled || $runtime == vm) ]
io/raw_secure_server_socket_test: Crash
@@ -100,9 +98,6 @@
[ $compiler == dart2js || $compiler == dartdevc || $compiler == dartdevk ]
*: SkipByDesign
-[ $mode == product || $runtime == dart_precompiled ]
-no_assert_test: SkipByDesign
-
[ $runtime == dart_precompiled || $runtime == vm ]
deferred_transitive_import_error_test: Skip
diff --git a/tests/standalone_2/standalone_2_kernel.status b/tests/standalone_2/standalone_2_kernel.status
index d7f200f..eb9edd6 100644
--- a/tests/standalone_2/standalone_2_kernel.status
+++ b/tests/standalone_2/standalone_2_kernel.status
@@ -31,7 +31,6 @@
[ $compiler == dartk && $mode == debug && $runtime == vm ]
io/file_lock_test: Slow, Pass
io/raw_socket_test: Crash
-io/socket_exception_test: Crash
io/socket_finalizer_test: Crash
io/socket_info_ipv4_test: Crash
io/socket_info_ipv6_test: Crash
@@ -80,7 +79,6 @@
[ $compiler == dartkp && $mode == debug && $runtime == dart_precompiled ]
io/raw_socket_test: Crash
-io/socket_exception_test: Crash
io/socket_finalizer_test: Crash
io/socket_info_ipv4_test: Crash
io/socket_info_ipv6_test: Crash
diff --git a/tests/standalone_2/standalone_2_precompiled.status b/tests/standalone_2/standalone_2_precompiled.status
index 1e00e12..cf466ae 100644
--- a/tests/standalone_2/standalone_2_precompiled.status
+++ b/tests/standalone_2/standalone_2_precompiled.status
@@ -59,6 +59,3 @@
[ $runtime == dart_precompiled && $checked ]
io/namespace_test: RuntimeError
-
-[ $mode == product || $runtime == dart_precompiled ]
-no_assert_test: SkipByDesign # Requires checked mode.
diff --git a/third_party/pkg_tested/pkg_tested.status b/third_party/pkg_tested/pkg_tested.status
index 0b31420..bf1542c 100644
--- a/third_party/pkg_tested/pkg_tested.status
+++ b/third_party/pkg_tested/pkg_tested.status
@@ -10,9 +10,6 @@
*/*/*/packages/*/*: Skip
*/*/packages/*/*: Skip
*/packages/*/*: Skip
-pub/test/dart2js/compiles_generated_file_from_dependency_test: Pass, Slow
-pub/test/serve/web_socket/url_to_asset_id_test: Pass, Slow
-pub/test/transformer/loads_a_diamond_transformer_dependency_graph_test: Pass, Slow
[ $runtime == vm ]
http_io/test/http_cross_process_test: Skip # Fails with --no-preview-dart-2
diff --git a/tools/VERSION b/tools/VERSION
index 16de12d..7e70b16 100644
--- a/tools/VERSION
+++ b/tools/VERSION
@@ -27,5 +27,5 @@
MAJOR 2
MINOR 12
PATCH 0
-PRERELEASE 285
+PRERELEASE 286
PRERELEASE_PATCH 0
\ No newline at end of file
diff --git a/tools/bots/test_matrix.json b/tools/bots/test_matrix.json
index e8829df..764388f 100644
--- a/tools/bots/test_matrix.json
+++ b/tools/bots/test_matrix.json
@@ -1008,6 +1008,7 @@
"script": "out/ReleaseX64/dart-sdk/bin/dart",
"testRunner": true,
"arguments": [
+ "--enable-asserts",
"pkg/front_end/test/unit_test_suites.dart",
"-ncfe-unittest-asserts-${mode}-${system}",
"--skipTestsThatRequireGit"
@@ -1027,6 +1028,7 @@
"script": "out/ReleaseX64/dart-sdk/bin/dart",
"testRunner": true,
"arguments": [
+ "--enable-asserts",
"pkg/front_end/test/unit_test_suites.dart",
"-ncfe-unittest-asserts-${mode}-${system}",
"--onlyTestsThatRequireGit"
