tree cc14f993a93257ab096900558e4c1526fc071f1d
parent db367e728c4f6cb13d1e9f73aa1c37b28a8bbea9
author Paul Berry <paulberry@google.com> 1611236016 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> 1611236016 +0000

Migration: infer non-null intent for `this` in extensions.

Since `this` is essentially a variable in extensions, it should be
treated similarly to variables in terms of inference of non-null
intent; for example, if an extension declaration contains a a method
that unconditionall dereferences `this` (either implicitly or
explicitly), that's a good indication that the user probably doesn't
intend for the extension to be applied to nullable types.

Fixes #44675.

Bug: https://github.com/dart-lang/sdk/issues/44675
Change-Id: I004328f5b1fd6710954363c07f4e9db6bc6ac2cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180268
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>