tree 517af684a2cfceb498e8934d281c51117a937158
parent 11b3e34e327101971cee78ae1b0d99adaa62e90e
author Daco Harkes <dacoharkes@google.com> 1609847268 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> 1609847268 +0000

[vm/ffi] Deprecate `Struct.addressOf`

Now that we have nested structs, objects a subtype of `Struct` can be
backed by either a `Pointer` or a `TypedData`. Having this accessor is
misleading.

Instead of passing a struct around (which could be backed by either),
the `Pointer<T extends Struct>` should be passed around and `.ref`
should be used everywhere when access to the backing pointer is
required.

Issue: https://github.com/dart-lang/sdk/issues/40667

Related issues:
* Optimize .ref #38648
* Support tree shaking of structs #38721

Change-Id: I3c73423480b91c00639df886bf1d6ac2e444beab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177581
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>