commit 658b656941b1a93ab3a6e03e48d3e4f4c96a00ec
author Paul Berry <paulberry@google.com> Tue Jan 06 11:14:50 2026 -0800
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jan 06 11:14:50 2026 -0800
tree a963979d7a56690dd5d466621d295168d6efbff0
parent f4dfbbe4a463331e2465c092eeb620ab6f7caf17

[messages] Clean up constWithUndefinedConstructor diagnostic.

This diagnostic is reported in two circumstances:

- During resolution of a dot shorthand like `const .foo()`, when the
  implicitly-referred to class doesn't have a constructor with the
  given name.

- During resolution of a const constructor invocation like `const
  int.foo()`, when the explicitly-referred to class (`int` in this
  example) doesn't have a constructor with the given name.

In both cases, the diagnostic message includes the names of both the
class and the constructor that was sought. But in the first case, the
class name was accidentally derived from the type inference context
rather than the dot shorthand context; these are different in the case
where the dot shorthand appears on the RHS of `==`. Fixed by supplying
the correct context type.

This bug was discovered in the process of converting the analyzer to
use the new literate error reporting mechanism: I needed to assign a
type to the diagnostic message parameter that was to contain the class
name and discovered that I couldn't give a consistent type, because it
was sometimes being filled in with a class name string, and it was
sometimes being filled in with a type. With the fix, it is always
filled in with a class name string.

I also included tests of the other dot shorthand related diagnostics
that mention the class name (they don't exhibit the same bug), as well
as a typo fix for `wrongNumberOfTypeArgumentsDotShorthandConstructor`
(which had mismatched quote symbols).

Fixes https://github.com/dart-lang/sdk/issues/62352.

Change-Id: I6a6a696421b68397b86aac9b1a6e91cce08250ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/470942
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>