)]}' { "commit": "eb50c2683ce821c6ee49586d506f8315236a165a", "tree": "c569522125e4dc4676d80c172f9155577c9c6a31", "parents": [ "9426e47d736a96ef82f858c896676cae192eea7c" ], "author": { "name": "Daco Harkes", "email": "dacoharkes@google.com", "time": "Thu Mar 28 11:24:36 2024 +0000" }, "committer": { "name": "Commit Queue", "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 28 11:24:36 2024 +0000" }, "message": "[vm/ffi] Throw on attaching `NativeFinalizer` to deeply immutable object\n\nThis CL\n\n* adds a `kind` to `CheckWritableInstr`,\n* starts using `CheckWritableInstr` in JIT mode, and\n* adds support for `CheckWritableInstr` ia32.\n\nTEST\u003dtests/ffi/vmspecific_native_finalizer_deeply_immutable_test.dart\n\nCloses: https://github.com/dart-lang/sdk/issues/55067\nChange-Id: I0b397daba12cfc8b885401169889f7cd7c040166\nCq-Include-Trybots: dart-internal/g3.dart-internal.try:g3-cbuild-try\nCq-Include-Trybots: dart/try:vm-aot-android-release-arm64c-try,vm-aot-android-release-arm_x64-try,vm-aot-linux-debug-x64-try,vm-aot-linux-debug-x64c-try,vm-aot-mac-release-arm64-try,vm-aot-mac-release-x64-try,vm-aot-obfuscate-linux-release-x64-try,vm-aot-optimization-level-linux-release-x64-try,vm-aot-win-debug-arm64-try,vm-aot-win-debug-x64c-try,vm-aot-win-release-x64-try,vm-appjit-linux-debug-x64-try,vm-asan-linux-release-x64-try,vm-checked-mac-release-arm64-try,vm-eager-optimization-linux-release-ia32-try,vm-eager-optimization-linux-release-x64-try,vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64c-try,vm-ffi-qemu-linux-release-arm-try,vm-ffi-qemu-linux-release-riscv64-try,vm-linux-debug-ia32-try,vm-linux-debug-x64-try,vm-linux-debug-x64c-try,vm-mac-debug-arm64-try,vm-mac-debug-x64-try,vm-msan-linux-release-x64-try,vm-reload-linux-debug-x64-try,vm-reload-rollback-linux-debug-x64-try,vm-ubsan-linux-release-x64-try,vm-win-debug-arm64-try,vm-win-debug-x64-try,vm-win-debug-x64c-try,vm-win-release-ia32-try\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359223\nAuto-Submit: Daco Harkes \u003cdacoharkes@google.com\u003e\nReviewed-by: Ryan Macnak \u003crmacnak@google.com\u003e\nCommit-Queue: Daco Harkes \u003cdacoharkes@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "ef10523746ee7d1101d88ef0d0d0f834b967829b", "old_mode": 33188, "old_path": "runtime/vm/compiler/backend/flow_graph_compiler.cc", "new_id": "6d859c1afaeea26a19c4ab3baa5de8d491626c95", "new_mode": 33188, "new_path": "runtime/vm/compiler/backend/flow_graph_compiler.cc" }, { "type": "modify", "old_id": "1a7ba9195c39d720df1b426cb864d6aab450b907", "old_mode": 33188, "old_path": "runtime/vm/compiler/backend/flow_graph_compiler.h", "new_id": "5e5e619b4dc9f894183470d25ffbb69edb8769ff", "new_mode": 33188, "new_path": "runtime/vm/compiler/backend/flow_graph_compiler.h" }, { "type": "modify", "old_id": "3d7c1df03ba8a352649f1b74259c8d8141b02085", "old_mode": 33188, "old_path": "runtime/vm/compiler/backend/il.cc", "new_id": "dc8ae34540470f31cd69390ec24d6144eaa10fe9", "new_mode": 33188, "new_path": "runtime/vm/compiler/backend/il.cc" }, { "type": "modify", "old_id": "8214ee8232a932a9a4fd35f50491c3e2bca1b912", "old_mode": 33188, "old_path": "runtime/vm/compiler/backend/il.h", "new_id": "4e6b3bfe20fe4a7e07edf1dbc43c3a30a259da77", "new_mode": 33188, "new_path": "runtime/vm/compiler/backend/il.h" }, { "type": "modify", "old_id": "14e4947f64e47a2224861849dabccd8c289cf87a", "old_mode": 33188, "old_path": "runtime/vm/compiler/backend/il_ia32.cc", "new_id": "e4bc484d9d5643240a50ec7249cf58163e7a88dc", "new_mode": 33188, "new_path": "runtime/vm/compiler/backend/il_ia32.cc" }, { "type": "modify", "old_id": "d54c8f22cd96e4ae5944d8804e4f8036e46346d0", "old_mode": 33188, "old_path": "runtime/vm/compiler/frontend/base_flow_graph_builder.cc", "new_id": "09dcb66b96c914268b0108d7c8ed98ef149ac366", "new_mode": 33188, "new_path": "runtime/vm/compiler/frontend/base_flow_graph_builder.cc" }, { "type": "modify", "old_id": "496d654d9d50ffbf14d5dc7bf59ce7cd69704c9f", "old_mode": 33188, "old_path": "runtime/vm/compiler/frontend/base_flow_graph_builder.h", "new_id": "8b9a46ebbf839ecdad7438e5dc13a24e8ac8f151", "new_mode": 33188, "new_path": "runtime/vm/compiler/frontend/base_flow_graph_builder.h" }, { "type": "modify", "old_id": "f52edc93196c989aee49fc2110321ac18c1d6594", "old_mode": 33188, "old_path": "runtime/vm/compiler/frontend/kernel_to_il.cc", "new_id": "4433d577350252bbfff14c2f624eca7b95dce2b7", "new_mode": 33188, "new_path": "runtime/vm/compiler/frontend/kernel_to_il.cc" }, { "type": "modify", "old_id": "1ca8d2db6ab5cc58ace37b4bc73adbcc957cd868", "old_mode": 33188, "old_path": "runtime/vm/compiler/recognized_methods_list.h", "new_id": "01ea819a2ae2617910a8d606d0076b8e8f676073", "new_mode": 33188, "new_path": "runtime/vm/compiler/recognized_methods_list.h" }, { "type": "modify", "old_id": "19f89c9be9f4c8669fefb598fd6c66169d276fcb", "old_mode": 33188, "old_path": "runtime/vm/compiler/stub_code_compiler_arm.cc", "new_id": "a840d83f5b9de285007ac6976b933f91aa05e0f8", "new_mode": 33188, "new_path": "runtime/vm/compiler/stub_code_compiler_arm.cc" }, { "type": "modify", "old_id": "dd58880d0d876a186f44f128a66513c38b9889a0", "old_mode": 33188, "old_path": "runtime/vm/compiler/stub_code_compiler_arm64.cc", "new_id": "586e2505b4f0af344a2cc9b0953817988ed9d114", "new_mode": 33188, "new_path": "runtime/vm/compiler/stub_code_compiler_arm64.cc" }, { "type": "modify", "old_id": "720d203a3a52a1edf8cc00ea0b9eca6f07485ce0", "old_mode": 33188, "old_path": "runtime/vm/compiler/stub_code_compiler_riscv.cc", "new_id": "266a3435f5ddfd5c133023db60ade1478e73711a", "new_mode": 33188, "new_path": "runtime/vm/compiler/stub_code_compiler_riscv.cc" }, { "type": "modify", "old_id": "517e659527ca17549ec3c6da384e42134bb61785", "old_mode": 33188, "old_path": "runtime/vm/compiler/stub_code_compiler_x64.cc", "new_id": "9c685cdba7ef81a7a34cc3195cf281479f677f38", "new_mode": 33188, "new_path": "runtime/vm/compiler/stub_code_compiler_x64.cc" }, { "type": "modify", "old_id": "9fef6d93742db3c630dd89e5323d1fdef2832e0f", "old_mode": 33188, "old_path": "runtime/vm/runtime_entry.cc", "new_id": "c4729748bee0e12f859af6dff8a165ddb6713a85", "new_mode": 33188, "new_path": "runtime/vm/runtime_entry.cc" }, { "type": "modify", "old_id": "7d6ad770ecd1c14a67cc172203025e93d6e98f4f", "old_mode": 33188, "old_path": "sdk/lib/_internal/vm/lib/ffi_native_finalizer_patch.dart", "new_id": "0836d27d4bfec037ec0d68050aace7ea5042d3f9", "new_mode": 33188, "new_path": "sdk/lib/_internal/vm/lib/ffi_native_finalizer_patch.dart" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "9d2f6f30fb9b2532114526fc0c296f10c37bae01", "new_mode": 33188, "new_path": "tests/ffi/vmspecific_native_finalizer_deeply_immutable_test.dart" } ] }