commit f424f3a4cca306513e77c7747682f1c1c99e3307
author Alexander Aprelev <aam@google.com> Wed Jul 28 02:20:13 2021 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> Wed Jul 28 02:20:13 2021 +0000
tree 64e894ff1bc7b64e7ce0f87cde85456c2063deac
parent babfe05e4a9e892d71f8f6ebcb6df82095bea0da

[vm/gardening] Fix file_fuzz_test so it doesn't create files in the dart sdk checkout root.

Fixes https://github.com/dart-lang/sdk/issues/46737

TEST=Ensure file_fuzz_test doesn't create 'a' file

Change-Id: I200bc63a86f75e0b770f1a2240a9e2bfdc99aef6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208285
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>

tests/standalone/io/file_fuzz_test.dart

diff --git a/tests/standalone/io/file_fuzz_test.dart b/tests/standalone/io/file_fuzz_test.dart
index f7f89c8..813a2bf 100644
--- a/tests/standalone/io/file_fuzz_test.dart
+++ b/tests/standalone/io/file_fuzz_test.dart
@@ -14,9 +14,10 @@
 import "package:async_helper/async_helper.dart";
 
 fuzzSyncMethods() {
+  var temp = Directory.systemTemp.createTempSync('dart_file_fuzz');
   typeMapping.forEach((k, v) {
     File? file;
-    doItSync(() => file = new File(v as String));
+    doItSync(() => file = new File('${temp.path}/${v as String}'));
     if (file == null) return;
     final f = file!;
     doItSync(f.existsSync);
@@ -36,14 +37,16 @@
       doItSync(() => f.readAsLinesSync(encoding: v2 as Encoding));
     });
   });
+  temp.deleteSync(recursive: true);
 }
 
 fuzzAsyncMethods() {
   asyncStart();
   var futures = <Future>[];
+  var temp = Directory.systemTemp.createTempSync('dart_file_fuzz');
   typeMapping.forEach((k, v) {
     File? file;
-    doItSync(() => file = new File(v as String));
+    doItSync(() => file = new File('${temp.path}/${v as String}'));
     if (file == null) return;
     final f = file!;
     futures.add(doItAsync(f.exists));
@@ -62,7 +65,10 @@
       futures.add(doItAsync(() => f.readAsLines(encoding: v2 as Encoding)));
     });
   });
-  Future.wait(futures).then((_) => asyncEnd());
+  Future.wait(futures).then((_) {
+    temp.deleteSync(recursive: true);
+    asyncEnd();
+  });
 }
 
 fuzzSyncRandomAccessMethods() {

tests/standalone_2/io/file_fuzz_test.dart

diff --git a/tests/standalone_2/io/file_fuzz_test.dart b/tests/standalone_2/io/file_fuzz_test.dart
index 60a7e5b..95a704c 100644
--- a/tests/standalone_2/io/file_fuzz_test.dart
+++ b/tests/standalone_2/io/file_fuzz_test.dart
@@ -15,9 +15,10 @@
 import "package:async_helper/async_helper.dart";
 
 fuzzSyncMethods() {
+  var temp = Directory.systemTemp.createTempSync('dart_file_fuzz');
   typeMapping.forEach((k, v) {
     File f;
-    doItSync(() => f = new File(v));
+    doItSync(() => f = new File('${temp.path}/$v'));
     if (f == null) return;
     doItSync(f.existsSync);
     doItSync(f.createSync);
@@ -36,14 +37,16 @@
       doItSync(() => f.readAsLinesSync(encoding: v2));
     });
   });
+  temp.deleteSync(recursive: true);
 }
 
 fuzzAsyncMethods() {
   asyncStart();
   var futures = <Future>[];
+  var temp = Directory.systemTemp.createTempSync('dart_file_fuzz');
   typeMapping.forEach((k, v) {
     File f;
-    doItSync(() => f = new File(v));
+    doItSync(() => f = new File('${temp.path}/$v'));
     if (f == null) return;
     futures.add(doItAsync(f.exists));
     futures.add(doItAsync(f.delete));
@@ -61,7 +64,10 @@
       futures.add(doItAsync(() => f.readAsLines(encoding: v2)));
     });
   });
-  Future.wait(futures).then((_) => asyncEnd());
+  Future.wait(futures).then((_) {
+    temp.deleteSync(recursive: true);
+    asyncEnd();
+  });
 }
 
 fuzzSyncRandomAccessMethods() {