tree beb43aaf585250721cb0732ae448853bc9d141a2
parent 34953ffd7dff0a7f62a27252045bb07d59cfaf2e
author Vyacheslav Egorov <vegorov@google.com> 1552003597 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> 1552003597 +0000

[vm] Add Native->VM transitions when dereferencing API handles.

For example setting return value unwraps handles and stores
raw pointer values to the stack which might race with GC
in another thread.

This CL adds assertions in helper methods from Api class which
unwrap API handles and fixes all places that were revealed by
those assertions.

Caveat: we still permit to check whether handle contains
Smi or not without entering VM state - because GC does not
change this property.

Bug: b/127482366
Change-Id: I59f08c2a91935995514fb70607c2777aa2844d94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95654
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>