commit | dd8f24ee49a7a4a6829b91d54a6db439420298e7 | [log] [tgz] |
---|---|---|
author | Martin Kustermann <kustermann@google.com> | Wed Feb 17 09:53:49 2021 +0000 |
committer | William Hesse <whesse@google.com> | Fri Feb 19 12:25:49 2021 +0100 |
tree | eb6564e3293d60d23e508df6b586238ffebb5ab0 | |
parent | dcaded0347cb6a6fa1906c3d52070e0617d4202d [diff] |
[vm/concurrency] Refactor SafepointRwLock to ensure unlocking never causes safepoint transition. The previous implementation of SafepointRwLock has an issue (discovered by Slava, see bug) with the following code pattern: { SafepointReadRwLocker locker(...); return Foo(); // <-- Returns raw ptr. } After the return expression has been evaluated to a raw pointer the destructor might enter safepoint and cause GC, which leaves the raw pointer unchanged (since it's not in a handle). This CL refactors the implementation to ensure we don't perform any state transition in the destructor, therefore eliminate the possibility of GC moving the object we return. Issue https://github.com/dart-lang/sdk/issues/44998 TEST=Relying on existing SafepointRwLock. Change-Id: Ib7a62b36838edd4b39ad67a8c58f048aa05aa144 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185062 Commit-Queue: Martin Kustermann <kustermann@google.com> Reviewed-by: Alexander Aprelev <aam@google.com> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.