| commit | dc7e082336fc7a9c639c1d62edf4cc0ebb57ea51 | [log] [tgz] |
|---|---|---|
| author | Martin Kustermann <kustermann@google.com> | Wed Nov 03 13:36:35 2021 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Wed Nov 03 13:36:35 2021 +0000 |
| tree | 284c06ad6ec6efe002203d1209af4512ab000e7f | |
| parent | 12a89261e5b831096e734688edf4a9c1b6ee21b3 [diff] |
[vm/concurrency] Ensure rehashing of maps correctly resets [_deletedKeys] When we rehash a linked hash map, we rebuild the index but keep the existing data array. The [_deletedKeys] specifies the number of entries in the [_index] which were marked as deleted. The Dart code that triggers rehashing and initializes a new [_index] didn't initialize [_deletedKeys]. => We'll fix this in the Dart code and as a precaution also in the transitive object copy code. Furthermore we add a missing optimization: In the example from the bug report we shouldn't even have attempted to re-hash, because the maps have only primitive keys (which do not rely on identity or user-defined hashcodes). => We'll change the existing optimization to ignore deleted entries when determining whether a rehash is needed. The rehashing code for Sets works differently and takes this already into account. Closes https://github.com/dart-lang/sdk/issues/47598 TEST=vm/dart{,_2}/isolates/fast_object_copy_test Change-Id: I3529ecbf500009ab0c72b98e6c427b8840a69371 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219000 Reviewed-by: Alexander Aprelev <aam@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.