[CFE] Restrict incremental_compiler_leak_test further
Because of lazy loading many instances naturally fluctuate.
Previously this was "worked around" by ignoring specific classes,
but that has proved unreliable. This CL instead ignores everything in
package:front_end except for a few select classes.
Hopefully this will lead to less false positives in the future.
"Fixes" https://github.com/dart-lang/sdk/issues/49337
Change-Id: I87c6e0b63c7dbdb6421f21f8613047e5b53b8296
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249860
Commit-Queue: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Auto-Submit: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
diff --git a/pkg/front_end/test/incremental_compiler_leak_test.dart b/pkg/front_end/test/incremental_compiler_leak_test.dart
index 581d63f..2385fab 100644
--- a/pkg/front_end/test/incremental_compiler_leak_test.dart
+++ b/pkg/front_end/test/incremental_compiler_leak_test.dart
@@ -192,32 +192,12 @@
String? uriString = classDetails.location?.script?.uri;
if (uriString == null) return true;
if (uriString.startsWith("package:front_end/")) {
- // Classes used for lazy initialization will naturally fluctuate.
- if (classDetails.name == "DillClassBuilder") return true;
- if (classDetails.name == "DillExtensionBuilder") return true;
- if (classDetails.name == "DillExtensionMemberBuilder") return true;
- if (classDetails.name == "DillMemberBuilder") return true;
- if (classDetails.name == "DillTypeAliasBuilder") return true;
-
- // These classes have proved to fluctuate, although the reason is less
- // clear.
- if (classDetails.name == "InheritedImplementationInterfaceConflict") {
- return true;
- }
- if (classDetails.name == "AbstractMemberOverridingImplementation") {
- return true;
- }
- if (classDetails.name == "VoidTypeBuilder") return true;
- if (classDetails.name == "NamedTypeBuilder") return true;
- if (classDetails.name == "DillClassMember") return true;
- if (classDetails.name == "Scope") return true;
- if (classDetails.name == "ConstructorScope") return true;
- if (classDetails.name == "ScopeBuilder") return true;
- if (classDetails.name == "ConstructorScopeBuilder") return true;
- if (classDetails.name == "NullTypeDeclarationBuilder") return true;
- if (classDetails.name == "NullabilityBuilder") return true;
-
- return false;
+ // Because of lazy loading many things naturally fluctuate.
+ // We'll therefore restrict this to Source* stuff and
+ // DillLibraryBuilder for front_end stuff.
+ if (classDetails.name?.startsWith("Source") ?? false) return false;
+ if (classDetails.name == "DillLibraryBuilder") return false;
+ return true;
} else if (uriString.startsWith("package:kernel/")) {
// DirtifyingList is used for lazy stuff and naturally change in numbers.
if (classDetails.name == "DirtifyingList") return true;
