| commit | bc06a90a0e66d8c4c3f74968877189dba4706f7a | [log] [tgz] |
|---|---|---|
| author | Johnni Winther <johnniwinther@google.com> | Fri Oct 02 20:21:30 2020 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Fri Oct 02 20:21:30 2020 +0000 |
| tree | 0a9d516e27fac89dc72b8a8af9d60d97940bb43c | |
| parent | f516210208f738cbaba1ba620159261513e6cb71 [diff] |
[cfe] Stop using DirectPropertyGet for enum encoding DirectPropertyGet is a statically bound instance access used in the VM mixin tranformation to encode fully resolved super access. The access to `this.name` generated in `toString` of an enum is _not_ a statically bound instance access but just a regular instance access whose runtime target happens to be known statically because the code is generated. In JavaScript backend a statically bound instance access requires a unique getter to avoid the dynamic lookup, and therefore, though using DirectPropertyGet is an optimization to the VM, it would be a regression to the JavaScript backends if they didn't handle DirectPropertyGet as a PropertyGet. This CL removes the misuse and thus enables JavaScript backends to handle DirectPropertyGet with the intended semantics. Change-Id: Ie41aefbf19e8c63244f10a1afda1ddbfdf7d3c19 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164085 Reviewed-by: Alexander Markov <alexmarkov@google.com> Commit-Queue: Johnni Winther <johnniwinther@google.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, getting started, and more.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.