commit 3cf00938213513dcc16cc845c1c0efc2ea3ddf59
author Paul Berry <paulberry@google.com> Mon Dec 30 09:45:59 2024 -0800
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Dec 30 09:45:59 2024 -0800
tree b27e0571cbf8cd1b8ebc053b727cae73377deba6
parent 70c0a2e5f9740c33951fffe4223d9a6f2d7a6f15

[analyzer] Stop implementing some shared types in public API.

The following adjustements are made to the analyzer class hierarchy:

- `SharedNamedFunctionParameterStructure` is moved from the
  `implements` clause of `ParameterElement` to the implements clause
  of `ParameterElementMixin`, a mixin that is used by all concrete
  subtypes of `ParameterElement`, but which is not part of the
  analyzer's public API.

- `SharedNamedTypeStructure` is moved from the `implements` clause of
  `RecordTypeNamedField` to the implements clause of
  `RecordTypeNamedFieldImpl`, the sole concrete subtype of
  `RecordTypeNamedField`, which is not part of the analyzer's public
  API.

To account for these changes, the analyzer's use of the shared types
`FunctionTypeImpl`, `TypeConstraintGenerator`, and
`TypeConstraintGeneratorMixin` needed to be adjusted so
`ParameterElementMixin` is supplied as a type parameter instead of
`ParameterElement`. This required adding a cast to the
`FunctionTypeImpl` constructor, which I intend to remove in a future
CL.

This is part of a larger arc of work to change the analyzer's use of
the shared code so that the type parameters it supplies are not part
of the analyzer public API. See
https://github.com/dart-lang/sdk/issues/59763.

Change-Id: I889b9f87d7d077d10935c4506c454507a480afcd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/402380
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>