CQ. Make a couple of methods return void, remove unawaited() for them.
Change-Id: Icc8e916c4f6fd42d6a604544e893626b97cb5e73
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/431621
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
diff --git a/pkg/analyzer/lib/src/dart/analysis/driver.dart b/pkg/analyzer/lib/src/dart/analysis/driver.dart
index dfbf27c..98699f9 100644
--- a/pkg/analyzer/lib/src/dart/analysis/driver.dart
+++ b/pkg/analyzer/lib/src/dart/analysis/driver.dart
@@ -2559,7 +2559,7 @@
throw StateError('The scheduler has already been started.');
}
_started = true;
- unawaited(_run());
+ _run();
}
/// Return a future that will be completed the next time the status is idle.
@@ -2570,7 +2570,7 @@
/// Run infinitely analysis cycle, selecting the drivers with the highest
/// priority first.
- Future<void> _run() async {
+ void _run() async {
// Give other microtasks the time to run before doing the analysis cycle.
await null;
Stopwatch timer = Stopwatch()..start();
diff --git a/pkg/analyzer/lib/src/dart/analysis/file_byte_store.dart b/pkg/analyzer/lib/src/dart/analysis/file_byte_store.dart
index a634753..e917ca5 100644
--- a/pkg/analyzer/lib/src/dart/analysis/file_byte_store.dart
+++ b/pkg/analyzer/lib/src/dart/analysis/file_byte_store.dart
@@ -38,7 +38,7 @@
EvictingFileByteStore(this._cachePath, this._maxSizeBytes)
: _fileByteStore = FileByteStore(_cachePath) {
- unawaited(_requestCacheCleanUp());
+ _requestCacheCleanUp();
}
@override
@@ -50,7 +50,7 @@
// Update the current size.
_bytesWrittenSinceCleanup += bytes.length;
if (_bytesWrittenSinceCleanup > _maxSizeBytes ~/ 8) {
- unawaited(_requestCacheCleanUp());
+ _requestCacheCleanUp();
}
return bytes;
}
@@ -59,7 +59,7 @@
void release(Iterable<String> keys) {}
/// If the cache clean up process has not been requested yet, request it.
- Future<void> _requestCacheCleanUp() async {
+ void _requestCacheCleanUp() async {
if (_cleanUpSendPortShouldBePrepared) {
_cleanUpSendPortShouldBePrepared = false;
ReceivePort response = ReceivePort();
