[cq] remove unnecessary ignores
See: https://github.com/dart-lang/sdk/issues/35234
Change-Id: I4563df48df9d71332b3de6fabea9176e199c1ad5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/404202
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
diff --git a/pkg/analysis_server/lib/src/services/correction/fix/data_driven/code_fragment_parser.dart b/pkg/analysis_server/lib/src/services/correction/fix/data_driven/code_fragment_parser.dart
index cfc4524..a15c765 100644
--- a/pkg/analysis_server/lib/src/services/correction/fix/data_driven/code_fragment_parser.dart
+++ b/pkg/analysis_server/lib/src/services/correction/fix/data_driven/code_fragment_parser.dart
@@ -11,7 +11,6 @@
import 'package:analyzer/src/utilities/extensions/string.dart';
// Several "report" functions intentionally return a `Null`-typed value.
-// ignore_for_file: prefer_void_to_null
/// A parser for the textual representation of a code fragment.
class CodeFragmentParser {
diff --git a/pkg/analysis_server/lib/src/services/correction/fix/data_driven/transform_set_parser.dart b/pkg/analysis_server/lib/src/services/correction/fix/data_driven/transform_set_parser.dart
index 0b6dc567..536b684 100644
--- a/pkg/analysis_server/lib/src/services/correction/fix/data_driven/transform_set_parser.dart
+++ b/pkg/analysis_server/lib/src/services/correction/fix/data_driven/transform_set_parser.dart
@@ -27,7 +27,6 @@
import 'package:yaml/yaml.dart';
// Several "report" functions intentionally return a `Null`-typed value.
-// ignore_for_file: prefer_void_to_null
/// Information used to report errors when translating a node.
class ErrorContext {
diff --git a/pkg/analysis_server/test/lsp/flutter_outline_test.dart b/pkg/analysis_server/test/lsp/flutter_outline_test.dart
index 105c18e..3e076a0 100644
--- a/pkg/analysis_server/test/lsp/flutter_outline_test.dart
+++ b/pkg/analysis_server/test/lsp/flutter_outline_test.dart
@@ -30,7 +30,6 @@
// Wait up to 1sec to ensure no error/log notifications were sent back.
var didTimeout = false;
var outlineNotification = waitForFlutterOutline(mainFileUri)
- // ignore: unnecessary_cast
.then((outline) => outline as FlutterOutline?)
.timeout(
const Duration(seconds: 1),
diff --git a/pkg/analysis_server/test/lsp/server_abstract.dart b/pkg/analysis_server/test/lsp/server_abstract.dart
index ca6b503..d0398db 100644
--- a/pkg/analysis_server/test/lsp/server_abstract.dart
+++ b/pkg/analysis_server/test/lsp/server_abstract.dart
@@ -1574,7 +1574,6 @@
// This is the signature expected for LSP.
// https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#:~:text=Response%3A-,result%3A%20null,-error%3A%20code%20and
- // ignore: prefer_void_to_null
Future<Null> sendShutdown() {
var request = makeRequest(Method.shutdown, null);
return expectSuccessfulResponseTo(request, (result) => result as Null);
diff --git a/pkg/analysis_server_plugin/test/src/plugin_server_error_test.dart b/pkg/analysis_server_plugin/test/src/plugin_server_error_test.dart
index bb165b0..d3d9d88 100644
--- a/pkg/analysis_server_plugin/test/src/plugin_server_error_test.dart
+++ b/pkg/analysis_server_plugin/test/src/plugin_server_error_test.dart
@@ -232,7 +232,6 @@
void visitBooleanLiteral(BooleanLiteral node) {
// Raise an async error that can only be caught by an error zone's `onError`
// handler.
- // ignore: unawaited_futures
Future<void>.error(StateError('A message.'));
}
}
diff --git a/pkg/analyzer/lib/src/generated/testing/test_type_provider.dart b/pkg/analyzer/lib/src/generated/testing/test_type_provider.dart
index 8811e72..bba7d1f 100644
--- a/pkg/analyzer/lib/src/generated/testing/test_type_provider.dart
+++ b/pkg/analyzer/lib/src/generated/testing/test_type_provider.dart
@@ -2,8 +2,6 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-// ignore_for_file: analyzer_use_new_elements
-
import 'package:analyzer/source/source.dart';
import 'package:analyzer/src/dart/analysis/session.dart';
import 'package:analyzer/src/dart/element/class_hierarchy.dart';
diff --git a/pkg/analyzer/lib/src/summary2/kernel_compilation_service.dart b/pkg/analyzer/lib/src/summary2/kernel_compilation_service.dart
index dfd4b3b..d36a38d 100644
--- a/pkg/analyzer/lib/src/summary2/kernel_compilation_service.dart
+++ b/pkg/analyzer/lib/src/summary2/kernel_compilation_service.dart
@@ -138,11 +138,9 @@
if (instance != null) {
_currentInstance = null;
// We don't expect any answer, the process will stop.
- // ignore: unawaited_futures
instance.requestChannel.sendRequest<void>('exit', {});
instance.socket.destroy();
// This socket is bound to a fresh port, we don't need it.
- // ignore: unawaited_futures
instance.serverSocket.close();
instance.process.kill();
}
diff --git a/pkg/analyzer/lib/src/summary2/macro.dart b/pkg/analyzer/lib/src/summary2/macro.dart
index 2ee109e..cb4621c 100644
--- a/pkg/analyzer/lib/src/summary2/macro.dart
+++ b/pkg/analyzer/lib/src/summary2/macro.dart
@@ -133,7 +133,6 @@
Uri get _kernelUri {
return _kernelUriCached ??=
- // ignore: avoid_dynamic_calls
(Isolate.current as dynamic).createUriForKernelBlob(kernelBytes) as Uri;
}
@@ -142,7 +141,6 @@
support.executor.unregisterExecutorFactory(_executorFactoryToken);
var kernelUriCached = _kernelUriCached;
if (kernelUriCached != null) {
- // ignore: avoid_dynamic_calls
(Isolate.current as dynamic).unregisterKernelBlobUri(kernelUriCached);
_kernelUriCached = null;
}
diff --git a/pkg/analyzer_plugin/test/src/utilities/change_builder/change_builder_dart_test.dart b/pkg/analyzer_plugin/test/src/utilities/change_builder/change_builder_dart_test.dart
index 146f474..7c873d6 100644
--- a/pkg/analyzer_plugin/test/src/utilities/change_builder/change_builder_dart_test.dart
+++ b/pkg/analyzer_plugin/test/src/utilities/change_builder/change_builder_dart_test.dart
@@ -2,8 +2,6 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-// ignore_for_file: camel_case_types
-
import 'package:analyzer/dart/analysis/results.dart';
import 'package:analyzer/dart/ast/ast.dart';
import 'package:analyzer/dart/element/element2.dart';
diff --git a/pkg/linter/lib/src/analyzer.dart b/pkg/linter/lib/src/analyzer.dart
index 151168d..03daae3 100644
--- a/pkg/linter/lib/src/analyzer.dart
+++ b/pkg/linter/lib/src/analyzer.dart
@@ -2,8 +2,6 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-// ignore_for_file: implementation_imports
-
export 'package:analyzer/dart/element/type_system.dart';
export 'package:analyzer/source/line_info.dart';
export 'package:analyzer/src/dart/ast/token.dart';
diff --git a/pkg/linter/lib/src/rules/package_prefixed_library_names.dart b/pkg/linter/lib/src/rules/package_prefixed_library_names.dart
index a9d8023..9e9ab7c 100644
--- a/pkg/linter/lib/src/rules/package_prefixed_library_names.dart
+++ b/pkg/linter/lib/src/rules/package_prefixed_library_names.dart
@@ -38,7 +38,6 @@
_Visitor(this.rule);
@override
- // ignore: prefer_expression_function_bodies
void visitLibraryDirective(LibraryDirective node) {
// Project info is not being set.
//See: https://github.com/dart-lang/linter/issues/3395
diff --git a/pkg/linter/lib/src/rules/prefer_is_empty.dart b/pkg/linter/lib/src/rules/prefer_is_empty.dart
index c889d20..f66cfbb 100644
--- a/pkg/linter/lib/src/rules/prefer_is_empty.dart
+++ b/pkg/linter/lib/src/rules/prefer_is_empty.dart
@@ -186,7 +186,6 @@
required bool ignoreAs,
}) {
var search = expression;
- // ignore: literal_only_boolean_expressions
while (true) {
if (ignoreParens && search is ParenthesizedExpression) {
search = search.expression;
diff --git a/pkg/linter/test/rules/use_enums_test.dart b/pkg/linter/test/rules/use_enums_test.dart
index d354780..7310934 100644
--- a/pkg/linter/test/rules/use_enums_test.dart
+++ b/pkg/linter/test/rules/use_enums_test.dart
@@ -145,7 +145,6 @@
error(WarningCode.UNUSED_FIELD, 57, 1),
error(CompileTimeErrorCode.RECURSIVE_CONSTANT_CONSTRUCTOR, 76, 2),
// We are reversing the deprecation: This code will remain a `HintCode`.
- // ignore: deprecated_member_use
error(WarningCode.UNUSED_ELEMENT_PARAMETER, 83, 1),
],
);
diff --git a/pkg/linter/tool/checks/driver.dart b/pkg/linter/tool/checks/driver.dart
index 7e2185f..ad6487d 100644
--- a/pkg/linter/tool/checks/driver.dart
+++ b/pkg/linter/tool/checks/driver.dart
@@ -9,9 +9,9 @@
import 'package:analyzer/error/error.dart';
import 'package:analyzer/file_system/file_system.dart';
import 'package:analyzer/file_system/physical_file_system.dart';
-import 'package:analyzer/src/dart/analysis/analysis_options.dart'; // ignore: implementation_imports
-import 'package:analyzer/src/dart/analysis/driver_based_analysis_context.dart'; // ignore: implementation_imports
-import 'package:analyzer/src/lint/registry.dart'; // ignore: implementation_imports
+import 'package:analyzer/src/dart/analysis/analysis_options.dart';
+import 'package:analyzer/src/dart/analysis/driver_based_analysis_context.dart';
+import 'package:analyzer/src/lint/registry.dart';
import 'package:cli_util/cli_logging.dart';
import 'package:linter/src/analyzer.dart';
import 'package:linter/src/test_utilities/analysis_error_info.dart';
@@ -96,9 +96,10 @@
try {
var result = await context.currentSession.getErrors(filePath);
if (result is ErrorsResult) {
- var filtered = result.errors
- .where((e) => e.errorCode.name != 'TODO')
- .toList();
+ var filtered =
+ result.errors
+ .where((e) => e.errorCode.name != 'TODO')
+ .toList();
if (filtered.isNotEmpty) {
errors.add(AnalysisErrorInfo(filtered, result.lineInfo));
}
diff --git a/pkg/linter/tool/util/lint_driver.dart b/pkg/linter/tool/util/lint_driver.dart
index 2225f65..1813fbd 100644
--- a/pkg/linter/tool/util/lint_driver.dart
+++ b/pkg/linter/tool/util/lint_driver.dart
@@ -7,11 +7,8 @@
import 'package:analyzer/dart/analysis/results.dart';
import 'package:analyzer/file_system/file_system.dart';
import 'package:analyzer/instrumentation/instrumentation.dart';
-// ignore: implementation_imports
import 'package:analyzer/src/dart/analysis/analysis_context_collection.dart';
-// ignore: implementation_imports
import 'package:analyzer/src/generated/engine.dart' show AnalysisEngine;
-// ignore: implementation_imports
import 'package:analyzer/src/lint/io.dart';
import 'package:linter/src/test_utilities/analysis_error_info.dart';
import 'package:linter/src/test_utilities/linter_options.dart';
