tree 2a4ccbc5d31bf1ebd9ac64df11455c2515bb777e
parent 87eb37a19a81c3859d7f0a7587298273b33360d7
author Daco Harkes <dacoharkes@google.com> 1627382087 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> 1627382087 +0000

[vm] Reorder fields in LinkedHashBase

Split off https://dart-review.googlesource.com/c/sdk/+/203765 to make
that diff smaller.

Serializing the index incurs a large size penalty to snapshots. Rather
than serializing, we reconstruct the index based on the hashes that we
do serialize for all canonical objects. (Reconstructing the index is a
relatively cheap operation, recomputing the hashes is not.)

Note that to_snapshot is currently dead code, because we never serialize
non-const maps and sets in clustered snapshots.

Of course we do exercise the layout of the maps and sets itself.

Bug: https://github.com/dart-lang/sdk/issues/45908

TEST=The whole test suite including all map and set tests.

Change-Id: If54117497029e4da212c702a76c82de6d1531092
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-linux-debug-simarm_x64-try,vm-kernel-reload-rollback-linux-debug-x64-try,vm-kernel-nnbd-linux-debug-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208086
Reviewed-by: Tess Strickland <sstrickl@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>