commit bcf06bad4a1d925cc329bb94f1fbaff358a9207b
author Alexander Aprelev <aam@google.com> Tue Mar 09 16:22:00 2021 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> Tue Mar 09 16:22:00 2021 +0000
tree 4b15a6e934ec6bdda22d0eaf69466c6e28365439
parent c0124aed871b042ed425bf3f5bde08005540d011

[vm/concurrency] Fix Function bit field setters.

This is follow-up to 182d0dd156e58196a5e67555a5158524555d1bac.

TEST=flaky vm/dart_2/isolates/reload_many_isolates_live_and_die_test

Fixes https://github.com/dart-lang/sdk/issues/45169.

Change-Id: Ie59d26b7fc0594940742b37fe9ed0127e5871245
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/190040
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>

runtime/vm/object.h

diff --git a/runtime/vm/object.h b/runtime/vm/object.h
index 25e2fdf..f38ceba 100644
--- a/runtime/vm/object.h
+++ b/runtime/vm/object.h
@@ -3653,7 +3653,7 @@
 
 #define DEFINE_ACCESSORS(name, accessor_name)                                  \
   void set_##accessor_name(bool value) const {                                 \
-    untag()->kind_tag_.UpdateBool<name##Bit>(value);                           \
+    untag()->kind_tag_.UpdateUnsynchronized<name##Bit>(value);                 \
   }                                                                            \
   bool accessor_name() const { return untag()->kind_tag_.Read<name##Bit>(); }
   FOR_EACH_FUNCTION_KIND_BIT(DEFINE_ACCESSORS)
@@ -3661,7 +3661,7 @@
 
 #define DEFINE_ACCESSORS(name, accessor_name)                                  \
   void set_##accessor_name(bool value) const {                                 \
-    untag()->kind_tag_.UpdateUnsynchronized<name##Bit>(value);                 \
+    untag()->kind_tag_.UpdateBool<name##Bit>(value);                           \
   }                                                                            \
   bool accessor_name() const { return untag()->kind_tag_.Read<name##Bit>(); }
   FOR_EACH_FUNCTION_VOLATILE_KIND_BIT(DEFINE_ACCESSORS)