commit b980788bf9ab4c3bf2844b8ca3bf2d1725934b0e
author Ömer Ağacan <omersa@google.com> Thu May 29 12:13:42 2025 -0700
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu May 29 12:13:42 2025 -0700
tree ff9680ae4da88e505500f86686133fa64b2114a5
parent 41ac971d8a35ad3745e32d8cf423f261129f5df9

[test_runner] Use 'line' progress indicator by default when stdout is not a terminal

When the test runner output is piped to a file, 'compact' progress
indicator prints carriage returns to the file.

To avoid adding carriage returns to text files, only use 'compact'
indicator when stdout is a terminal. Otherwise use 'line' indicator.

Change-Id: Ic8ca111059799876caf401d3b040a5d3b5a7c731
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/431861
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Ömer Ağacan <omersa@google.com>

pkg/test_runner/lib/src/options.dart

diff --git a/pkg/test_runner/lib/src/options.dart b/pkg/test_runner/lib/src/options.dart
index bb593d8..7f3b0ba 100644
--- a/pkg/test_runner/lib/src/options.dart
+++ b/pkg/test_runner/lib/src/options.dart
@@ -180,7 +180,9 @@
     ..addOption('progress',
         abbr: 'p',
         allowed: Progress.names,
-        defaultsTo: Progress.compact.name,
+        defaultsTo: stdioType(stdout) == StdioType.terminal
+            ? Progress.compact.name
+            : Progress.line.name,
         help: '''Progress indication mode.
 
 Allowed values are:

pkg/test_runner/test/options_test.dart

diff --git a/pkg/test_runner/test/options_test.dart b/pkg/test_runner/test/options_test.dart
index 98c3cff..449a003 100644
--- a/pkg/test_runner/test/options_test.dart
+++ b/pkg/test_runner/test/options_test.dart
@@ -18,7 +18,6 @@
 void testDefaults() {
   // TODO(rnystrom): Test other options.
   var configuration = parseConfiguration([]);
-  Expect.equals(Progress.compact, configuration.progress);
   Expect.equals(NnbdMode.strong, configuration.nnbdMode);
 }