tree 3ce23c24f9f9e8e68c7e6a04b0780bccd7364061
parent eb448e30670a5444b68423d5a9bbcb19746843b4
author Sam Rawlins <srawlins@google.com> 1613918577 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> 1613918577 +0000

analyzer: Improve code quality around used element checking

This is being mailed ahead of the fix, as the fix will probably
require google3 cleanup first.

* Change outermost loop over `usedElements.prefixMap` from forEach to a
for-each loop which allows more efficient short-circuiting.
* Short-circuit continue when `_prefixElementMap[prefix] is null.
* Short-circuit continue when `namespace` is null in a few locations.

Bug: https://github.com/dart-lang/sdk/issues/45028
Change-Id: I5bf1e571c436132665a87625a46cdc0c3f1ef2d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186040
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>