| commit | cafc9016fc58e8db887ddb93fc171bf92f906686 | [log] [tgz] |
|---|---|---|
| author | Daco Harkes <dacoharkes@google.com> | Tue Jun 11 18:01:24 2024 +0000 |
| committer | Daco Harkes <dacoharkes@google.com> | Tue Jun 11 18:01:24 2024 +0000 |
| tree | f4931e5fa02f41a084231f5ab3611f9de6de37c5 | |
| parent | 153b668c8b43adde4d98cb0022a2e4a263926853 [diff] |
[stable][vm/ffi] Fix variadic arguments on MacOS Arm64 Non-variadic arguments on the stack on MacOS Arm64 are aligned to the value size (which can be smaller than word size). However, for varargs, the arguments on the stack seem to be aligned to the word size. This CL introduces an alignment strategy constant for primitives on the stack in varargs and uses it in the native calling convention calculation. TEST=runtime/vm/compiler/ffi/native_calling_convention_test.cc with runtime/vm/compiler/ffi/unit_tests/variadic_less_than_word/arm64_macos.expect TEST=tests/ffi/function_varargs_generated_native_leaf_test.dart Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/362762 Cherry-pick-request: https://github.com/dart-lang/sdk/issues/55943 Change-Id: I621b89d8554a5507c25d9fd24ca64cd954f37388 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369822 Reviewed-by: Martin Kustermann <kustermann@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.