)]}' { "commit": "a38a2dd34385f7e9711b0efdcd4558e45590b07c", "tree": "e9c84d10c59a2696911a0414a39f83128795f63a", "parents": [ "febf16a3be3fc3fb1ab4491407bf1aaf9c2c603e" ], "author": { "name": "Alexander Markov", "email": "alexmarkov@google.com", "time": "Tue Apr 06 18:33:17 2021 +0000" }, "committer": { "name": "commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Tue Apr 06 18:33:17 2021 +0000" }, "message": "[vm/aot] Fix retaining of targets of FFI callbacks in precompiler\n\nAccount for the fact that a Function could be only reachable via\nFfiTrampolineData in the FFI trampoline function.\n\nTEST\u003dffi_2/function_callbacks_test\nFixes https://github.com/dart-lang/sdk/issues/45510\n\nChange-Id: I2db81c7730ae48d1f1355aa236339e54562ee6c4\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/193893\nCommit-Queue: Alexander Markov \u003calexmarkov@google.com\u003e\nReviewed-by: Daco Harkes \u003cdacoharkes@google.com\u003e\nReviewed-by: Tess Strickland \u003csstrickl@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "e84949fe6c6dd4031236057440f478e083cf1259", "old_mode": 33188, "old_path": "runtime/vm/compiler/aot/precompiler.cc", "new_id": "4eddc2e3ff96fca2b721d3aeceeb16fcee621ab6", "new_mode": 33188, "new_path": "runtime/vm/compiler/aot/precompiler.cc" }, { "type": "modify", "old_id": "11baff64e1753c09db3644e0a25f4cb6ae013cd7", "old_mode": 33188, "old_path": "tests/ffi/function_callbacks_test.dart", "new_id": "e9a853c0343ebc200718505bf0af9a75d634f7d9", "new_mode": 33188, "new_path": "tests/ffi/function_callbacks_test.dart" }, { "type": "modify", "old_id": "11baff64e1753c09db3644e0a25f4cb6ae013cd7", "old_mode": 33188, "old_path": "tests/ffi_2/function_callbacks_test.dart", "new_id": "e9a853c0343ebc200718505bf0af9a75d634f7d9", "new_mode": 33188, "new_path": "tests/ffi_2/function_callbacks_test.dart" } ] }