tree 2c3196a40875c725e99c4a8a09faf7895beee6e1
parent a7bf05f64dd7e82deb22b24a7d23610f9916770b
author Ryan Macnak <rmacnak@google.com> 1614119281 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> 1614119281 +0000

[vm, gc] Don't hold PageSpace::tasks_lock_ while visiting remembered cards.

The scavenger may abort while visiting the remembered cards if we run out of memory. The longjmp implementing this abort would skip ~MonitorLocker, leaving the monitor locked and (in debug mode) Thread::no_safepoint_scope_ unbalanced.

TEST=fragmentation_test
Bug: https://github.com/dart-lang/sdk/issues/45059
Change-Id: I63d77709c8d8948b5827f7ecde5b0ecb3af9a245
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186640
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Liam Appelbe <liama@google.com>