commit | 3b9b77964d159d538080a55a60c47b3eca796fcd | [log] [tgz] |
---|---|---|
author | Tess Strickland <sstrickl@google.com> | Wed Nov 18 22:42:31 2020 +0000 |
committer | commit-bot@chromium.org <commit-bot@chromium.org> | Wed Nov 18 22:42:31 2020 +0000 |
tree | 99aff96b88e3006f36dc5f9322cc959963eeb0a9 | |
parent | 1d1137666cdbcf3de9c995e17e00b265216415a0 [diff] |
Reland "[vm/compiler] Move AssertAssignables out of closure bodies." This is a reland of 42c76fd9102136fef9223349cbde145462a18f5c Main issue was due to the parameter order of the invoke field dispatcher not matching the argument order described by its saved arguments descriptor. There's no reason for it not to, so now it does. Also fixes some issues with stack trace tests that failed due to increased deduplication of closures by forbidding deduplication for those tests. TEST=Run on trybots of all architectures as well as flutter engine trybot, new test added for downstream issues seen after initial landing. Original change's description: > [vm/compiler] Move AssertAssignables out of closure bodies. > > This CL moves the final set of checks out of closure bodies and into > dynamic closure call dispatchers. It also adds stubs for checking top > types and null assignability for types only known at runtime. > > Fixes https://github.com/dart-lang/sdk/issues/40813 . > > Changes in Flutter gallery in release mode: > > * arm7: -3.05% total, +0.99% vmisolate, -0.89% isolate, > -1.20% readonly, -4.43% instructions > * arm8: -3.20% total, +0.99% vmisolate, -0.88% isolate, > -1.18% readonly, -5.05% instructions > > TEST=Run on trybots of all architectures, includes test adjustments where needed. > > Cq-Include-Trybots: luci.dart.try:vm-kernel-linux-debug-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-linux-debug-ia32-try,vm-kernel-nnbd-linux-debug-ia32-try,vm-kernel-precomp-linux-debug-simarm_x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-debug-simarm_x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-linux-release-simarm-try,vm-kernel-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-simarm-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-precomp-linux-release-simarm-try,vm-kernel-precomp-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try > Change-Id: Ifb136c64339be76a642ecbb4fda26b6ce8f871f9 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166622 > Commit-Queue: Tess Strickland <sstrickl@google.com> > Reviewed-by: Martin Kustermann <kustermann@google.com> > Reviewed-by: RĂ©gis Crelier <regis@google.com> Change-Id: Ic5ec59cf355f7779bb82db798d97d762ba1e5556 Cq-Include-Trybots: luci.dart.try:vm-kernel-linux-debug-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-linux-debug-ia32-try,vm-kernel-nnbd-linux-debug-ia32-try,vm-kernel-precomp-linux-debug-simarm_x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-debug-simarm_x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-linux-release-simarm-try,vm-kernel-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-simarm-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-precomp-linux-release-simarm-try,vm-kernel-precomp-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-linux-product-x64-try,vm-kernel-linux-product-x64-try,flutter-engine-linux-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172644 Commit-Queue: Tess Strickland <sstrickl@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, getting started, and more.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.