commit | d499f68df5d792380dbe96a5181fe6e114067785 | [log] [tgz] |
---|---|---|
author | Vyacheslav Egorov <vegorov@google.com> | Sun Feb 21 15:48:27 2021 +0000 |
committer | commit-bot@chromium.org <commit-bot@chromium.org> | Sun Feb 21 15:48:27 2021 +0000 |
tree | b07bfa303945cb1f2f1694ba5dc106efdb0ab836 | |
parent | 0ed3fb3deecc85ba8e373d58184d0c05457885b4 [diff] |
[vm] Fix vm_snapshot_analysis logic and tests * When looking for Code node owner simply always check for synthetic owner (referenced through ':owner_' property) first. If it is present then it means 'owner_' property is invalid anyway. 25fd0200ef1 changed how WSRs are written into snapshot (instead of writing WSRs we are simply writing SMI CIDs) which broke previous logic. * When building ProgramInfoNode for a Class node accommodate for the existence of classes which don't have 'library_' property (e.g. base objects like void and dynamic). Additionally, adjust how these base objects are written into the snapshot profile so that we preserve their names. * Tweak tests diff and diff-collapse tests to pass, they were failing because prologue removal compiler change made some of the diffs so tiny that they are ignored by threshold filtering. * Add two more tests: one that verifies that tracings flags don't have any impact on the snapshot size and one that checks we correct attribute instructions size to the function node from which these instructions originated. This last test is added in anticipation of Code object removal to make sure that vm_snapshot_analysis continues to work correctly. * Adjust sorting rules for Code cluster to make it more stable between slightly different programs to stabilize output of --print-instructions-sizes-to (depends on the sorting algorithm used in libc, the test was failing on Mac but not on Linux). These fixes should unblock relanding of b6dc4dad4da Fixes #44507 Fixes flutter/flutter#76313 TEST=pkg/vm_snapshot_analysis/test/instruction_sizes_test.dart Cq-Include-Trybots: luci.dart.try:pkg-linux-release-try,pkg-win-release-try,pkg-mac-release-try Change-Id: Iee0221dd3a507cb4f36d530404693ebfab3b7bf2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185826 Commit-Queue: Vyacheslav Egorov <vegorov@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.