commit | bb1640eec2db34c1da83a9d962a27bc9088fa251 | [log] [tgz] |
---|---|---|
author | Tess Strickland <sstrickl@google.com> | Mon Sep 27 10:57:18 2021 +0000 |
committer | commit-bot@chromium.org <commit-bot@chromium.org> | Mon Sep 27 10:57:18 2021 +0000 |
tree | c682b24962d8dc74806eb73ee5a3cd8e840b0812 | |
parent | 11f497f6abdac070987cc97a49c8dc8e314e0677 [diff] |
Reland "[vm/compiler] Add more checks in TTSes for uninstantiated types." This is a reland of 1016bbaddeb79126f244e78b39d590f4d2e39a32 The broken benchmarks causing the revert were not due to this CL. TEST=vm/cc/TTS Original change's description: > [vm/compiler] Add more checks in TTSes for uninstantiated types. > > In certain cases, optimized type testing stubs for uninstantiated types > compare the instantiation of the type arguments for the type against the > corresponding instance type arguments. Previously, only an identity > check was generated, so the instantiation had to match the instance type > argument exactly. > > This CL adds checks for the following cases: > * The instantiated type argument is dynamic, void, or Object. > * The instance type argument is Null or Never. > > When strong null safety is enabled, we also check that the the instance > type argument is legacy or non-nullable when the instantiated type > argument is non-nullable Object or that the instantiated type argument > is nullable or legacy when the instance type argument is Null. > > This CL also adds handling for the case where the instantiated or > instance type argument is not a Type, which is necessary for safely > retrieving the type class id and nullability, and allocates some > additional registers in TTSInternalRegs for storing type arguments. On > ARM7, this requires pushes/pops around type argument checking, because > we've run out of registers there. > > Fixes https://github.com/dart-lang/sdk/issues/40736 > > TEST=vm/cc/TTS > > Bug: https://github.com/dart-lang/sdk/issues/46920 > Cq-Include-Trybots: luci.dart.try:vm-kernel-linux-release-x64-try,vm-kernel-precomp-linux-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-linux-product-x64-try,vm-kernel-precomp-linux-product-x64-try,vm-kernel-linux-release-simarm-try,vm-kernel-linux-release-simarm64-try > Change-Id: Ib8498fd2b9593b4abb92111f062ed2fc95a45c16 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210681 > Commit-Queue: Tess Strickland <sstrickl@google.com> > Reviewed-by: Alexander Markov <alexmarkov@google.com> Bug: https://github.com/dart-lang/sdk/issues/46920 Change-Id: Id84730b3bb292ea7fdfe9ebd8b1fc6e71c64cf22 Cq-Include-Trybots: luci.dart.try:vm-kernel-linux-release-x64-try,vm-kernel-precomp-linux-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-linux-product-x64-try,vm-kernel-precomp-linux-product-x64-try,vm-kernel-linux-release-simarm-try,vm-kernel-linux-release-simarm64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/211901 Commit-Queue: Tess Strickland <sstrickl@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.