commit | 5d7445e97228496ab017dd9a7000793b6af4a951 | [log] [tgz] |
---|---|---|
author | Paul Berry <paulberry@google.com> | Tue Feb 15 00:32:50 2022 +0000 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Feb 15 00:32:50 2022 +0000 |
tree | 8159bae7bbffa05cdc53f9b0ea7b92bf5c2f3dbd | |
parent | a2f887ea5964ebd86f42051f39f3360dfa58aee5 [diff] |
Migration: respect built_value `@nullable` annotations even when there is no codegen Previously, when the migration tool encountered a built_value `@nullable` annotation, it removed it, because when the built_value code generator is consuming a library with null safety enabled, it relies on the presence of a `?` to determine nullability, rather than an annotation. However, there was no logic to actually ensure that the `?` would actually get introduced, because I thought the code generated by built_value would always create the conditions necessary to convince the migration tool to introduce the `?` using its normal graph traversal algorithm. It turns out this is not the case: when `@nullable` appears in an interface class that is used by other built_value classes, but is not itself a built_value class, the migration tool sometimes doesn't have enough information to figure out that it needs to add the `?`. So in this CL, I'm doing what I probably should have done in the first time: adding the necessary logic to the migration tool to ensure that the `@nullable` annotation gets translated into a `?` regardless of whether it is required to by generated code. Bug: https://buganizer.corp.google.com/issues/217863427 Change-Id: I9efe5241634389981a4c56e764bac91b3350c4fb Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233003 Reviewed-by: Samuel Rawlins <srawlins@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.