commit 7667df56fdb93016c3995fbe93415d1d2879858e
author Alexander Markov <alexmarkov@google.com> Tue Sep 24 15:04:18 2024 +0000
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Sep 24 15:04:18 2024 +0000
tree fceb6d9f915d68abb006becb6b4d018eb1ce370c
parent 812b03da647704c6b0993f2ee293b124226b5f94

[gardening] Fix regress_56756_il_test on vm-aot-optimization-level-linux-release-x64

Adjust IL test to avoid much more agressive inlining on
vm-aot-optimization-level-linux-release-x64 bot.

TEST=runtime/tests/vm/dart/regress_56756_il_test.dart
Fixes https://github.com/dart-lang/sdk/issues/56776

Change-Id: I225049a93990c80773ff640e4a4a6fb9aad0c0fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/386540
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>

runtime/tests/vm/dart/regress_56756_il_test.dart

diff --git a/runtime/tests/vm/dart/regress_56756_il_test.dart b/runtime/tests/vm/dart/regress_56756_il_test.dart
index 3a49345..0661149 100644
--- a/runtime/tests/vm/dart/regress_56756_il_test.dart
+++ b/runtime/tests/vm/dart/regress_56756_il_test.dart
@@ -9,13 +9,21 @@
 
 import 'dart:math';
 
+@pragma('vm:never-inline')
+void myprint(Object o) {
+  print(o);
+}
+
 class RandomValue {
   final bool shouldReturnValue;
   const RandomValue(this.shouldReturnValue);
 
+  @pragma('vm:never-inline')
+  String randomString() => Random().nextInt(42).toString();
+
   @pragma('vm:prefer-inline')
   String? get valueOrNull {
-    return shouldReturnValue ? "${Random().nextInt(42)}" : null;
+    return shouldReturnValue ? randomString() : null;
   }
 }
 
@@ -23,7 +31,7 @@
 @pragma('vm:testing:print-flow-graph')
 void doTest(RandomValue value) {
   if (value.valueOrNull case final String aString) {
-    print(aString);
+    myprint(aString);
   }
 }
 
@@ -48,8 +56,6 @@
     ]),
     'B8' <<
         match.block('Target', [
-          match.StaticCall(),
-          match.StaticCall(),
           'v19' << match.StaticCall(),
           match.Goto('B10'),
         ]),