| commit | ea5195f0db7c081f8dc4468228e662f40e323ed3 | [log] [tgz] |
|---|---|---|
| author | Paul Berry <paulberry@google.com> | Fri Jan 15 12:54:22 2016 -0800 |
| committer | William Hesse <whesse@google.com> | Mon Jan 18 09:54:25 2016 +0100 |
| tree | 1b01e9c300dde46eb92a93e17f08c34c7a07e1bb | |
| parent | 2d6532c3d0ddfb7cd065dbeb4cd0ef4ddd15dbfe [diff] |
Fix newline normalization in _PhysicalFile.readAsStringSync(). Most clients of _PhysicalFile read the file by translating it into a Source object using createSource() and then reading it using FileBasedSource.contentsFromFile, which normalizes newlines using FileBasedSource.fileReadMode. However, a few clients read the file directly using _PhysicalFile.readAsStringSync(), which wasn't doing the normalization. This CL adds the normalization to that code path. One such client was the code generation logic for summaries; this caused code generation to produce different results on Windows, which led to a test failure. Fixes #25470. R=brianwilkerson@google.com Review URL: https://codereview.chromium.org/1584313010 .
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
Learn how to get the source and prepare your machine to build the SDK.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
See LICENSE.