[DEPS] Roll chrome to the latest beta version (127)
Change-Id: If25ddfee99f25c4d171ee646d86892430ce92f1f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/375902
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Nate Biggs <natebiggs@google.com>
diff --git a/DEPS b/DEPS
index 4adfc78..9308f4f 100644
--- a/DEPS
+++ b/DEPS
@@ -207,7 +207,7 @@
# meant to be downloaded by users for local testing. You can self-service
# update these by following the go/dart-engprod/browsers.md instructions.
"download_chrome": False,
- "chrome_tag": "121.0.6167.85",
+ "chrome_tag": "127.0.6533.43",
"download_firefox": False,
"firefox_tag": "127.0.2",
diff --git a/pkg/dev_compiler/test/expression_compiler/assertions_enabled_test.dart b/pkg/dev_compiler/test/expression_compiler/assertions_enabled_test.dart
index 73b5ed7..8ac3986 100644
--- a/pkg/dev_compiler/test/expression_compiler/assertions_enabled_test.dart
+++ b/pkg/dev_compiler/test/expression_compiler/assertions_enabled_test.dart
@@ -45,23 +45,32 @@
await driver.checkInFrame(
breakpointId: 'bp',
expression: 'myAssert()',
- expectedError: allOf(
- contains('Error: Assertion failed:'),
- contains('test.dart:8:16'),
- contains('false'),
- contains('is not true'),
- ));
+ // TODO(sigmund): Since Chrome 125, Chrome broke how errors are
+ // printed. The fix landed in Chrome 128. When that version gets
+ // rolled, this expectation can be updated back to:
+ // expectedError: allOf(
+ // contains('Error: Assertion failed:'),
+ // contains('test.dart:8:16'),
+ // contains('false'),
+ // contains('is not true'),
+ // ));
+ expectedError: startsWith('Error\n'));
});
+
test('assert errors in evaluated expression', () async {
await driver.checkInFrame(
breakpointId: 'bp',
expression: '() { assert(false); return 0; } ()',
- expectedError: allOf(
- contains('Error: Assertion failed:'),
- contains('org-dartlang-debug:synthetic_debug_expression:1:13'),
- contains('false'),
- contains('is not true'),
- ));
+ // TODO(sigmund): Since Chrome 125, Chrome broke how errors are
+ // printed. The fix landed in Chrome 128. When that version gets
+ // rolled, this expectation can be updated back to:
+ // expectedError: allOf(
+ // contains('Error: Assertion failed:'),
+ // contains('org-dartlang-debug:synthetic_debug_expression:1:13'),
+ // contains('false'),
+ // contains('is not true'),
+ // ));
+ expectedError: startsWith('Error\n'));
});
});
}
diff --git a/pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_shared.dart b/pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_shared.dart
index 65308cb..dc295d8 100644
--- a/pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_shared.dart
+++ b/pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_shared.dart
@@ -822,8 +822,12 @@
await driver.checkInFrame(
breakpointId: 'lateGlobalVariableBP',
expression: 'lateGlobal2',
- expectedError: 'Error: LateInitializationError: '
- "Field 'lateGlobal2' has not been initialized.");
+ // TODO(sigmund): Since Chrome 125, Chrome broke how errors are
+ // printed. The fix landed in Chrome 128. When that version gets
+ // rolled, this expectation can be updated back to:
+ //expectedError: 'Error: LateInitializationError: '
+ // "Field 'lateGlobal2' has not been initialized.");
+ expectedError: startsWith('Error\n'));
});
});
});
diff --git a/tests/dartdevc/debugger/debugger_test_golden.txt b/tests/dartdevc/debugger/debugger_test_golden.txt
index de76704..4061cf3 100644
--- a/tests/dartdevc/debugger/debugger_test_golden.txt
+++ b/tests/dartdevc/debugger/debugger_test_golden.txt
@@ -5457,7 +5457,7 @@
{
"style": ""
},
- "Error: Instance of 'Error'"
+ "Error"
]
]
],
