commit | efa7439c1668d7474b39bd75c66d49ba0405c352 | [log] [tgz] |
---|---|---|
author | Daco Harkes <dacoharkes@google.com> | Fri May 06 10:24:29 2022 +0000 |
committer | Commit Bot <commit-bot@chromium.org> | Fri May 06 10:24:29 2022 +0000 |
tree | c2379bd68710814d290228bf118d8d4f7e3b5475 | |
parent | b488bd1a75940c43ee236bfe05b562b42c63eb05 [diff] |
Revert "[vm] Only call `.hashCode` once when adding to `Map` and `Set`" This reverts commit 438c1ed2ba5966fee2e5e44f13956154358492f9. Reason for revert: b/231617607 and b/230945329. Will reland after b/230945329 is addressed. Original change's description: > [vm] Only call `.hashCode` once when adding to `Map` and `Set` > > The methods to add to hash maps and hash sets are recursive: if the > index needs to be rehashed then the same method is called again after > rehashing. > > This CL nests the actual implementation in a private method that takes > the full hashCode as an extra argument. > > No significant code size or run time changes are reported on our > benchmarks. (Our benchmarks do not contain purposefully slow hashCodes.) > > Note that hashCode can be called again later if rehashing of the index > is required on adding subsequent elements. > > Bug: https://github.com/dart-lang/sdk/issues/48948 > Change-Id: Ia3ccff9e592d675b4922ac78c4aa7ee0287ecb50 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243623 > Reviewed-by: Martin Kustermann <kustermann@google.com> > Commit-Queue: Daco Harkes <dacoharkes@google.com> TBR=kustermann@google.com,dacoharkes@google.com Change-Id: I214251b65ea89e7f729564a125e226f2e6d580c0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: https://github.com/dart-lang/sdk/issues/48948 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243900 Commit-Queue: Daco Harkes <dacoharkes@google.com> Reviewed-by: Daco Harkes <dacoharkes@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.