commit 4d5ac43514c11fa6f1d26804c8a43c7dd91f8b7b
author Nate Biggs <natebiggs@google.com> Tue Aug 16 15:54:48 2022 +0000
committer Commit Bot <commit-bot@chromium.org> Tue Aug 16 15:54:48 2022 +0000
tree 6186ec591f457c2c0834a96fe638df89a8376713
parent 4c7110332e2c81366b6e85cb231a59840e370cd6

[dart2js] Change default values for dependencies in js_backend/runtime_type_resolution.dart

Default value of `dependencies` should be `const {}` (and narrow field type) so that VM can devirtualize calls to the `_CompactLinkedHashSet` when iterating.

Change-Id: I112d9cd9a3cd060a38e292bc1a3c54a8a2847dfe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252301
Commit-Queue: Nate Biggs <natebiggs@google.com>
Reviewed-by: Mayank Patke <fishythefish@google.com>

pkg/compiler/lib/src/js_backend/runtime_types_resolution.dart

diff --git a/pkg/compiler/lib/src/js_backend/runtime_types_resolution.dart b/pkg/compiler/lib/src/js_backend/runtime_types_resolution.dart
index 1ac3892..e60b9b1 100644
--- a/pkg/compiler/lib/src/js_backend/runtime_types_resolution.dart
+++ b/pkg/compiler/lib/src/js_backend/runtime_types_resolution.dart
@@ -26,10 +26,9 @@
   Entity get entity;
 
   Set<RtiNode>? _dependencies;
+  Set<RtiNode> get dependencies => _dependencies ?? const {};
+
   bool _hasTest = false;
-
-  Iterable<RtiNode> get dependencies => _dependencies ?? const [];
-
   bool get hasTest => _hasTest;
 
   /// Register that if [entity] needs type arguments then so does `node.entity`.